[edk2-devel] [PATCH 1/1] BaseTools:Fix build tools print traceback info issue

2020-03-19 Thread Fan, ZhijuX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2610 We meet a case that the DEC file declaring the PCD isn't included in the INF.it cause build tools report Traceback error. Remove raise statements that generate Tracebacks that were only intended for development/debug. With the raise stateme

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI.

2020-03-19 Thread Bob Feng
I agree with Mike. No need to change BaseTools. Thanks, Bob -Original Message- From: Gao, Liming Sent: Friday, March 20, 2020 11:28 AM To: Kinney, Michael D ; Chang, Abner (HPS SW/FW Technologist) ; devel@edk2.groups.io; Ni, Ray ; Feng, Bob C Cc: Leif Lindholm ; Chen, Gilbert ; Sch

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI.

2020-03-19 Thread Liming Gao
Include Bob to confirm BaseTools behavior. Thanks Liming > -Original Message- > From: Kinney, Michael D > Sent: Friday, March 20, 2020 9:17 AM > To: Gao, Liming ; Chang, Abner (HPS SW/FW Technologist) > ; devel@edk2.groups.io; > Ni, Ray ; Kinney, Michael D > Cc: Leif Lindholm ; Chen, G

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 03/25/2020 9:30am-10:30am #cal-reminder

2020-03-19 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 25 March 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/493235016 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=752976 ) *Organizer:* Brian Richardson brian.richard...@intel.com

Re: [edk2-devel] [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl

2020-03-19 Thread Abner Chang
> -Original Message- > From: Kinney, Michael D [mailto:michael.d.kin...@intel.com] > Sent: Friday, March 20, 2020 9:00 AM > To: Chang, Abner (HPS SW/FW Technologist) ; > devel@edk2.groups.io; Bi, Dandan ; Kinney, Michael > D > Cc: Leif Lindholm ; Gao, Liming ; > Ard Biesheuvel ; Laszlo Ers

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 01/11] FatPkg: Add RISC-V architecture for EDK2 CI.

2020-03-19 Thread Michael D Kinney
Liming, I agree that spec updates would be good so the CPU arch name RISCV64 can be reserved. However, I believe the current specs define their EBNF to be flexible and support new CPU archs without a spec change. As long as BaseTools follows the EBNF, no build tool changes should be required to

[edk2-devel] Upcoming Event: TianoCore Design Meeting - APAC/NAMO - Fri, 03/20/2020 9:30am-10:30am #cal-reminder

2020-03-19 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design Meeting - APAC/NAMO *When:* Friday, 20 March 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://zoom.com.cn/j/971006237 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=700769 ) *Organizer:* Ray Ni ray...@intel.com ( ray...@intel.com?

Re: [edk2-devel] [edk2/master PATCH DxeIplHandoffLib v1] MdePkg/DxeIplHandoffLibNullLib: Abstract DxeIpl

2020-03-19 Thread Michael D Kinney
Abner, If the ARM/AARCH64/RISCV64 content required by DxeIpl were added to MdePkg or MdeModulePkg could we remove the need for this new lib class? What RISCV64 content needs to be added to MdePkg/MdeModulePkg so all CPUs are supported the same way? Thanks, Mike > -Original Message- > F

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v2 2/5] RiscVPkg: Add RiscVPkg yaml file for EDK2 CI.

2020-03-19 Thread Michael D Kinney
Abner, Let's not add the YAML file for a new package until the content for the new package is added or add the YMAL file with the patch series that adds the new package. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Abner Chang > Sent: Monday, March 9,

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v2 1/5] RiscVPlatformPkg: Add RiscVPlatformPkg yaml file for EDK2 CI.

2020-03-19 Thread Michael D Kinney
Abner, Let's not add the YAML file for a new package until the content for the new package is added or add the YMAL file with the patch series that adds the new package. Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Abner Chang > Sent: Monday, March 9, 2

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

2020-03-19 Thread Nate DeSimone
Hi Bret, I alluded to this a little bit in the cover letter, completely agreed a more detailed explanation is needed. There is an odd situation with the way GitPython’s dependencies are evolved over time. Initially, they had the following dependency graph: * GitPython * gitdb

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

2020-03-19 Thread Bret Barkelew via Groups.Io
Naïve question: why isn’t this upgrade handled when pip installs the new wheel? Are the dependencies not matched up correctly? I would think that pip would uninstall the old version on its own. - Bret From: Desimone, Ashley E Sent: Thursday, March 19, 2020 12

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 0/4] Update 3rd party dependencies

2020-03-19 Thread Desimone, Ashley E
Can you elaborate on the poor situation regarding GitPython dependencies that you are working around? Additionally please update the appropriate documentation to reflect the updated EdkRepo dependencies. Thanks, Ashley -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, M

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 4/4] EdkRepo: Update 3rd party packages in installer config

2020-03-19 Thread Desimone, Ashley E
Reviewed-by: Ashley DeSimone -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, March 18, 2020 8:17 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH 4/4] EdkRepo: Update 3rd party p

Re: [edk2-devel] [PATCH 1/4] EdkRepo: Installer should remove obsolete dependencies

2020-03-19 Thread Desimone, Ashley E
For the following section why are we singling out gitdb2 and smmap2 when deleting obsolete dependencies? Is there an alternative to hardcoding these values? +if (DeleteObsoletePackages) +{ +// +// Delete obsolete dependencie

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/ARM/SgiPkg: Create individual Platform Description File

2020-03-19 Thread Leif Lindholm
Hi Aditya, On Thu, Mar 12, 2020 at 20:05:13 +0530, Aditya Angadi wrote: > From: Vijayenthiran Subramaniam > > In preparation for adding support for Reference Design (RD) platforms > that have different base addresses for GIC distributor or redistributor, > create individual platform description

Re: [edk2-devel] [PATCH] ArmPkg/ArmLib: Fix cache-invalidate initial page tables

2020-03-19 Thread Leif Lindholm
On Thu, Mar 19, 2020 at 10:37:05 -0600, Ashish Singhal wrote: > Because of a bug, current EL gets passed to DC IVAC instruction instead > of the VA entry that needs to be invalidated. Oh, yeah, that's obviously a bug. What idiot reviewed that patch? Oh, me... OK, so I should have added a referenc

[edk2-devel] [PATCH] MdeModulePkg/HiiDatabase: Do not modify CONST string

2020-03-19 Thread Jeff Brasen
Update function behavior to not modify the incoming string that is marked as CONST in the prototype. Signed-off-by: Jeff Brasen --- .../Universal/HiiDatabaseDxe/ConfigRouting.c| 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/MdeModulePkg/Universal/HiiData

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH 4/4] EdkRepo: Update 3rd party packages in installer config

2020-03-19 Thread Bjorge, Erik C
Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Nathaniel L Sent: Wednesday, March 18, 2020 8:17 PM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew Subject: [edk2-staging/EdkRepo] [PATCH 4/4] EdkRepo: Update 3rd party packag

[edk2-devel] [PATCH] ArmPkg/ArmLib: Fix cache-invalidate initial page tables

2020-03-19 Thread Ashish Singhal
Because of a bug, current EL gets passed to DC IVAC instruction instead of the VA entry that needs to be invalidated. Signed-off-by: Ashish Singhal --- ArmPkg/Library/ArmLib/AArch64/ArmLibSupport.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ArmPkg/Library/ArmLib/AArch64/

[edk2-devel] [PATCH v2 22/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use default ArmPlatformHelper.S

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Default ArmPlatformHelper.S from ArmPlatformPkg is suffecient for LS1043ARDB ArmPlatformLib. Use the same. Signed-off-by: Pankaj Bansal --- .../AArch64/ArmPlatformHelper.S | 60 --- .../Library/ArmPlatformLib/ArmPlatformLib.c | 8 --- .../Li

[edk2-devel] [PATCH v2 20/28] Silicon/NXP/LS1043A: Move SocLib to Soc Package

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal The SocLib contains code specific to an Soc. it should be part of SOC package. Therefore, move the SocLib to Soc Package. Since we are moving the files to Soc Package, no need to mention the Soc name in file names. Their location is enough to indicate for which Soc the files a

[edk2-devel] [PATCH v2 17/28] Silicon/NXP: Use Clock retrieval PPI in modules

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Use NXP_PLATFORM_GET_CLOCK_PPI in various Layerscape IP modules. Signed-off-by: Pankaj Bansal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 -- Silicon/NXP/Drivers/I2cDxe/I2cDxe.c | 3 +- Silicon/NXP/Drivers/I2cDxe/I2cDxe.h | 6 Silicon/N

[edk2-devel] [PATCH v2 27/28] Silicon/NXP: move MemoryInitPeiLib as per PEIM structures

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal MemoryInitPeiLib would be linked to MemoryInitPeim, when we implement PEI phase. therefore, move the library to directory of same name. Signed-off-by: Pankaj Bansal --- .../{MemoryInitPei => MemoryInitPeiLib}/MemoryInitPeiLib.c | 0 .../{MemoryInitPei => MemoryInitPeiLi

[edk2-devel] [PATCH v2 28/28] Platform/NXP/LS1043aRdbPkg: Add PEI Phase

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Add PEI phase to LS1043aRdb. This is needed becuase we need to have dynamic PCDs support to be able to reserve memory before reporting memory to UEFI fimrware. Signed-off-by: Pankaj Bansal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 9 --- Platform/NXP/LS1043aRdbPk

[edk2-devel] [PATCH v2 25/28] Platform/NXP: Modify FV rules

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Use same FV rules as ArmVirtPkg/ArmVirtRules.fdf.inc Signed-off-by: Pankaj Bansal --- Platform/NXP/FVRules.fdf.inc | 59 +++- 1 file changed, 38 insertions(+), 21 deletions(-) diff --git a/Platform/NXP/FVRules.fdf.inc b/Platform/NXP/FVRules.

[edk2-devel] [PATCH v2 19/28] Silicon/NXP/LS1043A: Use ChassisLib from Chassis2 Pkg

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Now the we have added Chassis Package, move the chassis specific common code for all SOCs belonging to same chassis to ChassisLib. Use ChassisLib APIs in SocLib. Signed-off-by: Pankaj Bansal --- .../Drivers/PlatformDxe/PlatformDxe.inf | 1 + .../Library/ArmPlatformL

[edk2-devel] [PATCH v2 16/28] Platform/NXP/LS1043aRdbPkg: Add Clock retrieval APIs

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal The SOC takes primary clocking input from the external signal (a clock generator on board). The input (frequency) is multiplied using multiple phase locked loops (PLL) to create a variety of frequencies which can then be passed to a variety of internal logic, including cores a

[edk2-devel] [PATCH v2 26/28] Platform/NXP/LS1043aRdbPkg: Add VarStore

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Add VarStore Fd. This Fd is used to store non volatile variables in flash. Signed-off-by: Pankaj Bansal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.fdf | 3 +- Platform/NXP/LS1043aRdbPkg/VarStore.fdf.inc | 91 2 files changed, 93 insertions(+), 1 del

[edk2-devel] [PATCH v2 21/28] Slicon/NXP: Add PlatformPei Lib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal PlatformPeiLib is going to be linked to Platform PEIM. Signed-off-by: Pankaj Bansal --- .../Library/PlatformPeiLib/PlatformPeiLib.c | 30 ++ .../Library/PlatformPeiLib/PlatformPeiLib.inf | 41 +++ Silicon/NXP/NxpQoriqLs.dsc.inc|

[edk2-devel] [PATCH v2 23/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Use Allocate pool

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Allocate Pages may allocate more memory than required for VirtualMemoryTable. There is no special requirement that VirtualMemoryTable size should be page size aligned. Therefore, replace AllocatePages with AllocatePool. Signed-off-by: Pankaj Bansal --- .../LS1043aRdbPkg/Li

[edk2-devel] [PATCH v2 18/28] Silicon/NXP: Add Chassis2 Package

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal A Chassis is a base framework used for building SoCs. We can think of Chassis/Soc/Platform(a.k.a Borad) in Oops terms. Chassis is base. Soc is based on some Chassis. Platform is based on some Soc. SOCs that are designed around same chassis, reuse most of the components. Ther

[edk2-devel] [PATCH v2 24/28] NXP/LS1043aRdbPkg/ArmPlatformLib: Remove extern SocInit

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal SocInit can be defined in SocLib.h No need to make it extern in ArmPlatformLib Signed-off-by: Pankaj Bansal --- .../LS1043aRdbPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 2 -- Silicon/NXP/Include/Library/SocLib.h | 8 2 files changed, 8 inser

[edk2-devel] [PATCH v2 00/28] Add PEI phase to LS1043ARDB Platform

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal This patch series adds PEI phase to NXP LS1043ARDB Platform. The previous attempt at this feature can be referred here: https://edk2.groups.io/g/devel/message/54006 I have taken care of the review comments received on v1 and have broken down the patches further to make review

[edk2-devel] [PATCH v2 13/28] Silicon/NXP: Move dsc file

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal As per convention being followed in edk2-platforms, keep the dec file and dsc file together. Signed-off-by: Pankaj Bansal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 +- {Platform => Silicon}/NXP/NxpQoriqLs.dsc.inc | 0 2 files changed, 1 insertion(+), 1 deletion(-

[edk2-devel] [PATCH v2 11/28] Silicon/NXP: remove not needed components

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal The structures elements and functions that are not necessary for booting for now are being deleted. Once the directory structure has been changed (i.e. we have clear distinction between chassis code and header files and SOC code and header files), we will put back the code and

[edk2-devel] [PATCH v2 05/28] Silicon/Maxim: Add comments in Ds1307RtcLib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Add comments to explain the register read and write operation on Ds1307. These comments have been referred from data sheet: https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Signed-off-by: Pankaj Bansal --- Silicon/Maxim/Library/Ds1307RtcLib/Ds1307RtcLib.c | 8 ++

[edk2-devel] [PATCH v2 04/28] Silicon/Maxim: Fix bug in RtcWrite in Ds1307RtcLib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal There was a bug in I2C DXE implementation, which caused the Ds1307 RTC device to issue two operation for register write, while this is a single operation task. refer page 12 (Slave Receiver Mode (Write Mode)) on https://datasheets.maximintegrated.com/en/ds/DS1307.pdf Modify

[edk2-devel] [PATCH v2 07/28] Silicon/NXP: Implement SerialUartClockLib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Implement SerialUartClockLib for all NXP Layerscape Platforms. Signed-off-by: Pankaj Bansal --- .../SerialUartClockLib/SerialUartClockLib.c | 27 +++ .../SerialUartClockLib/SerialUartClockLib.inf | 26 ++ 2 files changed, 53 insertions(+)

[edk2-devel] [PATCH v2 12/28] Silicon/NXP: Remove unnecessary PCDs

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal The memory map of an SOC is fixed in hardware. it doesn't change with platform that uses SOC. So, there is no need to keep PCDs for these values and we can use macros for these in SOC header file. Any Platform using the SOC, can make use of the SOC header file. Signed-off-by

[edk2-devel] [PATCH v2 14/28] Platform/NXP: rename the ArmPlatformLib as per ArmPlatformPkg

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Keep the names and location of files as mentioned in ArmPlatformPkg. This helps in porting the common changes (if any in future) easily. Signed-off-by: Pankaj Bansal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 2 +- .../AArch64/ArmPlatformHelper.S}

[edk2-devel] [PATCH v2 06/28] NXP/LS1043aRdb: Move Soc specific components to soc files

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal Soc specific components ought to be part of Soc files and not platform files. move the same to SOC files Signed-off-by: Pankaj Bansal --- Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 7 +-- Platform/NXP/NxpQoriqLs.dsc.inc | 2 ++ Silicon/NXP/LS1043A/LS104

[edk2-devel] [PATCH v2 10/28] Silicon/NXP: remove print information from Soc lib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal The Soc info being printed can be removed from SOC lib. We are in the process of implementing PEI Phase. After PEI phase impelmentation this info would be printed in common PEIM based on the information retrieved from PPIs. e.g. gArmMpCoreInfoPpiGuid can be used to print cluse

[edk2-devel] [PATCH v2 02/28] Silicon/NXP: changes to use I2clib in i2cdxe

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal I2c lib contains the i2c controller functionality. this can be used in I2c DXE driver to communicate with i2c devices. Signed-off-by: Pankaj Bansal --- Silicon/NXP/Drivers/I2cDxe/I2cDxe.c | 526 +- Silicon/NXP/Drivers/I2cDxe/I2cDxe.h | 44 +-- S

[edk2-devel] [PATCH v2 15/28] Silicon/NXP: Move RAM retrieval from SocLib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal RAM retrieval using SMC commands is common to all Layerscape SOCs. Therefore, move it to commom MemoryInit Pei Lib. Signed-off-by: Pankaj Bansal --- Silicon/NXP/Include/DramInfo.h| 38 - .../Library/MemoryInitPei/MemoryInitPeiLib.c | 137 ++

[edk2-devel] [PATCH v2 03/28] Silicon/NXP/I2cDxe: Fix I2c Timeout with RTC

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal With latest edk2 codebase, sometimes i2c timeout is observed when Network devices are being probed. This is happening when gRT->GetTime request is ongoing. gRT->GetTime triggers a read request to Real Time Clock which is connected to I2c bus. In between read request, if an eve

[edk2-devel] [PATCH v2 09/28] Silicon/NXP: Drop DUartPortLib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal DUartPortLib is for ns16550 compatible UART in LS1043A. Therefore, we can remove it and use BaseSerialPortLib16550. Signed-off-by: Pankaj Bansal --- Silicon/NXP/Library/DUartPortLib/DUart.h | 122 -- .../NXP/Library/DUartPortLib/DUartPortLib.c | 364 -

[edk2-devel] [PATCH v2 01/28] Silicon/NXP: Add I2c lib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal I2c lib is going to be used in PrePeiCore sec module to get the System clock information from devices connected to i2c (like fpga or clock generator) since we don't have support of DXE modules this early in boot stage, move the i2c controller functionality in library. Signed

[edk2-devel] [PATCH v2 08/28] Silicon/NXP/LS1043A: Use BaseSerialPortLib16550 as SerialPortLib

2020-03-19 Thread Pankaj Bansal
From: Pankaj Bansal UART Programming model in LS1043A is compatible with PC16550D. Therefore, BaseSerialPortLib16550 can be used instead of our own implementation of SerialPortLib. Signed-off-by: Pankaj Bansal --- Platform/NXP/NxpQoriqLs.dsc.inc | 3 +++ Silicon/NXP/LS1043A/LS1043A.dsc.inc

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Leif Lindholm
Hi Ray, I agree it would be nice, but if not - this lets us get rid of otherwise needless driver duplication. To me, that makes it worth a little trivial churn. / Leif On Thu, Mar 19, 2020 at 15:09:19 +, Ni, Ray wrote: > It seems this change requires all platforms DSC to include the new

Re: [edk2-devel] [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml

2020-03-19 Thread Bret Barkelew via Groups.Io
Reviewed-by: Bret Barkelew - Bret From: Shenglei Zhang Sent: Thursday, March 19, 2020 2:37:54 AM To: devel@edk2.groups.io Cc: Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Liming Gao Subject: [EXTERNAL] [PATCH] .pytool: Add two keys in cspell.base.yaml I

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Ni, Ray
It seems this change requires all platforms DSC to include the new library class/instance. Is there a way that can avoid the platform impact? Thanks, Ray > -Original Message- > From: Pankaj Bansal > Sent: Wednesday, February 19, 2020 9:32 PM > To: Wang, Jian J ; Wu, Hao A ; Ni, > Ray

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-19 Thread Ni, Ray
I agree with you about that fact😊 These "[1]" was added 6 years ago when "[0]" still caused compilation failure. Later, about 5 years ago, Mike enabled "[0]" with the below change in MdePkg/Include/Base.h: // // Disable warning when last field of data structure is a zero sized array. // #pragma

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: UART Dynamic clock freq Support

2020-03-19 Thread Samer El-Haj-Mahmoud
Any help from maintainers in reviewing this MdeModulePkg patch please? Thanks, --Samer -Original Message- From: devel@edk2.groups.io On Behalf Of Pankaj Bansal via Groups.Io Sent: Wednesday, February 19, 2020 8:32 AM To: Jian J Wang ; Hao A Wu ; Ray Ni ; Maurice Ma ; Guo Dong ; Benjam

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-19 Thread Javeed, Ashraf
All the PCIe capability structures with the PCI_EXPRESS_EXTENDED_CAPABILITIES_HEADER; that has variable length features have been implemented in this way. I am counting around 12 structures which have been defined in the same way. > -Original Message- > From: Ni, Ray > Sent: Thursday,

[edk2-devel] [PATCH] .pytool: Add two keys in cspell.base.yaml

2020-03-19 Thread Zhang, Shenglei
In order to catch as many issues as possible in a single pass (to allow devs to fix test failures in one commit rather than several), recommend increasing the max failure count and max duplicate count in SpellCheck plugin. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2593 Cc: Sean Brogan

Re: [edk2-devel] [PATCH V2] MdePkg-PciExpress40.h: DVSEC definition missing

2020-03-19 Thread Ni, Ray
I am sorry I just noticed this patch. Is it better to have "DesignatedVendorSpecific[0]"? This will make the sizeof (structure) more accurate. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, > Ashraf > Sent: Tuesday, March 17, 2020 4:04 PM > To: devel@edk2.groups.io

Re: [edk2-devel] [edk2/master PATCH RISC-V CI Code Changes v1 11/11] MdeModulePkg: Use LockBoxNullLib for RISC-V

2020-03-19 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Friday, March 6, 2020 1:36 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Leif Lindholm ; Gilbert Chen > ; Bi, Dandan ; Gao, Liming > ; Wang,