[edk2-devel] [PATCH v2 0/2] Use submodule way to access brotli

2020-03-08 Thread Zhang, Shenglei
Currently brotli is used and customized by edk2 in BaseTools and MdeModulePkg. These two patches make brotli a submodule in edk2. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2558 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2559 The patches are too big. So I attach the patch link f

Re: [edk2-devel] Adding Bhyve support into upstream EDK2

2020-03-08 Thread Sean via Groups.Io
Ard/Lazlo, I find your position on OvmfPkg, ArmVirtPkg,and edk2-platforms in edk2 to be detrimental to the overall success of the edk2 project.  The majority of edk2 consumers already have to deal with their platform not being part of the edk2 git repo and the fact that changes to edk2 may not

Re: [edk2-devel] [PATCH V2] BaseTools:GuidedSectionTools.txt is not generated correctly

2020-03-08 Thread Bob Feng
Zhiju, +BaseName, Ext = os.path.splitext(foundPath) +if os.path.isdir(foundPath) or Ext: Did you check the tool behavior under Linux? The file under Linux can have no extension file name. Thanks, Bob -Original Message- From: Fan, ZhijuX Sent: Friday, Ma

Re: [edk2-devel] [PATCH 0/2] Use submodule way to access brotli

2020-03-08 Thread Liming Gao
Shenglei: Module INF should include all used source files in its [Sources] section. So, please also include the wrap header files, such as stddef.h into its [Sources] section. And, please use REF: BZ link url to include BZ in the commit message. Thanks Liming -Original Message- Fr

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 4/6] BaseTools: Enable RISC-V architecture for RISC-V EDK2 CI.

2020-03-08 Thread Abner Chang
This sounds good. Will send update with others. From: sean.brogan via [] [mailto:sean.brogan=microsoft.com@[]] Sent: Sunday, March 8, 2020 6:14 AM To: Chang, Abner (HPS SW/FW Technologist) ; devel@edk2.groups.io Subject: Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 4/6] BaseTools: Enable RIS

Re: [edk2-devel] [edk2/master PATCH RISC-V CI v1 6/6] .pytool: Add RISC-V architecture on RISC-V EDK2 CI.

2020-03-08 Thread Abner Chang
Sean, the RISC-V edk2 port patches against to ek2-stating were reviewed. The submodule one attached FYR. We have three sets of RISC-V edk2 port patches, 1. Patches for RISC-V EDK2 CI enablement (This is what you are reviewing now). 2. Patches for edk2 modules other than RISC-V ones, which fi

Re: [edk2-devel] [edk2-platform][PATCH v2] IntelSiliconPkg: Add periods in comments

2020-03-08 Thread Zhang, Shenglei
Reviewed-By: Shenglei Zhang Thanks, Shenglei > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > GuoMinJ > Sent: Thursday, March 5, 2020 1:47 PM > To: devel@edk2.groups.io > Cc: GuoMinJ > Subject: [edk2-devel] [edk2-platform][PATCH v2] IntelSil

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2020-03-08 Thread Michael D Kinney
I added the @Mergifyio refresh to these PRs. This one was merged: https://github.com/tianocore/edk2/pull/427 This one is failing PatchCheck with a missing Signed-off-by https://github.com/tianocore/edk2/pull/430 This one needs to be rebased and resubmitted https://github.

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2020-03-08 Thread Sean via Groups.Io
Laszlo - Added comment to your PR. @Mike Kinney (michael.d.kin...@intel.com) who has mergify permission? I tried to add comment "@Mergifyio refresh" to the PR but since I don't have "command" permission it was rejected. I am happy to look at mergify a little closer if you give me access. >Fr

Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master

2020-03-08 Thread Laszlo Ersek
On 11/12/19 03:55, Michael D Kinney wrote: > Please let us know if there are any questions about this > change in the development process. What is the recommended way to report issues with the mergify (not CI) infrastructure? Mergify hasn't been picking up ready-to-merge branches (with CI passed

Re: [edk2-devel] [PATCH] OvmfPkg/X86QemuLoadImageLib: fix "unused variable" error in X64 DXE builds

2020-03-08 Thread Laszlo Ersek
On 03/07/20 15:34, Ard Biesheuvel wrote: > On Sat, 7 Mar 2020 at 00:04, Laszlo Ersek wrote: >> >> When the MDE_CPU_IA32 macro is not defined, there is no access to the >> "KernelImageHandle" local variable in QemuStartKernelImage(). This breaks >> the OvmfPkgIa32X64 and OvmfPkgX64 platform builds,

Re: [edk2-devel] [PATCH] OvmfPkg/QemuKernelLoaderFsDxe: drop tentative const object definition

2020-03-08 Thread Laszlo Ersek
On 03/07/20 15:22, Ard Biesheuvel wrote: > On Fri, 6 Mar 2020 at 20:22, Laszlo Ersek wrote: >> >> On 03/06/20 17:40, Ard Biesheuvel wrote: >>> On Fri, 6 Mar 2020 at 17:14, Laszlo Ersek wrote: On 03/06/20 08:38, Ard Biesheuvel wrote: > Bob reports that VS2017 chokes on a tentative de

Re: [edk2-devel] [PATCH] OvmfPkg/QemuKernelLoaderFsDxe: drop tentative const object definition

2020-03-08 Thread Laszlo Ersek
Hi Bob, On 03/08/20 02:22, Feng, Bob C wrote: > Hi Ard, > > With this patch, Ovmf still build failed on windows with VS2017. The error > message like below: > > Building ... > d:\edk2maintain\edk2\MdeModulePkg\Universal\Metronome\Metronome.inf [IA32] > d:\edk2maintain\edk2\OvmfPkg\LinuxInitrdD

Re: [edk2-devel] reg: Host Name Validation with Wild Card Certificate

2020-03-08 Thread Laszlo Ersek
On 03/07/20 23:40, Sean via Groups.Io wrote: > The name of this flag is terrible but if you read the 2.8 spec. > https://uefi.org/sites/default/files/resources/UEFI_Spec_2_8_A_Feb14.pdf > page 1436. > Says: > EFI_TLS_VERIFY_FLAG_NONE means no additional flags set for hostname > validation. Wildcar