On 03/07/20 15:34, Ard Biesheuvel wrote: > On Sat, 7 Mar 2020 at 00:04, Laszlo Ersek <ler...@redhat.com> wrote: >> >> When the MDE_CPU_IA32 macro is not defined, there is no access to the >> "KernelImageHandle" local variable in QemuStartKernelImage(). This breaks >> the OvmfPkgIa32X64 and OvmfPkgX64 platform builds, at least with gcc-8. >> >> Move the local variable to the inner scope, where declaration and usage >> are inseparable. >> >> (Note that such inner-scope declarations are frowned upon in the wider >> edk2 codebase, but we use them liberally in ArmVirtPkg and OvmfPkg anyway, >> because they help us reason about variable lifetime and visibility.) >> >> Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> >> Cc: Jordan Justen <jordan.l.jus...@intel.com> >> Cc: Philippe Mathieu-Daudé <phi...@redhat.com> >> Fixes: 7c47d89003a6f8f7f6f0ce8ca7d3e87c630d14cc >> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2572 >> Signed-off-by: Laszlo Ersek <ler...@redhat.com> > > Reviewed-by: Ard Biesheuvel <ard.biesheu...@linaro.org> > > (in case you still need it)
Thanks. If the workaround for the current github / mergify outage turns out to be "resubmit pending PRs", then I'll likely pick up your R-b too. Seeing how your latest <https://github.com/tianocore/edk2/pull/430> is also stuck, I must wonder what is going on at github. They have not responded to my ticket (592107) and their status page claims "All Systems Operational": https://www.githubstatus.com/ Which is not the case. Mergify have their own status page: https://www.notion.so/Mergify-Status-Page-7803a762235d4ee6bed1f9976d17bd83 and that also claims "Dashboard Operational" and "Engine Operational". I've now sent an email to <supp...@mergify.io> too. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#55663): https://edk2.groups.io/g/devel/message/55663 Mute This Topic: https://groups.io/mt/71785477/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
