Ashraf,
I reviewed the first and second patches.
Can you please check my review comments to your December's patches and make sure
either your new code changes followed the comments, or we continue discuss the
review
comments if you don't agree?
I just found some code changes didn't follow as com
> > + Status = EnumeratePciExpressFeatures (
1. "enumerate" means "visit". But I think this function is not just visiting
the features but also
programming them. So, How about "ProgramPciExpressFeatures"?
(I gave a similar review comment in last time review in Dec.)
2. In mail http
> > + PCI_CAPABILITY_PCIEXP PciExpressCapabilityStructure;
1. To Align with existing field "Pci", how about rename it to
"PciExpressCapability" (no "Structure" suffix)?
2. I see that only GetPciExpressProtocol() in PciPlatformSupport.c is used in
this patch.
All other
Reviewed-by: Star Zeng
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, February 10, 2020 11:53 AM
> To: devel@edk2.groups.io
> Cc: Ma, Maurice ; Desimone, Nathaniel L
> ; Zeng, Star
> Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues
>
> GenCfgOpt.py:
> Issue was:
Reviewed-by: Ray Ni
> -Original Message-
> From: Wu, Hao A
> Sent: Thursday, February 6, 2020 1:24 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A ; Kubacki, Michael A
> ; Kinney, Michael D
> ; Dong, Eric ; Ni, Ray
> ; Laszlo Ersek
>
> Subject: [PATCH v1 1/2] Revert UefiCpuPkg/MpInitLib
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: Friday, February 07, 2020 8:05 AM
> To: devel@edk2.groups.io
> Cc: Philippe Mathieu-Daude ; Yao, Jiewen
> ; Wang, Jian J ; Zhang, Chao B
>
> Subject:
> -Original Message-
> From: Leif Lindholm
> Sent: Saturday, February 8, 2020 11:16 PM
> To: Pankaj Bansal
> Cc: Meenakshi Aggarwal ; Michael D Kinney
> ; Varun Sethi ;
> devel@edk2.groups.io
> Subject: Re: [PATCH 04/19] Silicon/NXP: Remove DuartLib and use
> BaseSerialPortLib16550
>
Hi, all
I'm sorry that I pushed one of my under working patch to edk2-platforms master
incorrectly (the merge commit afb07da). I have reverted this change and sorry
for the inconvenience caused. Thanks.
Best Regards
Siyuan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1706
Issue was: invalid_operation: Invalid operation on
null-like value "Base".
Fixed it by initializing Base to 0 before entering
while loop.
Test:
Compared script output before and after this patch and
the result is identical.
Cc: Maurice Ma
GenCfgOpt.py:
Issue was: invalid_operation: Invalid operation on
null-like value "Base".
Fixed it by initializing Base to 0 before entering
while loop.
SplitFspBin.py:
Issues were:
1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
2. invalid_operation: Invalid operation on
null-like value "roffset".
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1706
Issues were:
1. copy_paste_error: PeOptHdr vs PePlusOptHdr.
2. invalid_operation: Invalid operation on
null-like value "roffset".
3. invalid_operation: Invalid operation on
null-like value "rsize".
Fixed them by initializing roffset and rsi
Hi Rebecca,
The RISC-V code on edk2-staging has the corresponding changes in order to
incorporate with opensbi tag v0.6, however opensbi tag v0.6 is not released yet
(supposed to release in weeks ago). Our changes were made based on opensbi tag
v0.6 though.
Please stay in tune with my email send
Reviewed-by: Ray Ni
> -Original Message-
> From: Javeed, Ashraf
> Sent: Thursday, February 6, 2020 6:38 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Ni, Ray
> Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH] MdePkg/Protocols: Code
> correction - removal of r
On Sat, 8 Feb 2020 at 18:14, Leif Lindholm wrote:
>
> On Fri, Feb 07, 2020 at 18:13:10 +0530, Pankaj Bansal wrote:
> > I2c lib is going to be used in PrePeiCore sec module to get the
> > System clock information from devices connected to i2c (like fpga
> > or clcok generator)
> >
> > since we don'
14 matches
Mail list logo
