> > + PCI_CAPABILITY_PCIEXP PciExpressCapabilityStructure;
1. To Align with existing field "Pci", how about rename it to
"PciExpressCapability" (no "Structure" suffix)?
2. I see that only GetPciExpressProtocol() in PciPlatformSupport.c is used in
this patch.
All other functions in PciFeatureSupport.c andPciPlatformSupport.c are not
used.
It makes the reviewers confused about how those unused functions can be
used.
You should remove these unused functions in this patch and add them in
later patches
when the code logic calls them.
Thanks,
Ray
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#54113): https://edk2.groups.io/g/devel/message/54113
Mute This Topic: https://groups.io/mt/71063360/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
