Reviewed-by: Star Zeng <star.z...@intel.com> > -----Original Message----- > From: Chiu, Chasel <chasel.c...@intel.com> > Sent: Monday, February 10, 2020 11:53 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice <maurice...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Zeng, Star <star.z...@intel.com> > Subject: [PATCH 0/2] IntelFsp2Pkg: Coverity scan flags issues > > GenCfgOpt.py: > Issue was: invalid_operation: Invalid operation on null-like value "Base". > Fixed it by initializing Base to 0 before entering while loop. > > SplitFspBin.py: > Issues were: > 1. copy_paste_error: PeOptHdr vs PePlusOptHdr. > 2. invalid_operation: Invalid operation on null-like value "roffset". > 3. invalid_operation: Invalid operation on null-like value "rsize". > Fixed them by initializing roffset and rsize as PE32 image type and overriding > them when PE32+ header found. > > Cc: Maurice Ma <maurice...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Star Zeng <star.z...@intel.com> > Signed-off-by: Chasel Chiu <chasel.c...@intel.com> > > Chasel Chiu (2): > IntelFsp2Pkg/GenCfgOpt.py: Coverity scan flags issues. > IntelFsp2Pkg/SplitFspBin.py: Coverity scan flags issues. > > IntelFsp2Pkg/Tools/GenCfgOpt.py | 3 ++- > IntelFsp2Pkg/Tools/SplitFspBin.py | 10 +++++----- > 2 files changed, 7 insertions(+), 6 deletions(-) > > -- > 2.13.3.windows.1
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54112): https://edk2.groups.io/g/devel/message/54112 Mute This Topic: https://groups.io/mt/71127614/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
