[edk2-devel] [PATCH] Consume BaseConfigBlockLib from IntelSiliconPkg

2019-11-14 Thread Ethan Tsao
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318 Because ClientSiliconPkg will remove BaseConfig library, change that consuming from IntelSiliconPkg rather than ClientsiliocnPkg. Signed-off-by: Ethan Tsao Cc: Sai Chaganty Cc: Ray Ni --- Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSil

Re: [edk2-devel] [PATCH v1] MdeModulePkg/NvmExpressDxe: Fix wrong queue size for async IO queues

2019-11-14 Thread Ni, Ray
Acked-by: Ray Ni > -Original Message- > From: Wu, Hao A > Sent: Thursday, November 14, 2019 1:02 PM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Wang, Jian J > ; Ni, Ray ; Wu, Hao A > > Subject: [PATCH v1] MdeModulePkg/NvmExpressDxe: Fix wrong queue size > for async IO queues > > Fro

Re: [edk2-devel] [PATCH v1] MdeModulePkg/NvmExpressDxe: Fix wrong queue size for async IO queues

2019-11-14 Thread Wu, Hao A
Hello Ray and Jian, I plan to push this bug fix before the upcoming stable tag, could you help to review this patch? Thanks in advance. Best Regards, Hao Wu > -Original Message- > From: Wu, Hao A > Sent: Thursday, November 14, 2019 1:02 PM > To: devel@edk2.groups.io > Cc: Sean Brogan; W

Re: [edk2-devel] [PATCH V2] BaseTools:Add [packages] section in dsc file

2019-11-14 Thread Liming Gao
Zhiju: Can you show what test are done for this new support? Thanks Liming >-Original Message- >From: Fan, ZhijuX >Sent: Thursday, November 14, 2019 9:28 AM >To: devel@edk2.groups.io >Cc: Gao, Liming ; Feng, Bob C >Subject: [PATCH V2] BaseTools:Add [packages] section in dsc file > >BZ:h

Re: [edk2-devel] [Patch 1/5] BaseTools: Rename tool chain CLANG9 to CLANGPDB

2019-11-14 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Gao, Liming Sent: Thursday, November 14, 2019 4:25 PM To: devel@edk2.groups.io Cc: Feng, Bob C Subject: [Patch 1/5] BaseTools: Rename tool chain CLANG9 to CLANGPDB BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Based on feedback

Re: [edk2-devel] [edk2-platforms][Patch V5 1/2] MinPlatformPkg: Library for customizing TPM platform hierarchy

2019-11-14 Thread Kubacki, Michael A
Please include the version changes in a git note attached to the patch in the future. Thanks, Michael > -Original Message- > From: Chiu, Chasel > Sent: Thursday, November 14, 2019 4:58 PM > To: Gonzalez Del Cueto, Rodrigo ; > devel@edk2.groups.io. > Cc: Kubacki, Michael A ; Desimone, Na

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Thu, 11/14/2019 5:00pm-5:30pm #cal-reminder

2019-11-14 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Thursday, 14 November 2019, 5:00pm to 5:30pm, (GMT-08:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=calendarLink View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=503262 ) *Organizer:* Brian Richardson b

Re: [edk2-devel] [edk2-platforms][Patch V5 2/2] MinPlatformPkg: Tcg2PlatformDxe to use TpmPlatformHierarchyLib

2019-11-14 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: Thursday, November 14, 2019 1:05 PM > To: devel@edk2.groups.io. > Cc: Gonzalez Del Cueto, Rodrigo ; > Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk

Re: [edk2-devel] [edk2-platforms][Patch V5 1/2] MinPlatformPkg: Library for customizing TPM platform hierarchy

2019-11-14 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Gonzalez Del Cueto, Rodrigo > Sent: Thursday, November 14, 2019 1:05 PM > To: devel@edk2.groups.io. > Cc: Gonzalez Del Cueto, Rodrigo ; > Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming > Subject: [edk

Re: [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py

2019-11-14 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Desimone, Ashley E Sent: Thursday, November 14, 2019 2:47 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja Subject: [edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_

Re: [edk2-devel] [edk2-platforms][Patch V5 1/2] MinPlatformPkg: Library for customizing TPM platform hierarchy

2019-11-14 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Gonzalez Del Cueto, Rodrigo Sent: Thursday, November 14, 2019 1:05 PM To: devel@edk2.groups.io. Cc: Gonzalez Del Cueto, Rodrigo ; Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][Pat

Re: [edk2-devel] [edk2-platforms][Patch V5 2/2] MinPlatformPkg: Tcg2PlatformDxe to use TpmPlatformHierarchyLib

2019-11-14 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Gonzalez Del Cueto, Rodrigo Sent: Thursday, November 14, 2019 1:05 PM To: devel@edk2.groups.io. Cc: Gonzalez Del Cueto, Rodrigo ; Kubacki, Michael A ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][Pat

[edk2-devel][edk2-staging/EdkRepo][PATCH] [EdkRepo] Add additional debug information to edkrepo_entry_point.py

2019-11-14 Thread Desimone, Ashley E
Add traceback to the case where the preferred entry point cannot be loaded. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/edkrepo_entry_point.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/edkrepo/edkrepo_entry_point.py b/edkrepo/ed

[edk2-devel] [edk2-platforms][Patch V5 0/2] MinPlatformPkg: Introduce library for customizing TPM platform configuration

2019-11-14 Thread Rodrigo Gonzalez del Cueto
[PATCH 5] Split up TpmPlatformHierarchyLib from Tcg2PlatformDxe modifications [PATCH 1/2] Add new library class TpmPlatformHierarchyLib [PATCH 2/2] Add usage in Tcg2PlatformDxe Rodrigo Gonzalez del Cueto (2): MinPlatformPkg: Library for customizing TPM platform hierarchy MinPlatformPkg: Tc

[edk2-devel] [edk2-platforms][Patch V5 1/2] MinPlatformPkg: Library for customizing TPM platform hierarchy

2019-11-14 Thread Rodrigo Gonzalez del Cueto
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2331 In V5: + Fixed build of MinPlatformPkg This change is split into two commits: 1) This commit: Add new library class TpmPlatformHierarchyLib 2) Second commit: Add usage in Tcg2PlatformDxe In order to enable some TPM use cases BIOS shou

[edk2-devel] [edk2-platforms][Patch V5 2/2] MinPlatformPkg: Tcg2PlatformDxe to use TpmPlatformHierarchyLib

2019-11-14 Thread Rodrigo Gonzalez del Cueto
This change is split into two commits: 1) First commit: Add new library class TpmPlatformHierarchyLib 2) This commit: Add usage in Tcg2PlatformDxe Tcg2PlatformDxe will now leverage from TpmPlatformHierarchyLib's ConfigureTpmPlatformHierarchy function to configure the TPM's Platform Hierarchy.

[edk2-devel] [edk2-platforms][Patch V4 1/2] MinPlatformPkg: Library for customizing TPM platform hierarchy

2019-11-14 Thread Rodrigo Gonzalez del Cueto
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2331 In V4: + Splitting changes into two patches: 1) Creation on TpmPlatformHierarchyLib 2) Modification to Tcg2PlatformDxe In order to enable some TPM use cases BIOS should enable to customize the configuration of the TPM platform, pro

[edk2-devel] [edk2-platforms][Patch V4 0/2] MinPlatformPkg: Introduce library for customizing TPM platform configuration

2019-11-14 Thread Rodrigo Gonzalez del Cueto
[PATCH 4] Split up TpmPlatformHierarchyLib from Tcg2PlatformDxe modifications [PATCH 1/2] Introduction of TpmPlatformHierarchyLib [PATCH 2/2] Modification on Tcg2PlatformDxe to use TpmPlatformHierarchyLib Rodrigo Gonzalez del Cueto (2): MinPlatformPkg: Library for customizing TPM platform hi

[edk2-devel] [edk2-platforms][Patch V4 2/2] MinPlatformPkg: Tcg2PlatformDxe to use TpmPlatformHierarchyLib

2019-11-14 Thread Rodrigo Gonzalez del Cueto
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2331 Tcg2PlatformDxe will now leverage from TpmPlatformHierarchyLib's ConfigureTpmPlatformHierarchy function to configure the TPM's Platform Hierarchy. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Rodri

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-14 Thread Jeff Brasen
Yes, I think that would be good. Summarizing everything in this thread Problem: Platform needs to customize the boot options, this can be done for normal boot but the UiApp calls EfiBootManagerRefreshAllBootOption in a couple places. Potential solutions: 1 - Define new PCD and event group if P

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-14 Thread Pete Batard
Hi Michael, On 2019.11.14 16:36, Michael Brown wrote: On 14/11/2019 16:07, Pete Batard wrote: +typedef +EFI_STATUS +(EFIAPI *GET_MODEL_FAMILY) ( +  UINT32 *ModelFamily +  ); +   typedef   EFI_STATUS   (EFIAPI *GET_FIRMWARE_REVISION) ( @@ -143,6 +150,7 @@ typedef struct {     GET_MODEL  

Re: [edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-14 Thread Michael Brown
On 14/11/2019 16:07, Pete Batard wrote: +typedef +EFI_STATUS +(EFIAPI *GET_MODEL_FAMILY) ( + UINT32 *ModelFamily + ); + typedef EFI_STATUS (EFIAPI *GET_FIRMWARE_REVISION) ( @@ -143,6 +150,7 @@ typedef struct { GET_MODEL GetModel; GET_MODEL_REVISIONGetModelRevision;

[edk2-devel] Which is the proper edk2 package the EFI REST Structure DXE driver should stay with?

2019-11-14 Thread Abner Chang
Hi all, I would like to get your suggestion with regard to the suitable edk2 package for EFI REST Structure DXE driver. We have POC code for this protocol (refer to UEFI spec 2.8, section 29.7.3) and currently this driver is implemented in RedfishPkg. However, this driver is not for Redfish only

Re: [edk2-devel] [Patch 2/5] MdeModulePkg RegularExpressionDxe: Update tool chain name to CLANGPDB

2019-11-14 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Gao, Liming > Sent: Thursday, November 14, 2019 4:25 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J > Subject: [Patch 2/5] MdeModulePkg RegularExpressionDxe: Update tool chain > name to CLANGPDB > > BZ: https://bu

[edk2-devel] [edk2-platforms][PATCH 4/8] Platform/RPi: Read more variables from VideoCore during early init

2019-11-14 Thread Pete Batard
Besides the base memory size, we can read the GPU/VideoCore base as well as the model during early init, which we'll need for improving the memory mapping. This patch adds the retrieval of these variables, as well as some early debug display of their values (which can be useful) and also removes u

[edk2-devel] [edk2-platforms][PATCH 7/8] Platform/RPi: Replace MMCHS1BASE define with a PCD

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Replace MMCHS1BASE with PcdMmcHs1BaseAddress. This is needed in preparation for adding Raspberry Pi 4 support Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/ArasanMmcHostDxe/ArasanMmcHostDxe.inf | 1 + Platform/RaspberryPi/RPi3/RPi3.dsc

[edk2-devel] [edk2-platforms][PATCH 8/8] Platform/RPi: Replace DW2_USB_BASE_ADDRESS define with a PCD

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Replace DW2_USB_BASE_ADDRESS with PcdDw2UsbBaseAddress. This is needed in preparation for adding Raspberry Pi 4 support. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwUsbHostDxe.inf | 1 + Platform/RaspberryPi/Drivers/DwUsbHostDxe/DwcHw.h

[edk2-devel] [edk2-platforms][PATCH 6/8] Platform/RPi: Replace Mailbox and Watchdog addresses with PCDs

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Set BCM2836_WDOG_BASE_ADDRESS and BCM2836_MBOX_BASE_ADDRESS to using PCDs instead of hard-coded addresses. This is needed in preparation for adding Raspberry Pi 4 support. Signed-off-by: Pete Batard --- Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.inf |

[edk2-devel] [edk2-platforms][PATCH 5/8] Platform/RPi: Clean up and improve early memory init

2019-11-14 Thread Pete Batard
This patch improves memory initialization for the Raspberry Pi Platform by: Using VideoCore mailbox data to reserve only the regions that are actually mapped. Especially, besides the base RAM size, which was already set using VideoCore data, we can set the GPU/VideoCore base address as well as the

[edk2-devel] [edk2-platforms][PATCH 3/8] Silicon/Broadcom: Add Bcm2711 header

2019-11-14 Thread Pete Batard
Bcm2711 is the SoC used by the Raspberry Pi 4. For the most part it is backward compatible with the Bcm283x SoC used by older models but some new Bcm2711 registers have been introduced such as the ones for PCIe. We therefore introduce a new Bcm27xx module, which contains only the base address for

[edk2-devel] [edk2-platforms][PATCH 1/8] Platform/RPi: Add model family detection

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Add GetModelFamily to RASPBERRY_PI_FIRMWARE_PROTOCOL. This uses the board revision to return a numeric value representing the RPi family (1=RPi, 2=RPi2, 3=RPi3 and 4=RPi4). Knowing the Pi family will help us set the SD card routing when we introduce support for the Pi

[edk2-devel] [edk2-platforms][PATCH 2/8] Platform/RPi: Replace Bcm283x SoC base register address with a PCD

2019-11-14 Thread Pete Batard
From: Samer El-Haj-Mahmoud Define BCM2836_SOC_REGISTERS from PcdBcm283xRegistersAddress. This is needed in preparation for adding Raspberry Pi 4 support, since the two Pi's have a different base addresses for the Bcm283x specific registers. Signed-off-by: Pete Batard --- Platform/RaspberryPi/D

[edk2-devel] [edk2-platforms][PATCH 0/8] Platform/RPi: Early Raspberry Pi 4 groundwork

2019-11-14 Thread Pete Batard
The following set of patches lay some of the groundwork needed for the addition of the Raspberry Pi 4 as a platform. They are mostly designed at making the common RPi code more generic, by introducing new PCDs for the elements that are going to vary between Pi models, as well as introducing early

Re: [edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported

2019-11-14 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Zhang, Shenglei > Sent: Thursday, November 14, 2019 7:47 PM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Kinney, Michael D > ; Gao, Liming > Subject: [PATCH] MdePkg: Update the comments of IsLanguageSupported > > From: Shengle

Re: [edk2-devel] [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change MODULE_TYPE of SiliconInitLib to PEIM

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 01/13] KabylakeSiliconPkg: Change

Re: [edk2-devel] [edk2-platforms] [PATCH V1 13/13] MinPlatformPkg: Remove BoardInitLib dependency from PlatformSecLib

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Gao, Liming > Subject: [edk2-platforms] [PATCH V1 13/13] MinPlatformPkg: Remove > BoardInitLib

Re: [edk2-devel] [edk2-platforms] [PATCH V1 12/13] KabylakeOpenBoardPkg: Remove SecFspWrapperPlatformSecLib override

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Jeremy Soller > Subject: [edk2-platforms] [PATCH V1 12/13] KabylakeOpenBoardPkg: Remove > SecF

Re: [edk2-devel] [edk2-platforms] [PATCH V1 11/13] KabylakeOpenBoardPkg: Add support for PcdFspDispatchModeUseFspPeiMain

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V1 11/13] KabylakeOpenBoardPkg: Add > support for PcdFspDispa

Re: [edk2-devel] [edk2-platforms] [PATCH V1 10/13] MinPlatformPkg: Coding style cleanups in MinPlatformPkg.dec

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Gao, Liming > Subject: [edk2-platforms] [PATCH V1 10/13] MinPlatformPkg: Coding style > cleanu

Re: [edk2-devel] [edk2-platforms] [PATCH V1 09/13] MinPlatformPkg: FSP Dispatch Mode Support for PlatformSecLib

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Gao, Liming > Subject: [edk2-platforms] [PATCH V1 09/13] MinPlatformPkg: FSP Dispatch > Mode

Re: [edk2-devel] [edk2-platforms] [PATCH V1 08/13] WhiskeylakeOpenBoardPkg: Remove SecFspWrapperPlatformSecLib override

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V1 08/13] WhiskeylakeOpenBoardPkg: > Remove SecFspWrapperPlat

Re: [edk2-devel] [edk2-platforms] [PATCH V1 07/13] WhiskeylakeOpenBoardPkg: Whitespace cleanup in BoardInitLib

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V1 07/13] WhiskeylakeOpenBoardPkg: > Whitespace cleanup in Bo

Re: [edk2-devel] [edk2-platforms] [PATCH V1 05/13] CoffeelakeSiliconPkg: Add SiliconInitLib

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 05/13] CoffeelakeSiliconPkg: Add

Re: [edk2-devel] [edk2-platforms] [PATCH V1 06/13] WhiskeylakeOpenBoardPkg: Add SiliconInitLib APIs to BoardInitLib

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH V1 06/13] WhiskeylakeOpenBoardPkg: Add > SiliconInitLib APIs t

Re: [edk2-devel] [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move TcoWdtHob.h

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move

Re: [edk2-devel] [edk2-platforms] [PATCH V1 03/13] KabylakeSiliconPkg: Cleanup old comments

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V1 03/13] KabylakeSiliconPkg: Cleanu

Re: [edk2-devel] [edk2-platforms] [PATCH V1 02/13] KabylakeOpenBoardPkg: Update location of SiliconInitLib

2019-11-14 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Desimone, Nathaniel L > Sent: Thursday, November 14, 2019 2:07 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Jeremy Soller > Subject: [edk2-platforms] [PATCH V1 02/13] KabylakeOpenBoardPkg: Update > loca

Re: [edk2-devel] [PATCH 08/11] OvmfPkg: specify RngLib instances in dsc files

2019-11-14 Thread Wang, Jian J
Laszlo, That makes sense for virtual platforms. Thanks for the explanation. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, November 14, 2019 10:51 PM > To: Wang, Jian J ; devel@edk2.groups.io; Ard > Biesheuvel > Cc: Justen, J

Re: [edk2-devel] [PATCH 06/11] SecurityPkg/DxeRngLibRngProtocol: add RNG protocol version of RngLib

2019-11-14 Thread Wang, Jian J
Laszlo, > -Original Message- > From: Laszlo Ersek > Sent: Thursday, November 14, 2019 7:16 PM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Yao, Jiewen ; Zhang, Chao B > ; Ard Biesheuvel ; > Matthew Carlson ; Sean Brogan > ; Bret Barkelew > ; Gao, Liming ; Ni, Ray > > Subject: Re: [ed

Re: [edk2-devel] [PATCH 08/11] OvmfPkg: specify RngLib instances in dsc files

2019-11-14 Thread Laszlo Ersek
On 11/14/19 15:40, Wang, Jian J wrote: > I'm curious that you want to do the "degrade" dynamically at boot time not > build time, right? Indeed, that's the whole point. When running on QEMU (considering all of arm/aarch64/i386/x86_64), the firmware can assume quite little of the underlying platfo

Re: [edk2-devel] [Patch 0/5] Rename tool chain name CLANG9 to CLANGPDB

2019-11-14 Thread Leif Lindholm
On Thu, Nov 14, 2019 at 04:24:35PM +0800, Liming Gao wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 > > Based on feedback from https://edk2.groups.io/g/devel/message/50466, > CLANGPDB is the most acceptable tool chain name. Wiki will be updated. > > This patch set only changes t

Re: [edk2-devel] [PATCH 08/11] OvmfPkg: specify RngLib instances in dsc files

2019-11-14 Thread Wang, Jian J
Laszlo, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, November 14, 2019 7:08 PM > To: Wang, Jian J ; Ard Biesheuvel > > Cc: devel@edk2.groups.io; Justen, Jordan L ; Gao, > Liming ; Ni, Ray > Subject: Re: [edk2-devel] [PATCH 08/11] OvmfPkg

Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files

2019-11-14 Thread Wang, Jian J
Laszlo, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Thursday, November 14, 2019 6:37 PM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Leif Lindholm ; Ard Biesheuvel > > Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify

Re: [edk2-devel] csm on edk2-platform

2019-11-14 Thread Laszlo Ersek
Hi David, could you please look into this briefly? Tommaso: please provide David with a more complete description of the symptom that you see. Can you tell what line exactly in edk2 triggers the problem? Thanks Laszlo On 11/06/19 17:17, Tommaso Mazzoni wrote: > Dear all, > > Dear David Woodhou

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, 15 November 2019 #cal-cancelled

2019-11-14 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCEL CALSCALE:GREGORIAN BEGIN:VEVENT STATUS:CANCELLED UID:calendar.14...@groups.io DTSTAMP:20191114T123421Z ORGANIZER;CN=Ray Ni:mailto:ray...@intel.com DTSTART:20191115T013000Z DTEND:20191115T023000Z SUMMARY:TianoC

Re: [edk2-devel] [PATCH 0/3] Add missing strings for uni files

2019-11-14 Thread Laszlo Ersek
On 11/14/19 12:46, Zhang, Shenglei wrote: > From: Shenglei Zhang > > There are missing strings in MdeModulePkg.uni, NetworkPkg.uni > and UefiCpuPkg.uni. So add them into uni files. > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Jiaxin Wu > Cc: Siyuan Fu > Cc: Maciej Rabeda > Cc: Eric Dong > Cc:

[edk2-devel] [PATCH] MdePkg: Update the comments of IsLanguageSupported

2019-11-14 Thread Zhang, Shenglei
From: Shenglei Zhang Keep the comment style of IsLanguageSupported align with other functions. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdePkg/Library/UefiLib/UefiLib.c | 18 +- MdePkg/Include/Library/UefiLib.h | 19 ++- 2 files ch

[edk2-devel] [PATCH 2/3] NetworkPkg/NetworkPkg.uni: Add missing strings for PCD

2019-11-14 Thread Zhang, Shenglei
From: Shenglei Zhang Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Signed-off-by: Shenglei Zhang --- NetworkPkg/NetworkPkg.uni | 7 +++ 1 file changed, 7 insertions(+) diff --git a/NetworkPkg/NetworkPkg.uni b/NetworkPkg/NetworkPkg.uni index 19e57a4a60de..328d8cb54a6e 100644 --- a/Networ

[edk2-devel] [PATCH 3/3] UefiCpuPkg/UefiCpuPkg.uni: Add missing strings for PCD

2019-11-14 Thread Zhang, Shenglei
From: Shenglei Zhang Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- UefiCpuPkg/UefiCpuPkg.uni | 16 1 file changed, 16 insertions(+) diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index a7e279c5cb14..bfd696f48c35 100644 --- a

[edk2-devel] [PATCH 1/3] MdeModulePkg/MdeModulePkg.uni: Add missing strings for PCD

2019-11-14 Thread Zhang, Shenglei
From: Shenglei Zhang Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.uni | 12 1 file changed, 12 insertions(+) diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni index a2c7a7ded3e8..d9c7b1ac6cf0 100644 --- a/MdeMo

[edk2-devel] [PATCH] UefiCpuPkg: Update the coding styles

2019-11-14 Thread Zhang, Shenglei
From: Shenglei Zhang In MpLib.c, remove the white space on a new line. In PageTbl.c and PiSmmCpuDxeSmm.h, update the comment style. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang --- UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 +- UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/P

[edk2-devel] [PATCH 0/3] Add missing strings for uni files

2019-11-14 Thread Zhang, Shenglei
From: Shenglei Zhang There are missing strings in MdeModulePkg.uni, NetworkPkg.uni and UefiCpuPkg.uni. So add them into uni files. Cc: Jian J Wang Cc: Hao A Wu Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Maciej Rabeda Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Shenglei Zhang (3): MdeModulePkg/MdeMo

Re: [edk2-devel] [PATCH 06/11] SecurityPkg/DxeRngLibRngProtocol: add RNG protocol version of RngLib

2019-11-14 Thread Laszlo Ersek
On 11/14/19 03:17, Wang, Jian J wrote: > From: Matthew Carlson > > This version of RngLib makes use of EFI_RNG_PROTOCOL to provide random > number. According to UEFI spec, EFI_RNG_PROTOCOL should meet NIST SP > 800-90 and/or ANSI X9.31 standards. I'd like to slightly correct the UEFI spec refere

Re: [edk2-devel] [PATCH 08/11] OvmfPkg: specify RngLib instances in dsc files

2019-11-14 Thread Laszlo Ersek
Jian, Ard, commenting for both OvmfPkg and ArmVirtPkg: On 11/14/19 03:17, Wang, Jian J wrote: > Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. > Update OVMF dsc files to accommodate the coming changes. It's supposed > that only TlsDxe needs random number. The DxeRngLibRngProtoc

Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files

2019-11-14 Thread Laszlo Ersek
On 11/14/19 03:17, Wang, Jian J wrote: > Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Update > ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed > that only TlsDxe needs random number. The RngDxeLib is added for it. For > all other drivers, RngLibNull is use

Re: [edk2-devel] [Patch 4/5] OvmfPkg DSC: Update tool chain name to CLANGPDB

2019-11-14 Thread Laszlo Ersek
On 11/14/19 09:24, Liming Gao wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 > > Signed-off-by: Liming Gao > Cc: Laszlo Ersek > --- > OvmfPkg/OvmfPkgIa32.dsc| 6 +++--- > OvmfPkg/OvmfPkgIa32X64.dsc | 6 +++--- > OvmfPkg/OvmfPkgX64.dsc | 6 +++--- > 3 files changed, 9 i

Re: [edk2-devel] [Patch 3/5] CryptoPkg CryptoLib: Update tool chain name to CLANGPDB

2019-11-14 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Thursday, November 14, 2019 4:25 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J > Subject: [edk2-devel] [Patch 3/5] CryptoPkg CryptoLib: Update tool chain name >

Re: [edk2-devel] [Patch 5/5] EmulatorPkg DSC and WinHost.inf: Update tool chain name to CLANGPDB

2019-11-14 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Gao, Liming > Sent: Thursday, November 14, 2019 4:25 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Andrew Fish > Subject: [Patch 5/5] EmulatorPkg DSC and WinHost.inf: Update tool chain > name to CLANGPDB > > BZ: https://bugzilla.tianocor

Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files

2019-11-14 Thread Wang, Jian J
Ard, > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, November 14, 2019 4:14 PM > To: edk2-devel-groups-io ; Wang, Jian J > > Cc: Leif Lindholm ; Laszlo Ersek > Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify > RngLib instances in dsc files > >

[edk2-devel] [Patch 4/5] OvmfPkg DSC: Update tool chain name to CLANGPDB

2019-11-14 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Signed-off-by: Liming Gao Cc: Laszlo Ersek --- OvmfPkg/OvmfPkgIa32.dsc| 6 +++--- OvmfPkg/OvmfPkgIa32X64.dsc | 6 +++--- OvmfPkg/OvmfPkgX64.dsc | 6 +++--- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/OvmfPkg/Ovmf

[edk2-devel] [Patch 2/5] MdeModulePkg RegularExpressionDxe: Update tool chain name to CLANGPDB

2019-11-14 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Signed-off-by: Liming Gao Cc: Jian J Wang --- MdeModulePkg/Universal/RegularExpressionDxe/RegularExpressionDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Universal/RegularExpressionDxe/RegularExpr

[edk2-devel] [Patch 1/5] BaseTools: Rename tool chain CLANG9 to CLANGPDB

2019-11-14 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Based on feedback from https://edk2.groups.io/g/devel/message/50466, CLANGPDB is the most acceptable tool chain name, because this tool chain generates PE/COFF image with PDB debug symbol. The following changes are made in this patch. 1. Upda

[edk2-devel] [Patch 3/5] CryptoPkg CryptoLib: Update tool chain name to CLANGPDB

2019-11-14 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Signed-off-by: Liming Gao Cc: Jian J Wang --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 2 +- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 +- CryptoPkg/Librar

[edk2-devel] [Patch 5/5] EmulatorPkg DSC and WinHost.inf: Update tool chain name to CLANGPDB

2019-11-14 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Signed-off-by: Liming Gao Cc: Ray Ni Cc: Andrew Fish --- EmulatorPkg/EmulatorPkg.dsc | 12 ++-- EmulatorPkg/Win/Host/WinHost.inf | 8 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/EmulatorPkg/Emul

[edk2-devel] [Patch 0/5] Rename tool chain name CLANG9 to CLANGPDB

2019-11-14 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2341 Based on feedback from https://edk2.groups.io/g/devel/message/50466, CLANGPDB is the most acceptable tool chain name. Wiki will be updated. This patch set only changes the tool chain name. There is no code logic change. OvmfIa32X64 and Emul

Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files

2019-11-14 Thread Ard Biesheuvel
On Thu, 14 Nov 2019 at 08:03, Wang, Jian J wrote: > > Ard, > > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Thursday, November 14, 2019 3:41 PM > > To: edk2-devel-groups-io ; Wang, Jian J > > > > Cc: Leif Lindholm ; Laszlo Ersek > > > > Subject: Re: [edk2-devel] [PATCH 09/

Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify RngLib instances in dsc files

2019-11-14 Thread Wang, Jian J
Ard, > -Original Message- > From: Ard Biesheuvel > Sent: Thursday, November 14, 2019 3:41 PM > To: edk2-devel-groups-io ; Wang, Jian J > > Cc: Leif Lindholm ; Laszlo Ersek > Subject: Re: [edk2-devel] [PATCH 09/11] ArmVirtPkg/ArmVirt.dsc.inc: specify > RngLib instances in dsc files > >