On 14/11/2019 16:07, Pete Batard wrote:
+typedef
+EFI_STATUS
+(EFIAPI *GET_MODEL_FAMILY) (
+  UINT32 *ModelFamily
+  );
+
  typedef
  EFI_STATUS
  (EFIAPI *GET_FIRMWARE_REVISION) (
@@ -143,6 +150,7 @@ typedef struct {
    GET_MODEL             GetModel;
    GET_MODEL_REVISION    GetModelRevision;
    GET_MODEL_NAME        GetModelName;
+  GET_MODEL_FAMILY      GetModelFamily;
    GET_FIRMWARE_REVISION GetFirmwareRevision;
    GET_MANUFACTURER_NAME GetManufacturerName;
    GET_CPU_NAME          GetCpuName;

Is the RASPBERRY_PI_FIRMWARE_PROTOCOL structure expected to be externally consumed at any point? If so, then adding a field in the middle of the structure without changing the associated GUID would break the ABI.

It's great to see the Pi 4 heading towards having UEFI support; I'm looking forward to trying it out as soon as it's ready.

Thanks,

Michael

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#50700): https://edk2.groups.io/g/devel/message/50700
Mute This Topic: https://groups.io/mt/57792459/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to