On 11/14/19 03:17, Wang, Jian J wrote: > Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Update > ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed > that only TlsDxe needs random number. The RngDxeLib is added for it. For > all other drivers, RngLibNull is used by default. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871 > Cc: Leif Lindholm <leif.lindh...@linaro.org> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@linaro.org> > Signed-off-by: Jian J Wang <jian.j.w...@intel.com> > --- > ArmVirtPkg/ArmVirt.dsc.inc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 10037c938e..10e0890699 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -156,8 +156,10 @@ > IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > !if $(NETWORK_TLS_ENABLE) == TRUE > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf > + > RngLib|SecurityPkg/RandomNumberGenerator/DxeRngLibRngProtocol/DxeRngLibRngProtocol.inf > !else > OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf > + RngLib|MdePkg/Library/BaseRngLibNull/BaseRngLibNull.inf > !endif > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf > >
(1) This is not right: the non-Null lib instance should be linked into TlsDxe only, like in the OvmfPkg patch. Please locate TlsAuthConfigDxe in both "ArmVirtQemu.dsc" and "ArmVirtQemuKernel.dsc", and implement the same approach as in OvmfPkg near "TlsAuthConfigDxe". (2) See other comments in my OvmfPkg patch review. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#50657): https://edk2.groups.io/g/devel/message/50657 Mute This Topic: https://groups.io/mt/56714162/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
