On Thu, 14 Nov 2019 at 02:18, Jian J Wang wrote:
>
> Per BZ1871, OpensslLib should use RngLib to get high quality of random
> entropy. This patch remove all code depending on TimerLib for this job,
> and add RngLib interface to implement the rand interface required by
> openssl.
>
> Ref: https://b
On Thu, 14 Nov 2019 at 02:18, Wang, Jian J wrote:
>
> Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Update
> ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed
> that only TlsDxe needs random number. The RngDxeLib is added for it. For
> all other drivers, Rng
Kilian,
Thank you very much. Comments below.
From: Kilian Kegel
Sent: Thursday, November 14, 2019 1:24 PM
To: Ni, Ray ; devel@edk2.groups.io; Gao, Liming
Cc: Richardson, Brian ; Kinney, Michael D
Subject: RE: [edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint
I have no preference at
SecFspWrapperPlatformSecLib contains the implementation of
SecPlatformDisableTemporaryMemory(), which SecMain in UefiCpuPkg will
call as part of its implementation of EFI_PEI_TEMPORARY_RAM_DONE_PPI.
For platforms that use FSP, the implementation of
SecPlatformDisableTemporaryMemory() can be made ge
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Liming Gao
Signed-off-by: Nate DeSimone
---
.../FspWrapperPlatformSecLib.c| 34 ---
.../SecFspWrapperPlatformSecLib.inf | 7 +++-
.../SecTempRamDone.c | 42 +++
.../Intel/Min
If PcdFspDispatchModeUseFspPeiMain is FALSE, then the BoardPkg
should include PeiMain in FvPreMemory.
Cc: Chasel Chiu
Cc: Michael Kubacki
Signed-off-by: Nate DeSimone
---
.../KabylakeRvp3/OpenBoardPkg.fdf | 5 +++--
.../KabylakeRvp3/OpenBoardPkgPcd.dsc | 20 ++
Cc: Chasel Chiu
Cc: Michael Kubacki
Signed-off-by: Nate DeSimone
---
.../FspWrapperPlatformSecLib.c| 163
.../SecFspWrapperPlatformSecLib/FsptCoreUpd.h | 40 --
.../SecFspWrapperPlatformSecLib/Ia32/Fsp.h| 43 ---
.../Ia32/PeiCoreEntry.nasm| 130
Cc: Michael Kubacki
Cc: Chasel Chiu
Cc: Liming Gao
Signed-off-by: Nate DeSimone
---
.../Intel/MinPlatformPkg/MinPlatformPkg.dec | 281 +-
1 file changed, 139 insertions(+), 142 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec
b/Platform/Intel/MinPl
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Jeremy Soller
Signed-off-by: Nate DeSimone
---
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 2 +-
.../Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc| 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/
This library contains PEI phase only code. For example,
ClearIchSmiAndWake() calls PeiServicesGetBootMode().
Accordingly, this library should have never been marked as
a BASE library.
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Sai Chaganty
Signed-off-by: Nate DeSimone
---
.../PeiSiliconInitLib.i
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Jeremy Soller
Signed-off-by: Nate DeSimone
---
.../FspWrapperPlatformSecLib.c| 186 -
.../SecFspWrapperPlatformSecLib/FsptCoreUpd.h | 40 --
.../SecFspWrapperPlatformSecLib/Ia32/Fsp.h| 42 --
.../Ia32/PeiCoreEntry.nasm
This patch series cleans up two outstanding problems with
SecFspWrapperPlatformSecLib:
1. There are several copies of SecFspWrapperPlatformSecLib
thoughout the codebase, this patch series consolidates
the various implementations down to a single implementation
contained in MinPlat
Cc: Chasel Chiu
Cc: Michael Kubacki
Signed-off-by: Nate DeSimone
---
.../PeiWhiskeylakeURvpInitPostMemLib.c| 185 ++---
.../PeiWhiskeylakeURvpInitPreMemLib.c | 257 +-
2 files changed, 216 insertions(+), 226 deletions(-)
diff --git
a/Platform/Intel/Whis
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Sai Chaganty
Signed-off-by: Nate DeSimone
---
.../Library/PeiSiliconInitLib/SiliconInitPreMem.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
a/Silicon/Intel/KabylakeSiliconPkg/Library/PeiSiliconInitLib/SiliconInitPreM
Moves TcoWdtHob.h from WhiskeylakeOpenBoardPkg to CoffeelakeSiliconPkg.
Oddly, gTcoWdtHobGuid was defined in CoffeelakeSiliconPkg/SiPkg.dec
while the HOB definition itself was in WhiskeylakeOpenBoardPkg,
this change cleans up the disparity.
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Sai Chaganty
S
Cc: Chasel Chiu
Cc: Michael Kubacki
Signed-off-by: Nate DeSimone
---
.../BoardInitLib/PeiBoardInitPostMemLib.inf | 1 +
.../BoardInitLib/PeiBoardInitPreMemLib.inf| 1 +
.../PeiMultiBoardInitPostMemLib.inf | 1 +
.../PeiMultiBoardInitPreMemLib.inf| 2 +-
.../PeiWh
SiliconInitLib contains Silicon Init APIs that can be reused
by BoardInitLib. It is expected that several implementations
of BoardInitLib exist for a given SOC, these APIs allow the
various BoardInitLib implementations to reuse common silicon
initialization code. This matches the implementation alr
Hi Ray,
[Ray] 1. Can you remove “if(1)”?:
DONE
Please define it in the begin of the function, and use edk2 data type and
coding style, such as UINTN Index.
DONE
[Ray] 2. strncmp assumes user may input “/debugx”. Is that a valid
assumption? I thought we only accept “/debug” th
Hi Mike,
Here're some suggestions:
- If OpensslLib library is used, RngLib instance must be specified along
with it.
- For package dsc, BaseLibRngNull can be used because their main
purpose is just for build.
- For platforms which don't need random number at all, BaseLibRngNull
i
From: Sean Brogan
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2118
When a packet is queued/completed for the asynchronous IO queue, the logic
to roll over to the front of the queue doesn't account for actual size of
the IO Submission/Completion queue.
This causes a device to hang due to
Mike,
Thanks for finding it. I'll update the code in v2.
Regards,
Jian
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, November 14, 2019 12:17 PM
> To: devel@edk2.groups.io; Wang, Jian J ; Kinney,
> Michael D
> Cc: Gao, Liming ; Ni, Ray
> Subject: RE: [edk2-devel] [PA
Mike,
I figured that rdseed is only needed in cases demanding highest entropy,
like seeding other pseudo-RNG. It's not for general purpose randomness.
Then I put it in SecurityPkg. But I'm ok to put it into MdePkg. I have no
strong opinion for this.
Regards,
Jian
> -Original Message-
> F
Jian,
Why is this lib instance in the SecurityPkg? It only depends
on the MdePkg. Can't non security feature related modules
that want to a random number use this lib without using the
SecurityPkg? Could this lib instance be added to MdePkg?
Thanks,
Mike
> -Original Message-
> From:
Jian,
In this patch series I see mixed use of different RngLib instances.
How does a platform developer working on their DSC file know if the
BaseCryptLib services they are using require a Null or a complete
implementation of the RngLib? How does a platform developer know
if they made the wrong
Jian,
According to the NASM docuimentation, the rdseed instruction
has been supported since 2.10.02.
https://www.nasm.us/xdoc/2.10.09/html/nasmdocc.html
Please use rdseed instead of db bytes.
Thanks,
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Wang, Jian J
>
This patch looks good.
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Thursday, November 14, 2019 9:28 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH V2] BaseTools:Add [packages] section in dsc file
BZ:https://bugzilla.tianocore.org/show_bu
The patches can also be found at in my fork in github
https://github.com/jwang36/edk2/tree/fix-bz1871-use-proper-entropy-sources-v1
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang, Jian
> J
> Sent: Thursday, November 14, 2019 10:18 AM
> To: devel@edk2.g
BaseRngLib uses rdrand instruction to get random number from DRNG in the
processor, which is not a good candidate for seeding openssl rand
interface.
rdseed in x86 cpu provides non-deterministic random number (NRBG) which
meets NIST SP 800-90B and NIST SP800-90C standards and can be used as
seed f
Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib.
RngLibNull is used by default.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Jiaxin Wu
Cc: Siyuan Fu
Cc: Maciej Rabeda
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Jian J Wang
---
NetworkPkg/NetworkPkg.dsc | 1 +
1
From: Matthew Carlson
This version of RngLib makes use of EFI_RNG_PROTOCOL to provide random
number. According to UEFI spec, EFI_RNG_PROTOCOL should meet NIST SP
800-90 and/or ANSI X9.31 standards.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Laszl
Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib.
RngLibNull is used by default. TimerLib will be removed once its
dependency is removed.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Jian J
Per BZ1871, OpensslLib should use RngLib to get high quality of random
entropy. This patch remove all code depending on TimerLib for this job,
and add RngLib interface to implement the rand interface required by
openssl.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Xiaoyu Lu
Cc: L
Add new libraries DxeRngLibRngProtocol and RngLibRdSeed into
SecurityPkg.dsc.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Jiewen Yao
Cc: Chao Zhang
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Jian J Wang
---
SecurityPkg/SecurityPkg.dsc | 6 ++
1 file changed, 6 insertions(+
TimerLib instance was added for openssl1.1.1b upgrade due to rand
interface implementation based on TimerLib. Since RngLib is now
used instead, TimerLib is not needed any more.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib.
Update OVMF dsc files to accommodate the coming changes. It's supposed
that only TlsDxe needs random number. The DxeRngLibRngProtocol is added
for it. For all other drivers, BaseRngLibNull is used by default.
Ref: https://bugzilla.t
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Patch series summary:
- Add BaseRngLibNull to package dsc
- Add DxeRngLibRngProtocol to make use EFI_RNG_PROTOCOL
- Add RdSeed interface and RngLibRdSeed for IA32/X64 arch
- Remove following files
rand_pool_noise.h
rand_pool_nois
Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib.
RngLibNull is used by default just for build.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Signed-off-by: Jian J Wang
---
SignedCapsulePkg/SignedCapsule
This version of RngLib makes use of AsmRdSeed to get non-deterministic
random number, which can be used for seeding other software DRNG like
rand interface in openssl. It can be used only on IA32/X64 processors
which supports rdseed instruction.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=
Per BZ1871, OpensslLib will depend on RngLib instead of TimerLib. Update
ArmVirt.dsc.inc file to accommodate the coming changes. It's supposed
that only TlsDxe needs random number. The RngDxeLib is added for it. For
all other drivers, RngLibNull is used by default.
Ref: https://bugzilla.tianocore.
It's pushed at c9af866cdd6214d65c1539e7008f6a7255316c80
Regards,
Jian
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, November 14, 2019 2:48 AM
> To: devel@edk2.groups.io; leif.lindh...@linaro.org; Wang, Jian J
> ; Kinney, Michael D
> Cc: Steele, Kelly ; Bi, Dandan ;
>
Jeff,
I think it's a good topic that we could discuss in the open design meeting.
Are you ok to present the problem you have and discuss the potential solutions
in that meeting?
https://github.com/tianocore/tianocore.github.io/wiki/Design-Meeting
Thanks,
Ray
From: devel@edk2.groups.io On Behalf
Reviewed-by: Sai Chaganty
-Original Message-
From: Kubacki, Michael A
Sent: Tuesday, November 12, 2019 7:27 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Gao, Liming
Subject: [edk2-platforms][PATCH V1 01/49] AdvancedFeaturePkg: Package DSC style
cleanup
This change refactors
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2270
Currently a PCD (e.g. FeaturePCD) cannot be used in a conditional
statement in a DSC/FDF file without a module in the build referencing
the PCD package DEC file.
An example implementation that to support this is to allow a [Packages]
section
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhiguang Liu
>Sent: Tuesday, November 12, 2019 4:48 PM
>To: devel@edk2.groups.io
>Cc: Wang, Jian J ; Wu, Hao A
>Subject: [edk2-devel] [PATCH] MdeModulePkg: Unify the defini
Reviewed-by: Nate DeSimone
On 11/13/19, 3:10 PM, "Desimone, Ashley E" wrote:
pip does not support '_' in package names and converts them to
'-' after installing the wheel. In order to uninstall affected
packages the '_' needs to be converted to a '-' when calculating
the packag
pip does not support '_' in package names and converts them to
'-' after installing the wheel. In order to uninstall affected
packages the '_' needs to be converted to a '-' when calculating
the package name.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
---
edkrepo_instal
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2331
In V3:
+ Kept callback function and registration in Tcg2PlatformDxe module.
+ Renamed new library with a more precise and descriptive name
TpmPlatformHierarchyLib. Defines an API for configuring the
TPM's Platform Hierachy. The AP
Thanks Mike (and other reviewers).
Pushed as cee28ab1c8da..f7271a06170b.
/
Leif
On Wed, Nov 13, 2019 at 06:42:16PM +, Kinney, Michael D wrote:
> Series
>
> Reviewed-by: Michael D Kinney
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On
> > Behalf Of Leif L
Leif,
If it helps for testing purposes, the PR for edk2 has been run through EDK II
CI.
https://github.com/tianocore/edk2/pull/168
The public branch with the new lib is at:
https://github.com/jwang36/edk2/tree/add-rnglibnull-instance
The lib is added in a single commit:
https://
Thinking about this more I think we could do this with a PCD and a new group
event without having to define any new function interfaces.
We could change UiApp and BootManagerMenuApp (and any others that are relevant)
from
EfiBootManagerRefreshAllBootOption ();
to
if (FeaturePcdGet (PcdEventBa
Series
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Leif Lindholm
> Sent: Wednesday, November 13, 2019 10:00 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Marcin
> Wojtas ; Kinney, Michael D
> ; Wang, Jian J
>
> Subject: [
Hi Jian,
Can MdePkg/Library/BaseRngLibNull/ be pushed to edk2, so that we can
run some build tests?
Best Regards,
Leif
On Wed, Nov 13, 2019 at 02:11:40PM +0800, Jian J Wang wrote:
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1871
>
> It's a prerequisite of removing dependency of Timer
Ard will still be looking after specific platforms and drivers, but he
was mainly added to the "default" maintainers group to offload me until
edk2-platforms got off the ground, so drop him from that target now we
add the GetMaintainers.py.
Cc: Ard Biesheuvel
Cc: Michael D Kinney
Signed-off-by:
This set does a few things:
- Imports the documentation header from edk2/Maintainers.txt
- Reformats some maintainer entries to get rid of ',' characters
in the names.
- Adds F: entries for all sections, and a default fallback section
for those where there is no match.
- Merges the Marvell sect
Many of the original (ARM) platforms, and drivers brought in for them,
had no explicit maintainership defined. Add entries for these, roughly
corresponding to how they have already been handled in the past.
Cc: Ard Biesheuvel
Cc: Michael D Kinney
Signed-off-by: Leif Lindholm
Acked-by: Ard Biesh
Cc: Marcin Wojtas
Signed-off-by: Leif Lindholm
Acked-by: Ard Biesheuvel
Reviewed-by: Marcin Wojtas
Reviewed-by: Philippe Mathieu-Daude
---
Maintainers.txt | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index 17613936c37e..
Synchronize header with edk2/Maintainers.txt and change references
from "EDK II to EDK II Platforms".
Cc: Ard Biesheuvel
Cc: Michael D Kinney
Signed-off-by: Leif Lindholm
Acked-by: Ard Biesheuvel
Reviewed-by: Philippe Mathieu-Daude
---
Maintainers.txt | 40 ---
Convert existing package maintainer/reviewer descriptions
with adding the new path definitions.
Delete the "Platform" and "Silicon" section maintainership
descriptions. The EDK II Platforms maintainers section will
now match that.
Cc: Ard Biesheuvel
Cc: Michael D Kinney
Signed-off-by: Leif Lind
On 11/13/19 17:23, Kinney, Michael D wrote:
> Hi Laszlo,
>
> I am also reviewing a number of the PRs.
>
> If a PR is composed of a single commit, and the commit
> message includes the reference to the Tianocore BZ, then
> the web view of the PR looks good and includes the link
> to the BZ. A cou
Hi Laszlo,
I am also reviewing a number of the PRs.
If a PR is composed of a single commit, and the commit
message includes the reference to the Tianocore BZ, then
the web view of the PR looks good and includes the link
to the BZ. A couple examples:
https://github.com/tianocore/edk2/pull/161
ht
Laszlo,
> -Original Message-
> From: Laszlo Ersek
> Sent: Wednesday, November 13, 2019 5:28 PM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Ard Biesheuvel ; Ni, Ray
>
> Subject: Re: [edk2-devel] [PATCH v2] MdePkg: add null version of RngLib
>
> On
Based on INF Spec, maybe FeatureFlagExpress is a choice.
When present, the feature flag expression determines whether the entry line is
valid.
If the feature flag expression evaluates to FALSE, this entry will be ignored
by the EDK II build tools.
For below example, is MSFT/GCC FeatureFlag ?
[S
On 11/13/19 09:43, Wang, Jian J wrote:
> As requested by Ray, I'd like to mention more usage about this library
> instance.
>
> To be more specific, if following components or functionalities are used in a
> platform, the BaseRngLibNull should *not* be used. Instead, a non-Null version
> of RngLib
Hi again,
(+Ray)
On 11/12/19 03:55, Michael D Kinney wrote:
> EDK II Maintainers,
>
> EDK II CI Phase 1 feature is now active on edk2/master.
>
> Please use a GitHub pull request from a branch in a personal
> fork of the edk2 repository with a 'push' label to request
> a set of patches to be pu
Dear All:
I have a question about INF file written syntax.
Could I use conditional sentence in INF file?
For example:
[Defines]
..
[Sources]
!ifdef ABC
a.c
!else
b.c
!endif
..
Thanks
保密声明：
本邮件含有保密或专有信息，仅供指定收件人使用。严禁对本邮件或其内容做任何未经授权的查阅、使用、复制或转发。
CONFIDENTIAL NOTE:
This email contains c
As requested by Ray, I'd like to mention more usage about this library
instance.
To be more specific, if following components or functionalities are used in a
platform, the BaseRngLibNull should *not* be used. Instead, a non-Null version
of RngLib must be used (like BaseRngLib for IA32/X64, or com
On 11/13/19 00:40, Kubacki, Michael A wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2333
>
> During a SetVariable () invocation, UpdateVariable () is called.
> UpdateVariable () contains logic to determine whether a volatile or
> non-volatile UEFI variable was set so the correspondin
Laszlo,
Thanks for the comments. I agree all of them. Since there's still EBC listed
in SUPPORTED_ARCHITECTURES in dsc file, I don't see any reason not to add
it. But likewise, I'll leave the final decision to package maintainers.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek
On 11/13/19 09:24, Gao, Liming wrote:
> Good catch.
>
> Reviewed-by: Liming Gao
Thanks!
Commit range 037b5adb5890..7ad574e68f9f.
Laszlo
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Tuesday, November 12, 2019 6:01 PM
>> To: edk2-devel-groups-io
>> C
Good catch.
Reviewed-by: Liming Gao
>-Original Message-
>From: Laszlo Ersek [mailto:ler...@redhat.com]
>Sent: Tuesday, November 12, 2019 6:01 PM
>To: edk2-devel-groups-io
>Cc: Gao, Liming
>Subject: [edk2-wiki PATCH 0/3] Release Planning updates for edk2-
>stable201911
>
>This short se
Hi Jian,
thanks for the update. Comments below:
On 11/13/19 06:35, Jian J Wang wrote:
>> v2:
>> - Change the name from RngLibNull to BaseRngLibNull according to Laszlo's
>>comments
>> - Move the module from SecurityPkg to MdePkg according to Laszlo's comments
>> - Update commit message acc
The change is good. Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Wang, Jian J
>Sent: Wednesday, November 13, 2019 1:35 PM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Gao, Liming
>; Laszlo Ersek ; Ard Biesheuvel
sending this manually, to test an update in the RH email system, for the
DMARC issue ("... via groups.io")
thanks for the patience
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50572): https://edk2.groups.io/g/devel/message/50572
Mute
73 matches
Mail list logo
