Sorry for missing check the commit message title's length. The length should be
within 72 chars (less than not equal).
So I advise to change the titile to "ShellPkg/CommandLib: Use first found UC
when PlatformLang not support".
With that addressed, then take my R-B.
Thanks,
Zhichao
> -Origi
> On Nov 4, 2019, at 11:42 PM, Ashish Singhal wrote:
>
> Hi Andrew,
>
> I have a use case where I install Load File protocol on a handle and want to
> expose that as a boot option through platform boot manager driver as I need
> it to have a custom description and custom option data along wit
Hi Andrew,
I have a use case where I install Load File protocol on a handle and want to
expose that as a boot option through platform boot manager driver as I need it
to have a custom description and custom option data along with it. This is the
reason I submitted this patch so that someone can
Ashish,
Just to be clear on your definition of enumerate. In this case it means the
Boot Manager lib that is just one of may implementations a platform could use
to manage its boot options. 3rd party code, or an OS boot loader could try to
boot your handle since by definition of the UEFI spec i
Hello Andrew,
On my platform, I am installing Load File protocol on a handle which I do not
want to be auto enumerated by boot manager. In order to achieve this, I
submitted this match on edk2 side and have installed
gEdkiiSkipBmAutoEnumerateProtocolGuid on the same handle to achieve this on
p
> On Nov 4, 2019, at 9:24 PM, Ashish Singhal wrote:
>
> Hi Ray,
>
> I did not see any example with which one can tell BDS not to enumerate a boot
> option. Can you please point me to an example where a protocol (Block IO,
> Simple FS or Load File) does not get enumerated as a boot option?
>
Then there is no requirement to force ASSERT when the platform Language is
mismatch with the shell language.
Reviewed-by: Zhichao Gao
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, November 5, 2019 11:03 AM
> To: Gao, Zhichao ; Marvin Häuser
> ; devel@edk2.groups.io
> Cc: vit9...@
Hi Jiewen,
This patch has been added to client bios as override since last year and
validated on WHL/CFL/ICL and also CML.
It was asked by RST team because BLOCK IO protocol is unable to be provided on
each physical device when RAID volume created.
Thanks,
Maggie
-Original Message-
Fro
Hi Ray,
I did not see any example with which one can tell BDS not to enumerate a boot
option. Can you please point me to an example where a protocol (Block IO,
Simple FS or Load File) does not get enumerated as a boot option?
Thanks
Ashish
-Original Message-
From: Ni, Ray
Sent: Monda
I am ok to this change.
> -Original Message-
> From: Gao, Zhichao
> Sent: Thursday, October 24, 2019 9:25 AM
> To: Marvin Häuser ; devel@edk2.groups.io
> Cc: vit9...@protonmail.com; Ni, Ray
> Subject: RE: [PATCH] UefiShellCommandLib: Default to first found UC for
> unsupported PlatformLa
Liming,
Thanks for looking into this. It is always good to try and do things the same
way on different tool chains if possible.
Thanks,
Andrew Fish
> On Nov 3, 2019, at 9:40 PM, Liming Gao wrote:
>
> Andrew:
> I did some investigation. Seemly, there is no way to disable VS command
> line
Push at 1bcc65b9a1408cf445b7b3f9499b27d9c235db71
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Wang, Jian
> J
> Sent: Tuesday, November 05, 2019 9:34 AM
> To: Laszlo Ersek ; devel@edk2.groups.io; Zhang, Shenglei
>
> Cc: Lu, XiaoyuX ; Gao, Liming
> Subject
+ Mike
With the UEFI driver model, if a device is not needed by booting, it can skip
the connecting.
Then I do not see a need of the new protocol.
Thanks,
Ray
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, October 31, 2019 6:15 PM
> To: devel@edk2.groups.io; ashishsin...@n
Reviewed-by: Dandan Bi
Thanks,
Dandan
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Friday, November 1, 2019 2:14 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A
> Subject: [edk2-devel] [PATCH v3 4/4]
Acked-by: Zhichao Gao
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, October 30, 2019 3:55 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Zhichao
> Subject: [Patch v3 16/22] ShellPkg: Add YAML file for CI builds
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=2
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray
Sent: Wednesday, October 30, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek
Subject: [edk2-devel] [PATCH 2/2] UefiCpuPkg/MpInitLib: Remove global v
Reviewed-by: Eric Dong
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni, Ray
Sent: Wednesday, October 30, 2019 5:53 PM
To: devel@edk2.groups.io
Cc: Dong, Eric ; Laszlo Ersek
Subject: [edk2-devel] [PATCH 1/2] UefiCpuPkg/MpInitLib: Set X2ApicEnabl
Laszlo,
Thank you for the tests. I also tried secure boot (linux, windows) on both OVMF
and
Intel platform. All work well.
Regards,
Jian
> -Original Message-
> From: Laszlo Ersek
> Sent: Tuesday, November 05, 2019 1:45 AM
> To: devel@edk2.groups.io; Zhang, Shenglei
> Cc: Wang, Jian J
Please fix style formatting, especially in this function:
/**
Gets the number of devices in Table of SIO Controllers mDeviceInfo
@retval Number of enabled devices in Table of SIO Controllers.
**/
UINTN
EFIAPI
GetDeviceCount(
VOID
){
UINTNCount;
Count = ARRAY_SIZE(mDeviceIn
Hi Prince,
There's some high-level changes I suggest to the patch series:
1. This patch series mixes changes across packages in single patches
which should be avoided.
2. Some of the patches include unrelated changes that would make git
revert difficult.
2.a. Example: In patch #1, one ch
I sent 2 patches that day for 2 separate changes. I have resent those just now.
-Original Message-
From: Laszlo Ersek
Sent: Friday, November 1, 2019 4:58 PM
To: Ashish Singhal ; devel@edk2.groups.io;
jian.j.w...@intel.com; hao.a...@intel.com; Ray Ni ; Zhichao
Gao
Subject: Re: [edk2-de
Allow support for skipping auto enumeration of a BlockIO or
SimpleFileSystem or LoadFile protocol based on a new protocol
installed on the same handle. EdkiiSkipBmAutoEnumerate protocol
has been added for that purpose.
Signed-off-by: Ashish Singhal
---
.../Include/Protocol/SkipBmAutoEnumerate.h
Add a PCD to govern whether to use DT or ACPI in case the
variable governing this is not found or is not valid.
Signed-off-by: Ashish Singhal
---
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.c | 16 ++--
EmbeddedPkg/Drivers/DtPlatformDxe/DtPlatformDxe.inf | 3 +++
EmbeddedPkg/E
On 11/04/19 17:04, Laszlo Ersek wrote:
> On 11/01/19 07:55, Zhang, Shenglei wrote:
>> Update openssl from 1.1.1b to 1.1.1d.
>> Something needs to be noticed is that, there is a bug existing in the
>> released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
>> which causes build failure. S
Hi Chasel,
I will fix the descriptions and typos as suggested in my v2 patch series.
Thanks for the feedback!
Prince
-Original Message-
From: Chiu, Chasel
Sent: Monday, November 4, 2019 1:04 AM
To: Agyeman, Prince ; devel@edk2.groups.io
Cc: Kubacki, Michael A ; Desimone, Nathaniel L
On 11/4/19 5:06 PM, Pete Batard wrote:
From: Andrei Warkentin
It is possible for the command line to be empty
(Cmd->TagHead.TagValueSize = 0), in which case the code should not
attempt to read the value at CommandLine[-1].
Oops...
Reviewed-by: Philippe Mathieu-Daude
Signed-off-by: Pete Ba
From: Andrei Warkentin
It is possible for the command line to be empty
(Cmd->TagHead.TagValueSize = 0), in which case the code should not
attempt to read the value at CommandLine[-1].
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/RpiFirmwareDxe/RpiFirmwareDxe.c | 3 ++-
1 file ch
On 11/01/19 07:55, Zhang, Shenglei wrote:
> Update openssl from 1.1.1b to 1.1.1d.
> Something needs to be noticed is that, there is a bug existing in the
> released 1_1_1d version(894da2fb7ed5d314ee5c2fc9fd2d9b8b74111596),
> which causes build failure. So we switch the code base to a usable
> versi
On 10/31/19 10:02 AM, Laszlo Ersek wrote:
On 10/31/19 05:43, Kinney, Michael D wrote:
Leif,
Thanks. I agree. I will split it out.
I would further suggest alphabetical sorting for the .gitignore lines.
Reviewed-by: Philippe Mathieu-Daude
-Original Message-
From: Leif Lindholm
S
On Mon, Nov 04, 2019 at 01:12:02PM +, Pete Batard wrote:
> The existing logo bmp had its black level set to 7 instead of 0, which
> produces a poor image quality on some LCDs. This patch fixes that.
>
> Signed-off-by: Pete Batard
Reviewed-by: Leif Lindholm
Pushed as f72f81ebddb4.
> ---
>
The existing logo bmp had its black level set to 7 instead of 0, which
produces a poor image quality on some LCDs. This patch fixes that.
Signed-off-by: Pete Batard
---
Platform/RaspberryPi/Drivers/LogoDxe/Logo.bmp | Bin 185398 -> 185398 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
di
Hello Bob,
>> How do you compile 'SsdtSerialPortTemplate.asl' with the '-tc' to the .HEX
>> file? , based on the build_rule.txt, I think the .asl output file is a .aml
>> file.
[Pierre]
Our platform has the following flag:
[BuildOptions]
*_*_*_ASL_FLAGS = -tc
This flag is used in the
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Various:
– SMBIOSCR00183: add support for CXL Flexbus
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
MdePkg/Include/IndustryStandard/SmBios.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
System Slots (Type 9):
– SMBIOSCR00184: add PCI Express Gen 4 values
Cc: Ray Ni
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
.../SmbiosView/QueryTable.c | 26 ++-
1 file changed, 25 insertions(+), 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00179: update the string for Intel persistent memory
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
MdePkg/Include/IndustryStandard/SmBios.h | 14 +++---
1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
System Slots (Type 9):
– SMBIOSCR00184: add PCI Express Gen 4 values
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
MdePkg/Include/IndustryStandard/SmBios.h | 10 --
1 file changed, 8 insert
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Various:
– SMBIOSCR00183: add support for CXL Flexbus
Cc: Ray Ni
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
.../UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c| 8
1 file changed, 8 insertions(+)
diff --git
a/Shel
The following changes were made to version 3.2.0 of the document to produce this
version:
� System Slots (Type 9):
� Add PCI Express Gen 4 values
� Clarify bus number usage for PCI Express
� Memory Device (Type 17):
� Add new memory device type value (HBM) and new form factor value (Die)
� Update t
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00178: add new memory device type value (HBM) and new form
factor value (Die)
Cc: Ray Ni
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
.../SmbiosView/QueryTable.c | 12 ++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00178: add new memory device type value (HBM) and new form
factor value (Die)
Signed-off-by: Zhichao Gao
---
MdePkg/Include/IndustryStandard/SmBios.h | 7 +--
1 file changed, 5 insertions(+), 2 delet
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2305
Memory Device (Type 17):
– SMBIOSCR00179: update the string for Intel persistent memory
Cc: Ray Ni
Cc: Sai Chaganty
Signed-off-by: Zhichao Gao
---
.../Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c | 2 +-
1 file changed, 1
Hi Prince,
Below 2 files description does not match the driver purpose, please help to
correct them. Thanks!
edk2-platforms\Platform\Intel\BoardModulePkg\LegacySioDxe\ComponentName.c
("Install Base and Size Info Ppi for Firmware Volume Recovery.")
edk2-platforms\Platform\Intel\BoardModulePkg\L
Hi Prince,
I added 3 questions below inline, please help to check them. Thanks!
> -Original Message-
> From: Agyeman, Prince
> Sent: Saturday, November 2, 2019 3:51 AM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Chiu, Chasel
> ; Desimone, Nathaniel L
>
> Subject: [edk2-plat
43 matches
Mail list logo
