On 10/31/19 10:02 AM, Laszlo Ersek wrote:
On 10/31/19 05:43, Kinney, Michael D wrote:
Leif,

Thanks.  I agree.  I will split it out.

I would further suggest alphabetical sorting for the .gitignore lines.

Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com>

-----Original Message-----
From: Leif Lindholm <leif.lindh...@linaro.org>
Sent: Tuesday, October 29, 2019 7:30 PM
To: Kinney, Michael D <michael.d.kin...@intel.com>
Cc: devel@edk2.groups.io; Sean Brogan
<sean.bro...@microsoft.com>; Andrew Fish
<af...@apple.com>; Laszlo Ersek <ler...@redhat.com>
Subject: Re: [Patch v3 02/22] .gitignore: Ignore python
compiled files, extdeps, and vscode

On Tue, Oct 29, 2019 at 12:54:57PM -0700, Michael D
Kinney wrote:
From: Sean Brogan <sean.bro...@microsoft.com>

https://bugzilla.tianocore.org/show_bug.cgi?id=2315

Update .gitignore to ignore .pyc files and __pycache__
directories.
Python based plugins can be added to any package or
platform, so these
files and directories may be present outside of
BaseTools.

Ignore _extdep directories that are generated by the
pytool external
dependency feature.

Ignore .vscode directories generated by the VS Code
editor.

Cc: Andrew Fish <af...@apple.com>
Cc: Laszlo Ersek <ler...@redhat.com>
Cc: Leif Lindholm <leif.lindh...@linaro.org>
Signed-off-by: Kinney <michael.d.kin...@intel.com>

Reviewed-by: Leif Lindholm <leif.lindh...@linaro.org>

(This one could be merged independently of rest of set,
it's useful on its own.)

---
  .gitignore | 5 +++++
  1 file changed, 5 insertions(+)

diff --git a/.gitignore b/.gitignore
index 97f22c348c..71679478ac 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,3 +1,8 @@
  Build/
  tags/
  .DS_Store
+*.pyc
+__pycache__/
+*_extdep/
+
+.vscode/
--
2.21.0.windows.1






-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#49930): https://edk2.groups.io/g/devel/message/49930
Mute This Topic: https://groups.io/mt/39614156/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to