Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

Since the LSV can be managed from within the FmpDeviceLib i don't understand why this change is required.  This adds yet again more complexity to all users of FmpDxe for a very niche use case.  I believe the hooks already exist that would allow you to achieve the same functionality from within y

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/3] IntelSiliconPkg/FirmwareBootMediaLib: Add library

> -Original Message- > From: Kubacki, Michael A > Sent: Thursday, October 10, 2019 12:43 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [edk2-platforms][PATCH V2 1/3] > IntelSiliconPkg/FirmwareBootMediaLib: Add library > > Replies below. > > > -

[edk2-devel] [edk2-platforms: PATCH v3 1/9] Marvell/Armada7k8k: Fix 32-bit compilation

It turned out, that the recently added features broke ARM compilation. Fix all issues: * Update signatures types in structures (UINTN -> UINT64) * Use fixed type for address in ICU * Limit memory for ARM build to 1GB and stop using non-existent PCD Signed-off-by: Marcin Wojtas --- Silicon/Marvel

[edk2-devel] [edk2-platforms: PATCH v3 9/9] Marvell: Customize per-board SBMIOS strings

Now that the customization of Type1/2/3 SBMIOS tables strings is possible, adjust them for all supported boards. Signed-off-by: Marcin Wojtas --- Platform/Marvell/Armada70x0Db/Armada70x0Db.dsc| 4 Platform/Marvell/Armada80x0Db/Armada80x0Db.dsc| 4 Platform/Marvell/Cn9

[edk2-devel] [edk2-platforms: PATCH v3 3/9] Marvell/Cn9130Db: Introduce board support

This patch introduces all necessary components required for building EDK2 firmware for CN9130-DB setup A. Because the board is modular and can be extended to support also CN9131 and CN9132 SoC variants, extract common part into .dsc.inc file, which will be included by them. In order to build this

[edk2-devel] [edk2-platforms: PATCH v3 7/9] Marvell/Cn9132Db: Introduce board support

This patch introduces all necessary components required for building EDK2 firmware for CN9132-DB setup A. Note the ACPI is not yet available for this variant, due to the current ICU (CP1xx interrupt controller) support implementation. In order to build this variant, '-D CN9132' flag should be adde

[edk2-devel] [edk2-platforms: PATCH v3 5/9] Marvell/Library: IcuLib: Fix debug information

In case the number of CP11x components exceeded the maximum of currently supported, the user is informed with the information. It turned out that the print arguments were incorrect - fix it. Signed-off-by: Marcin Wojtas Reviewed-by: Leif Lindholm --- Silicon/Marvell/Library/IcuLib/IcuLib.c | 4

[edk2-devel] [edk2-platforms: PATCH v3 4/9] Marvell/Library: ArmadaSoCDescLib/MppLib: Extend Xenon information

Hitherto SoC description and MppLib libraries code assumed that there could be only two Xenon SdMmc controller instances in the SoC. Remove those limitations, so that to support CN913x SoCs, which may have up to 4 of such interfaces. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/Li

[edk2-devel] [edk2-platforms: PATCH v3 2/9] Marvell/Cn9130Db: Add ACPI tables

This patch adds ACPI tables and necessary headers, which are common for Cn913x SoCs and the CN9130 development board (variant A). Wiring up of support will be done in the follow-up commits. Signed-off-by: Marcin Wojtas Acked-by: Leif Lindholm --- Silicon/Marvell/OcteonTx/AcpiTables/T91/Cn9130Db

[edk2-devel] [edk2-non-osi: PATCH 1/3] Marvell/Cn9130Db: Add DeviceTree

This patch adds device tree sources which are common for Cn913x SoCs and the CN9130 development board (variant A). Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/DeviceTree/T91/Cn9130DbA.inf | 22 + Silicon/Marvell/OcteonTx/DeviceTree/T91/armada-ap806-quad.dtsi | 43 ++ Sil

[edk2-devel] [edk2-platforms: PATCH v3 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD

From: Patryk Duda This patch implements convenient way of changing strings included in SMBIOS Table1, Table2, Table3. Strings can be altered by defining following PCDs: gMarvellTokenSpaceGuid.PcdProductManufacturer gMarvellTokenSpaceGuid.PcdProductPlatformName gMarvellTokenSpaceGuid.PcdPro

[edk2-devel] [edk2-platforms: PATCH v3 0/9] Marvell Octeon CN913X SoC family support

Hi, After a couple of weeks I finaly was able to submit the third version of CN913X SoC family support introduction. Following the v2 comments the device tree part was moved to the edk2-platforms. Also there is no default platform built, so in any case the build flag must be declared explicitly.

[edk2-devel] [edk2-platforms: PATCH v3 6/9] Marvell/Cn9131Db: Introduce board support

This patch introduces all necessary components required for building EDK2 firmware for CN9131-DB setup A. In order to build this variant, '-D CN9131' flag should be added. Signed-off-by: Marcin Wojtas --- Platform/Marvell/Cn913xDb/Cn9131DbA.dsc.inc | 72 ++

[edk2-devel] [edk2-non-osi: PATCH 2/3] Marvell/Cn9131Db: Add DeviceTree

This patch adjusts the top device tree for the CN9131 development board (variant A), based on the sources which are common for the Cn913x SoCs. Also an .inf file is added to allow its compilation. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/DeviceTree/T91/Cn9131DbA.inf | 22 ++

[edk2-devel] [edk2-non-osi: PATCH 3/3] Marvell/Cn9132Db: Add DeviceTree

This patch adjusts the top device tree for the CN9132 development board (variant A), based on the sources which are common for the Cn913x SoCs. Also an .inf file is added to allow its compilation. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/OcteonTx/DeviceTree/T91/Cn9132DbA.inf | 22

[edk2-devel] [edk2-non-osi: PATCH 0/3] Marvell CN913x device tree

Hi, As agreed, due to the licencing concerns (GPL/MIT), it is better to keep the device trees for newly added SoC family in edk2-non-osi. For convenience, the patches are available in the public github branch: https://github.com/MarvellEmbeddedProcessors/edk2-open-platform/commits/cn913x-dt-upstr

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/3] IntelSiliconPkg/FirmwareBootMediaLib: Add library

Replies below. > -Original Message- > From: Ni, Ray > Sent: Wednesday, October 9, 2019 7:21 PM > To: Kubacki, Michael A ; > devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [edk2-platforms][PATCH V2 1/3] > IntelSiliconPkg/FirmwareBootMediaLib: Add library > > Comments belo

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

Hi, Maciej Considering that this patch has to co-work with corresponding UNDI device driver bug fix, in order to avoid potential compatibility problem, please add a PCD to NetworkPkg for this fix, and set the default value to disable state (no behavior change). The platform which need this fix c

[edk2-devel] [RFC]Drop EDK Shell (EdkShellPkg) support

All, Given the fact EdkShellPkg was deleted from edk2 repo one year ago (6caf954c1bf9), I propose to drop the support of EDK Shell in ShellPkg. The EDK Shell support is mainly in ShellPkg/Library/UefiShellLib. The library supports to build individual shell apps that can run in both UEFI Shell and

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

Below summary of setup from Laszlo are also the part of our test cases. Beside those verification that only focus on the subject Common Name (CN), we also created the certificate contains Subject Alternative Name (SAN) to cover more test cases related to the subjectAltName. That’s also the parts

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

Laszlo, Can you add comments in the code you changed to describe the two different behaviors? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48685): https://edk2.groups.io/g/devel/message/48685 Mute This Topic: https://groups.io/mt/34441

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

Hi Laszlo, Thanks the comments. Best Regards! Jiaxin > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 11:55 PM > To: devel@edk2.groups.io; Wang, Jian J ; Wu, Jiaxin > ; David Woodhouse ; Bret > Barkelew > Subject: Re: [edk2-devel] [PATCH v1 0/4] Support H

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

> > I have not tested this, but I started looking when there was a message > on the edk2 list from someone who was reporting that it didn't work for > IPv6 URIs, IIRC. > > You are using SSL_set1_host(), and I believe you're just passing in the > bare hostname part of the URI, be it "1.2.3.4" or "

Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SNP Statistics change to IHV

Reviewed-by: Eric Jin > -Original Message- > From: Liu, XianhuiX > Sent: Thursday, October 10, 2019 10:24 AM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh > ; Jin, Eric ; Liu, > XianhuiX > Subject: [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SNP Statistics ch

Re: [edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV

Reviewed-by: Eric Jin > -Original Message- > From: devel@edk2.groups.io On Behalf Of xianhui > liu > Sent: Thursday, October 10, 2019 10:13 AM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh > ; Jin, Eric ; Liu, > XianhuiX > Subject: [edk2-devel] [edk2-test][Pa

[edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SNP Statistics change to IHV

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2160 sync commit 269f8a35e44f2093625b3671f372f68e2983c49d on file EFI/Protocol/SimpleNetwork/BlackBoxTest /SimpleNetworkBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu --- ..

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/3] IntelSiliconPkg/FirmwareBootMediaLib: Add library

Comments below. > -Original Message- > From: Kubacki, Michael A > Sent: Thursday, October 10, 2019 12:34 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V > Subject: RE: [edk2-platforms][PATCH V2 1/3] > IntelSiliconPkg/FirmwareBootMediaLib: Add library > > 1. DxeSmmFirm

[edk2-devel] [edk2-test][Patch v2] uefi-sct/SctPkg: Sync SimpleTextInputEx change to IHV

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169 sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4 on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest /SimpleTextInputExBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP Statistics change to IHV

Content is good to me. Please update the copyright with correct year info. Best Regards Eric > -Original Message- > From: devel@edk2.groups.io On Behalf Of xianhui > liu > Sent: Wednesday, October 9, 2019 5:42 PM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh >

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

> -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Thursday, October 10, 2019 9:58 AM > To: Wu, Hao A; devel@edk2.groups.io; Ni, Ray > Subject: RE: [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation > > Hello Hao, > > I can see that the PEI also ha

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SimpleTesxtInputEx change to IHV

Hi Xianhui, > -Original Message- > From: devel@edk2.groups.io On Behalf Of xianhui > liu > Sent: Wednesday, October 9, 2019 4:09 PM > To: devel@edk2.groups.io > Cc: Heinrich Schuchardt ; Supreeth Venkatesh > ; Jin, Eric ; Liu, > XianhuiX > Subject: [edk2-devel] [edk2-test][Patch] uefi-sc

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

Hello Hao, I can see that the PEI also has the same issue and take a look at that as well but I have no way to verify that as we are not using it. For the change I have made in DXE, I have verified it with an alignment of 4K and 64K. Thanks Ashish -Original Message- From: Wu, Hao A S

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync StrUpr() test change to IHV

Reviewed-by: Eric Jin -Original Message- From: Liu, XianhuiX Sent: Wednesday, October 9, 2019 4:11 PM To: devel@edk2.groups.io Cc: Heinrich Schuchardt ; Supreeth Venkatesh ; Jin, Eric ; Liu, XianhuiX Subject: [edk2-test][Patch] uefi-sct/SctPkg: Sync StrUpr() test change to IHV REF:

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

> -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Thursday, October 10, 2019 1:02 AM > To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray > Cc: Ashish Singhal > Subject: [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation > > While allocating pages aligne

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

On 10/08/19 18:16, Rabeda, Maciej wrote: > Patch addresses Bugzilla #1972. I think the BZ reference should be . (The cover letter has it right.) Thanks Laszlo > During ExitBootServices stage, drivers should not call any > functions known to us

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

Can you show result of 'openssl x509 -noout -text -in xx.pem' on your certs please. Would like to check if you really have a cert for the hostname string "192.168.124.2" or to the IP address. They are different things. On 9 October 2019 21:24:34 BST, Laszlo Ersek wrote: >Hi All, > >(multi

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

Hi All, (multi-hour composition ahead...) On 10/09/19 09:53, David Woodhouse wrote: > On Tue, 2019-10-08 at 06:19 +, Wu, Jiaxin wrote: >> Hi David, >> >> I just realized you have the comments on Bugzilla 960: >> >>> "...given that testing is failing and code inspection shows it >>> would neve

[edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

While allocating pages aligned at an alignment higher than 4K, allocate memory taking into consideration the padding required for that alignment. The calls to free pages takes care of this already. Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c | 2 +- 1 file changed,

Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

Will do. Track number as title, https://bugzilla.tianocore.org/show_bug.cgi?id=2236. From: Gao, Liming Sent: Wednesday, October 9, 2019 9:38 PM To: devel@edk2.groups.io; Chen, Kenji Subject: RE: Patch for Bug 2236 on Bugzilla Kenji: Please use git format-patch -1 to generate the patch, then u

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/3] IntelSiliconPkg/FirmwareBootMediaLib: Add library

1. DxeSmmFirmwareBootMediaLib could get the HOB like PEI for every access. I considered this but it seems unnecessary since we have the flexibility for phase-specific drivers that can have trivial optimizations like this. Checking the HOB on every access would also constrain usage in DXE_SMM_DR

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain -

> On Oct 9, 2019, at 7:44 AM, Gao, Liming wrote: > > Laszlo: > >> -Original Message- >> From: Laszlo Ersek >> Sent: Wednesday, October 9, 2019 9:44 PM >> To: Andrew Fish ; devel@edk2.groups.io >> Cc: Gao, Liming >> Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool c

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

On 10/01/19 01:21, Laszlo Ersek wrote: > On 09/29/19 08:09, Wang, Jian J wrote: >> For this patch series, >> 1. " Contributed-under: TianoCore Contribution Agreement 1.1" is not needed >> any more. >> Remove it at push time and no need to send a v2. >> 2. Since it's security patch which had been

Re: [edk2-devel] [PATCH 1/4] UefiCpuPkg/MpInitLib: honor the platform's boot CPU count in AP detection

On 10/09/19 02:57, Dong, Eric wrote: > Hi Laszlo, > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Tuesday, October 8, 2019 7:27 PM >> To: edk2-devel-groups-io >> Cc: Dong, Eric ; Igor Mammedov >> ; Ni, Ray >> Subje

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

Laszlo: > -Original Message- > From: Laszlo Ersek > Sent: Wednesday, October 9, 2019 9:44 PM > To: Andrew Fish ; devel@edk2.groups.io > Cc: Gao, Liming > Subject: Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain > > On 10/09/19 01:08, Andrew Fish wrote: > > > So I guess

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: rewrite MaxCpuCountInitialization() for CPU hotplug

On 10/09/19 12:23, Igor Mammedov wrote: > On Tue, 8 Oct 2019 23:12:10 +0200 > Laszlo Ersek wrote: > >> On 10/08/19 17:06, Igor Mammedov wrote: >>> On Tue, 8 Oct 2019 13:27:14 +0200 >>> Laszlo Ersek wrote: >>> MaxCpuCountInitialization() currently handles the following options:

Re: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

On Wed, Oct 09, 2019 at 01:48:57PM +, Gao, Liming wrote: > Leif: > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > > Sent: Wednesday, October 9, 2019 8:00 PM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Kinney, Michael D > > > > Subject: [

Re: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

Leif: > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Wednesday, October 9, 2019 8:00 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Kinney, Michael D > > Subject: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file > to machi

Re: [edk2-devel] [Patch 11/12] OvmfPkg: Enable CLANG9 tool chain

On 10/09/19 01:08, Andrew Fish wrote: > So I guess the way to describe it is XCODE inherits GCC and only needs to > override when it is different. Thank you for the explanation! I've been trying to figure out why this inheritance bothers me so much. I guess the reason is the following: I'm a u

Re: [edk2-devel] Patch for Bug 2236 on Bugzilla

Kenji: Please use git format-patch -1 to generate the patch, then use git send-email xxx.patch to send this patch to devel@edk2.groups.io Besides, is there the track in edk2 https://bugzilla.tianocore.org/? If no, can you submit one? Thanks Liming From: devel@ed

Re: [edk2-devel] [PATCH edk2-platforms 2/6] Maintainers.txt: drop ',' from maintainer names

On 10/9/19 3:16 PM, Leif Lindholm wrote: On Wed, Oct 09, 2019 at 02:53:34PM +0200, Philippe Mathieu-Daudé wrote: On 10/9/19 2:00 PM, Leif Lindholm wrote: The ',' character, when used in the name part of email addresses, must be escaped. Not doing so leads to all kinds of fun with SMTP. So rewor

Re: [edk2-devel] [PATCH edk2-platforms 4/6] Maintainers.txt: merge Marvell platforms and silicon sections

Hi Leif, śr., 9 paź 2019 o 14:00 Leif Lindholm napisał(a): > > Cc: Marcin Wojtas > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 14 -- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 43803592d369..56b12dd79c3f

Re: [edk2-devel] [PATCH edk2-platforms 2/6] Maintainers.txt: drop ',' from maintainer names

On Wed, Oct 09, 2019 at 02:53:34PM +0200, Philippe Mathieu-Daudé wrote: > On 10/9/19 2:00 PM, Leif Lindholm wrote: > > The ',' character, when used in the name part of email addresses, > > must be escaped. Not doing so leads to all kinds of fun with SMTP. > > So rework all M: entries containing a ,

Re: [edk2-devel] [PATCH edk2-platforms 1/6] Maintainers.txt: Update documentation for new format

On 10/9/19 2:54 PM, Leif Lindholm wrote: On Wed, Oct 09, 2019 at 02:51:38PM +0200, Philippe Mathieu-Daudé wrote: On 10/9/19 2:00 PM, Leif Lindholm wrote: Synchronize header with edk2/Maintainers.txt and change references from "EDK II to EDK II Platforms". Cc: Ard Biesheuvel Cc: Michael D Kinn

Re: [edk2-devel] [PATCH edk2-platforms 5/6] Maintainers.txt: create explicit sections for remaining modules

On 10/9/19 2:00 PM, Leif Lindholm wrote: Many of the original (ARM) platforms, and drivers brought in for them, had no explicit maintainership defined. Add entries for these, roughly corresponding to how they have already been handled in the past. Cc: Ard Bieshuevel Cc: Michael D Kinney Signed

Re: [edk2-devel] [PATCH edk2-platforms 4/6] Maintainers.txt: merge Marvell platforms and silicon sections

On 10/9/19 2:00 PM, Leif Lindholm wrote: Cc: Marcin Wojtas Signed-off-by: Leif Lindholm --- Maintainers.txt | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 43803592d369..56b12dd79c3f 100644 --- a/Maintainers.txt +++

Re: [edk2-devel] [PATCH edk2-platforms 1/6] Maintainers.txt: Update documentation for new format

On Wed, Oct 09, 2019 at 02:51:38PM +0200, Philippe Mathieu-Daudé wrote: > On 10/9/19 2:00 PM, Leif Lindholm wrote: > > Synchronize header with edk2/Maintainers.txt and change references > > from "EDK II to EDK II Platforms". > > > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > > Signed-off-by:

Re: [edk2-devel] [PATCH edk2-platforms 2/6] Maintainers.txt: drop ',' from maintainer names

On 10/9/19 2:00 PM, Leif Lindholm wrote: The ',' character, when used in the name part of email addresses, must be escaped. Not doing so leads to all kinds of fun with SMTP. So rework all M: entries containing a , to not do so. Oh, good tip! Cc: Ard Bieshuevel Cc: Michael D Kinney Signed-of

Re: [edk2-devel] [PATCH edk2-platforms 1/6] Maintainers.txt: Update documentation for new format

On 10/9/19 2:00 PM, Leif Lindholm wrote: Synchronize header with edk2/Maintainers.txt and change references from "EDK II to EDK II Platforms". Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Leif Lindholm --- Maintainers.txt | 42 +- 1 file ch

Re: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

On Wed, Oct 09, 2019 at 02:31:21PM +0200, Ard Biesheuvel wrote: > On Wed, 9 Oct 2019 at 14:00, Leif Lindholm wrote: > > > > Convert existing package maintainer/reviewer descriptions > > with adding the new path definitions. > > > > Delete the "Platform" and "Silicon" section maintainership > > des

Re: [edk2-devel] [PATCH edk2-platforms 0/6] Update Maintainers.txt

On Wed, Oct 09, 2019 at 02:32:37PM +0200, Ard Biesheuvel wrote: > On Wed, 9 Oct 2019 at 14:00, Leif Lindholm wrote: > > > > This set does a few things: > > - Imports the documentation header from edk2/Maintainers.txt > > - Reformats some maintainer entries to get rid of ',' characters > > in the

Re: [edk2-devel] [PATCH edk2-platforms 0/6] Update Maintainers.txt

On Wed, 9 Oct 2019 at 14:00, Leif Lindholm wrote: > > This set does a few things: > - Imports the documentation header from edk2/Maintainers.txt > - Reformats some maintainer entries to get rid of ',' characters > in the names. > - Adds F: entries for all sections, and a default fallback section

Re: [edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

On Wed, 9 Oct 2019 at 14:00, Leif Lindholm wrote: > > Convert existing package maintainer/reviewer descriptions > with adding the new path definitions. > > Delete the "Platform" and "Silicon" section maintainership > descriptions. The EDK II Platforms maintainers section will > now match that. > >

Re: [edk2-devel] [PATCH v2 3/7] BaseTools: strip trailing whitespace

Hi Mike, This one turned out to be a bit trickier, and also it was helpful converting Maintainers.txt in preparation, but now sent out. Regards, Leif On Fri, Oct 04, 2019 at 04:01:09PM +, Kinney, Michael D wrote: > Hi Leif, > > Do you want to run the same script on the edk2-platforms > rep

[edk2-devel] [PATCH edk2-platforms 5/6] Maintainers.txt: create explicit sections for remaining modules

Many of the original (ARM) platforms, and drivers brought in for them, had no explicit maintainership defined. Add entries for these, roughly corresponding to how they have already been handled in the past. Cc: Ard Bieshuevel Cc: Michael D Kinney Signed-off-by: Leif Lindholm --- Maintainers.tx

[edk2-devel] [PATCH edk2-platforms 3/6] Maintainers.txt: revamp file to machine-readable format

Convert existing package maintainer/reviewer descriptions with adding the new path definitions. Delete the "Platform" and "Silicon" section maintainership descriptions. The EDK II Platforms maintainers section will now match that. Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Leif Lind

[edk2-devel] [PATCH edk2-platforms 1/6] Maintainers.txt: Update documentation for new format

Synchronize header with edk2/Maintainers.txt and change references from "EDK II to EDK II Platforms". Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by: Leif Lindholm --- Maintainers.txt | 42 +- 1 file changed, 33 insertions(+), 9 deletions(-) diff

[edk2-devel] [PATCH edk2-platforms 0/6] Update Maintainers.txt

This set does a few things: - Imports the documentation header from edk2/Maintainers.txt - Reformats some maintainer entries to get rid of ',' characters in the names. - Adds F: entries for all sections, and a default fallback section for those where there is no match. - Merges the Marvell sect

[edk2-devel] [PATCH edk2-platforms 4/6] Maintainers.txt: merge Marvell platforms and silicon sections

Cc: Marcin Wojtas Signed-off-by: Leif Lindholm --- Maintainers.txt | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index 43803592d369..56b12dd79c3f 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -160,15 +160,6 @@ F: Pla

[edk2-devel] [PATCH edk2-platforms 2/6] Maintainers.txt: drop ',' from maintainer names

The ',' character, when used in the name part of email addresses, must be escaped. Not doing so leads to all kinds of fun with SMTP. So rework all M: entries containing a , to not do so. Cc: Ard Bieshuevel Cc: Michael D Kinney Signed-off-by: Leif Lindholm --- Maintainers.txt | 18 +

[edk2-devel] [PATCH edk2-platforms 6/6] Maintainers.txt: drop Ard from default section

Ard will still be looking after specific platforms and drivers, but he was mainly added to the "default" maintainers group to offload me until edk2-platforms got off the ground, so drop him from that target now we add the GetMaintainers.py. Cc: Ard Biesheuvel Cc: Michael D Kinney Signed-off-by:

Re: [edk2-devel] [PATCH 4/4] OvmfPkg/PlatformPei: rewrite MaxCpuCountInitialization() for CPU hotplug

On Tue, 8 Oct 2019 23:12:10 +0200 Laszlo Ersek wrote: > On 10/08/19 17:06, Igor Mammedov wrote: > > On Tue, 8 Oct 2019 13:27:14 +0200 > > Laszlo Ersek wrote: > > > >> MaxCpuCountInitialization() currently handles the following options: > >> > >> (1) QEMU does not report the boot CPU count. >

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

On 10/09/19 01:49, Laszlo Ersek wrote: > On 09/17/19 21:49, Laszlo Ersek wrote: >> Repository: https://github.com/lersek/edk2.git >> Branch: voidptr >> >> The UEFI / PI / Shell specifications define a number of standard types >> as pointers to VOID. This is arguably a design mistake; those type

[edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SNP Statistics change to IHV

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2160 sync commit 269f8a35e44f2093625b3671f372f68e2983c49d on file EFI/Protocol/SimpleNetwork/BlackBoxTest /SimpleNetworkBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu --- ..

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

I've commented on the bug, SFC adapters will be fine, but I am sure there is a vendor out there that will be affected. Bugs due to memory corruption during OS load that depend on the network externalities are notoriously difficult to diagnose. We need to make sure this is properly communicated

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/3] IntelSiliconPkg/FirmwareBootMediaLib: Add library

Michael, Two comments: 1. The difference between PEI and DXE instances is DXE instance has a global variable caching the boot media type. Both get the type from HOB. So I am thinking how about simplifying the library to have only one instance which equals to PEI instance. That can also be used i

Re: [edk2-devel] [PATCH v1 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

Hi Siyuan, This change has no effect to Intel Ethernet Server UNDI drivers. They already handle ExitBootServices event and configure the Ethernet adapters not to perform any DMA at this point. As per whitepaper (https://firmware.intel.com/sites/default/files/Intel_WhitePaper_Using_IOMMU_for_DMA

[edk2-devel] Patch for Bug 2236 on Bugzilla

Commit Message: FmpDevicePkg: Deferred LSV Commit after Platform Health Check - LSV variable in each FmpDevice is updated after each successful FmpSetImage invocation. This blocks the deferred SVN mechanism performed by platfor side. Add a PCD to remove it to make platform code feasible to hand

[edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync StrUpr() test change to IHV

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1911 sync commit cce43fc3ae30d343964fe02f09242ec8604eb44b on file EFI/Protocol/UnicodeCollation2/BlackBoxTest /UnicodeCollation2BBTestFunction.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu --

[edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Sync SimpleTesxtInputEx change to IHV

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2169 sync commit fc1a95f7b1a4c157d0536bc159bc5114cdfcb9b4 on file EFI/Protocol/SimpleTextInputEx/BlackBoxTest /SimpleTextInputExBBTestConformance.c to IHV Cc: Heinrich Schuchardt Cc: Supreeth Venkatesh Cc: Eric Jin Signed-off-by: xianhui liu

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

On Tue, 2019-10-08 at 06:19 +, Wu, Jiaxin wrote: > Hi David, > > I just realized you have the comments on Bugzilla 960: > > > "...given that testing is failing and code inspection shows it > > would never have been expected to work." > > Do you mean you didn't pass the verification if URLs

Re: [edk2-devel] [PATCH v6 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

Thanks for take my suggestion. But you may forget the other one. What I said is that moving the display functions into one function, not just removing one of them. Here is the example: VOID DisplayProcessorArchitectureType ( IN UINT8 Key, IN UINT8 Option ) { ShellPrintHiiEx (-1,-1,NULL,STR

Re: [edk2-devel] [PATCH v5 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

HI Zhichao, I revise it as your suggestion. [PATCH v6] for the third patch (rebased) was just sent. Thanks Abner > -Original Message- > From: Gao, Zhichao [mailto:zhichao@intel.com] > Sent: Wednesday, October 9, 2019 10:58 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Techno

[edk2-devel] [PATCH v6 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

Shell command smbiosview updates for SMBIOS 3.3.0 spec. Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Signed-off-by: Abner Chang Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Leif Lindholm Cc: Gilbert Chen --- .../SmbiosView/PrintInfo.c | 22