Reviewed-by: Eric Jin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Supreeth
Venkatesh
Sent: Thursday, September 26, 2019 7:52 AM
To: devel@edk2.groups.io
Cc: Jin, Eric ; Supreeth Venkatesh
Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] MiscRuntimeServices: Add
statemen
Reviewed-by: Eric Jin
-Original Message-
From: devel@edk2.groups.io On Behalf Of Supreeth
Venkatesh
Sent: Thursday, September 26, 2019 7:52 AM
To: devel@edk2.groups.io
Cc: Jin, Eric ; Supreeth Venkatesh
Subject: [edk2-devel] [edk2-test][PATCH v1 1/1] SctPkg: Fix issue with the
shell
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
Since Runtime Services GetVariable() and GetNextVariableName() no longer
trigger a SW SMI, this change removes the code for handling those requests
from VariableSmm.c.
The following SMM communicate functions are removed from
SmmVariableHandl
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change reduces SMIs for GetVariable () by maintaining a
UEFI variable cache in Runtime DXE in addition to the pre-
existing cache in SMRAM. When the Runtime Service GetVariable()
is invoked, a Runtime DXE cache is used instead of trigger
This change moves the following functions into a dedicated file
so they may be used in other variable files as needed. Furthermore,
it reduces the overall size of the common Variable.c file.
* DataSizeOfVariable ()
* FindVariableEx ()
* GetEndPointer ()
* GetNextVariableEx ()
* GetNextVariabl
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
Overview
-
This patch series reduces SMM usage when using VariableSmmRuntimeDxe with
VariableSmm. It does so by eliminating SMM usage for runtime service
GetVariable () and GetNextVariableName () invocations. Most UEFI variable
usage
https://bugzilla.tianocore.org/show_bug.cgi?id=2220
This change implements the Runtime Service GetNextVariableName()
using the Runtime Cache in VariableSmmRuntimeDxe. Runtime Service
calls to GetNextVariableName() will no longer trigger a SW SMI.
Overall system performance and stability will be i
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2220
The current VariableInfo application only checks for variable
statistics from SMM if the variable information entries are
not present in the UEFI System Configuration table as published
by the DXE UEFI variable driver (VariableRuntimeDxe).
T
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, September 18, 2019 3:50 AM
> To: edk2-devel-groups-io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: [edk2-devel] [PATCH 30/35] ShellPkg: stop takin
Reviewed-by: Zhichao Gao
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix
> para
Reviewed-by: Zhichao Gao
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, September 18, 2019 3:49 AM
> To: edk2-devel-groups-io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: [PATCH 29/35] ShellPkg: stop using EFI_HANDLE in place of
> EF
Thanks Laszlo for your time on detail reviewing and very good feedbacks!
Please see my reply inline below.
> -Original Message-
> From: Laszlo Ersek
> Sent: Thursday, September 26, 2019 2:58 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Wu, Hao A ; Dong, Eric ;
> Desimone, Nathaniel
Hi All,
Intel is pleased to announce that Comet Lake FSP is now available on
https://github.com/IntelFsp/FSP.
With Best Regards,
Nate
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48065): https://edk2.groups.io/g/devel/message/48065
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Agrawal, Sachin
> Sent: Monday, September 23, 2019 7:48 PM
> To: devel@edk2.groups.io
> Cc: Agrawal, Sachin; Wu, Hao A; Ni, Ray
> Subject: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThru : Fix UFS f
> -Original Message-
> From: Albecki, Mateusz
> Sent: Wednesday, September 25, 2019 10:54 PM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Marcin Wojtas
> Subject: RE: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing
> switch sequence
>
>
>
> > -Original Message-
> > From: Wu
To answer your questions:
1. As you say, putty may not be not standard terminal. So removing it from
comment is inappropriate in my opinion.
2. Terminal DXE driver doesn't have the related mode (normal or application
mode). It wouldn't make other terminal software unhappy except they input the
s
> -Original Message-
> From: Ni, Ray
> Sent: Thursday, September 26, 2019 2:17 AM
> To: devel@edk2.groups.io; Gao, Zhichao
> Cc: Wang, Jian J ; Wu, Hao A ;
> Gao, Liming
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: Enhance
> the arrow keys support
>
> Zhichao,
> The f
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCEL
CALSCALE:GREGORIAN
BEGIN:VEVENT
STATUS:CANCELLED
UID:calendar.14...@groups.io
DTSTAMP:20190926T004117Z
ORGANIZER;CN=Stephano Cetola:mailto:stephano.cet...@intel.com
DTSTART;20191004T013000Z
DTEND;20191004T0230
The code replaces the hard code with macros defined in
MdePkg\Include\Register\Intel\CpuId.h.
No functionality impact.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 24 +++-
1 file changed, 11 insertions(+), 13 deletions
Today's logic is to only enable 5-level paging when CPU supports it
and the maximum physical address size > 48.
The patch changes to get the maximum physical address size firstly
from CpuInfo HOB then CPUID result. It aligns to the behavior of
existing code that builds the page table.
Signed-off-b
Ray Ni (2):
UefiCpuPkg/PiSmmCpu: Remove hard code when getting physical line size
UefiCpuPkg/PiSmmCpuDxe: Honor the physical address size in CpuInfo HOB
UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 63 +
1 file changed, 23 insertions(+), 40 deletions(-)
--
2.21.0.window
For users, who operate the machine remotely through serial console on
some platforms, the test prompt message shown "System will shut down (or
cold reset) after 1 second..." is misleading, as the reset may not be
automatic.
This patch addresses the issue by adding a note "Note: On some
platforms,
Fix unintended "space" characters that were added when
IhvFirmwareManagementBBTest.efi was checked-in.
Signed-off-by: Supreeth Venkatesh
---
uefi-sct/SctPkg/CommonGenFramework.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/uefi-sct/SctPkg/CommonGenFramework.sh
b/uefi-sct
Minh,
What APIs are you using to do Console IO?
At the EFI layer you don't think of SimpleTxtInEx/SimpleTextIn and SimpleTxtOut
as a single console device. You need to think of them as the driver providing
the service. So for example SimpleTxtInEx/SimpleTextIn could be produced by the
USB Keyb
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Tuesday, September 24, 2019 11:13 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Sinha, Ankit ; Jeremy
Soller
Subject: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 board details to
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Tuesday, September 24, 2019 11:13 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Sinha, Ankit ; Jeremy
Soller
Subject: [edk2-platforms][PATCH V2 14/15] KabylakeOpenBoardPkg/GalagoPro3
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Tuesday, September 24, 2019 11:13 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Sinha, Ankit ; Jeremy
Soller
Subject: [edk2-platforms][PATCH V2 13/15] KabylakeOpenBoardPkg/BoardAcpiD
Marvin,
Can you kindly share what unit test you've done?
> -Original Message-
> From: Marvin Häuser
> Sent: Tuesday, September 24, 2019 5:46 AM
> To: devel@edk2.groups.io
> Cc: Justen, Jordan L ; Andrew Fish
> ; Ni, Ray
> Subject: [PATCH] WinHost: Add SimplePointer support
>
> From: Ma
Tom - Yes please.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Lendacky,
> Thomas
> Sent: Tuesday, September 24, 2019 7:31 AM
> To: Dong, Eric ; Ni, Ray
> Cc: Justen, Jordan L ; Laszlo Ersek
> ; Ard Biesheuvel
> ; Kinney, Michael D ;
> Gao, Liming ;
> Singh, Brijesh
Patch 1 through 12 just look like a rebase of the previous patch series. For
those patches...
Reviewed-by: Nate DeSimone
-Original Message-
From: devel@edk2.groups.io On Behalf Of Kubacki, Michael
A
Sent: Tuesday, September 24, 2019 11:13 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ;
On 09/25/19 11:21, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2212
>
> In binary model the same binary may have to support both
> S3 enabled and disabled scenarios, however not all DXE
> drivers linking PiDxeS3BootScriptLib can return error to
> invoke library DESTRU
Hi,
I am new to Tianocore. Right now, I am trying to develop an UEFI app with
interactive menu that would ask user to input values for each step. I managed
to get the application to read the backspace keystroke. And when this occur, it
would delete the character prior to cursor (one by one). Is
Zhichao,
The four new modes you newly added are supported by putty. But I do not think
Putty is the standard the terminal driver needs to follow.
So,
1. can you please remove the "putty" from the comments (maybe code)?
2. can you please find the sources where each mode is defined and double check
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> The UefiShell*CommandsLib instances have constructor functions that do
> something like:
>
> gHiiHandle = HiiAddPackages (...);
> ...
> ShellCommandRegisterCommandName (..., gHiiHandle, ...);
>
> and destructor functions that implement the following
On 9/25/19 3:27 AM, Laszlo Ersek wrote:
> On 09/19/19 21:52, Lendacky, Thomas wrote:
>> From: Tom Lendacky
>>
>> Protect the memory used by an SEV-ES guest when S3 is supported. This
>> includes the page table used to break down the 2MB page that contains
>> the GHCB so that it can be marked un-en
On 9/25/19 3:09 AM, Laszlo Ersek wrote:
> On 09/19/19 21:52, Lendacky, Thomas wrote:
>> From: Tom Lendacky
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>>
>> A GHCB page is needed during the Sec phase, so this new page must be
>> created. Since the GHCB must be marked as an un-en
On 9/17/19 9:49 PM, Laszlo Ersek wrote:
> EfiCreateProtocolNotifyEvent() takes a (VOID**) for "Registration",
> similarly to gBS->RegisterProtocolNotify(). We should pass the address of
> an actual pointer-to-VOID, and not the address of an EFI_EVENT. EFI_EVENT
> just happens to be specified as (VO
On Tue, 17 Sep 2019 at 21:50, Laszlo Ersek wrote:
>
> In the following call tree:
>
> PlatformInit ()
>mInstalledPackages = HiiAddPackages ()
> GopInstalled ()
> PopulateForm (PackageList = mInstalledPackages)
> CreateResolutionOptions (PackageList)
> HiiSetString (PackageL
(snipping liberally)
On 09/25/19 10:13, Marvin Häuser wrote:
> Am 24.09.2019 um 22:26 schrieb Laszlo Ersek:
>> I'm opposed to enforcing the strict aliasing rules, even though in
>> all code that I write, I either try to conform to them, or at least I
>> seek to be fully conscious of breaking them
On Tue, 17 Sep 2019 at 21:49, Laszlo Ersek wrote:
>
> The 3rd and 4th parameters of the CloseProtocol() call are wrong.
>
> Given that we're not dissociating a child controller from a parent
> controller (= closing a BY_CHILD_CONTROLLER open), but closing a BY_DRIVER
> open, the 4th parameter (Con
The existing loop is set to call PlatformBootManagerWaitCallback every
second except the last one. We believe this is a mistake as it prevents
the called code from performing timeout expiration tasks such as, for
instance, ensuring that the last segment of a progress bar is displayed
before continu
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, September 25, 2019 5:34 AM
> To: Albecki, Mateusz ; devel@edk2.groups.io
> Cc: Marcin Wojtas
> Subject: RE: [PATCH 1/1] MdeModulePkg/SdMmcPciHcDxe: Fix bus timing
> switch sequence
>
> > -Original Message-
> > From: Alb
On 09/24/19 20:57, Lendacky, Thomas wrote:
> On 9/24/19 8:42 AM, Laszlo Ersek wrote:
>> On 09/19/19 21:52, Lendacky, Thomas wrote:
>>> +mov esp, SEV_TOP_OF_STACK
>>
>> (2) Can we %define SEV_TOP_OF_STACK in this file, or does it have to be
>> in "ResetVector.nasmb"?
>
> It looks like it
Thanks for your quick fix.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gao, Zhichao
> Sent: Wednesday, September 25, 2019 8:09 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Wu, Hao A ; Ni,
> Ray ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH] MdeModulePkg/Termin
We have no such plan so far.
在 2019年9月25日，18:16，Sivaraman Nainar 写道：
Hello,
May we know when the RestEx driver will be available in EDK2 Master Branch.
https://github.com/tianocore/edk2-staging/tree/UEFI_Redfish/RedfishPkg/RestExDxe
-Siva
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You recei
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2219
Refer to
https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-appcursor
In normal mode, arrow key would send ESC [A through to ESC [D.
In application mode, arrow key would send ESC OA through to
ESC OD.
Cc: Jian J Wang
Cc:
Hello,
May we know when the RestEx driver will be available in EDK2 Master Branch.
https://github.com/tianocore/edk2-staging/tree/UEFI_Redfish/RedfishPkg/RestExDxe
Thanks,
Ramesh
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#48031):
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 14/15]
> KabylakeOpenBoa
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 15/15] Add GalagoPro3 bo
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 13/15]
> KabylakeOpenBoa
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 12/15] KabylakeOpenBoard
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 11/15] KabylakeOpenBoard
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 10/15]
> KabylakeOpenBoa
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 07/15] KabylakeOpenBoar
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 06/15] KabylakeOpenBoar
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 08/15]
> KabylakeOpenBo
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 04/15] KabylakeOpenBoar
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-platforms][PATCH V2 05/15] KabylakeOpenBoar
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-devel] [
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Wednesday, September 25, 2019 2:13 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Sinha, Ankit ;
> Jeremy Soller
> Subject: [edk2-devel] [
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2212
In binary model the same binary may have to support both
S3 enabled and disabled scenarios, however not all DXE
drivers linking PiDxeS3BootScriptLib can return error to
invoke library DESTRUCTOR for releasing resource.
To support this usage
Agree and I will correct the commit message to describe usage model better.
Thanks for good catch!
Regards,
Chasel
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Laszlo
> Ersek
> Sent: Wednesday, September 25, 2019 6:23 AM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc:
On 09/19/19 21:52, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> Protect the memory used by an SEV-ES guest when S3 is supported. This
> includes the page table used to break down the 2MB page that contains
> the GHCB so that it can be marked un-encrypted, as well as the GHCB
> area.
>
> Rega
Thanks for your input.
Due to a misconception of union casts (or accesses, really), multiple
points were rendered infeasible. I suppose the main point left I'd like
some attention towards is alignment, and of course the misdesigned
prototypes (CONST).
Comments inline.
Thanks and regards,
Marv
On 09/19/19 21:52, Lendacky, Thomas wrote:
> From: Tom Lendacky
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198
>
> A GHCB page is needed during the Sec phase, so this new page must be
> created. Since the GHCB must be marked as an un-encrypted, or shared,
> page, an additional page
65 matches
Mail list logo
