For users, who operate the machine remotely through serial console on some platforms, the test prompt message shown "System will shut down (or cold reset) after 1 second..." is misleading, as the reset may not be automatic.
This patch addresses the issue by adding a note "Note: On some platforms, you may have to manually turn on the System again after few seconds...". This fixes bug 1623. (https://bugzilla.tianocore.org/show_bug.cgi?id=1623) Signed-off-by: Supreeth Venkatesh <supreeth.venkat...@arm.com> --- .../BlackBoxTest/MiscRuntimeServicesBBTestFunction.c | 4 +++- .../BlackBoxTest/MiscRuntimeServicesBBTestStress.c | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c index 80e8297d..b4ebb806 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestFunction.c @@ -371,7 +371,9 @@ BBTestResetSystemManualTest ( // And the stall a second is required to make sure the recovery data has // been written into the storage device. // - SctPrint (L"System will shut down (or cold reset) after 1 second..."); + SctPrint (L"System may shut down (or cold reset) after 1 second..."); + SctPrint (L"Note: On some platforms, you may have to manually turn\ + on the System again after few seconds..."); gtBS->Stall (1000000); OldTpl = gtBS->RaiseTPL (TplArray[Index]); diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c index 1ad732a0..ef0e1148 100644 --- a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c +++ b/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/MiscRuntimeServices/BlackBoxTest/MiscRuntimeServicesBBTestStress.c @@ -374,7 +374,9 @@ BBTestResetSystemManualStressTest ( // // Print out some information to avoid the user thought it is an error // - SctPrint (L"System will shut down (or cold reset) after 1 second..."); + SctPrint (L"System may shut down (or cold reset) after 1 second..."); + SctPrint (L"Note: On some platforms, you may have to manually turn\ + on the System again after few seconds..."); gtBS->Stall (1000000); OldTpl = gtBS->RaiseTPL (TplArray[Index]); @@ -404,4 +406,4 @@ ManualStressTestStep2: } return EFI_SUCCESS; -} \ No newline at end of file +} -- 2.17.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48055): https://edk2.groups.io/g/devel/message/48055 Mute This Topic: https://groups.io/mt/34293481/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
