Reviewed-by: Chasel Chiu <chasel.c...@intel.com>
> -----Original Message----- > From: Kubacki, Michael A <michael.a.kuba...@intel.com> > Sent: Wednesday, September 25, 2019 2:13 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Sinha, Ankit <ankit.si...@intel.com>; > Jeremy Soller <jer...@system76.com> > Subject: [edk2-platforms][PATCH V2 11/15] KabylakeOpenBoardPkg: > Consolidate board IDs in a single file > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2207 > > Moves all Kaby Lake board ID definitions into a single header file so it is > easier to maintain the values and include the values into common package > files that need to make decisions based on board ID. > > Cc: Chasel Chiu <chasel.c...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Ankit Sinha <ankit.si...@intel.com> > Cc: Jeremy Soller <jer...@system76.com> > Signed-off-by: Michael Kubacki <michael.a.kuba...@intel.com> > --- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id.h > | 13 --------- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/Pei > GalagoPro3InitLib.h | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > | 29 ++++++++++++++++++++ > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp3I > d.h | 15 ---------- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiKabylakeRvp3InitLib.h | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eGalagoPro3AcpiTableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Dx > eMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Sm > mGalagoPro3AcpiEnableLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/Sm > mMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/Pei > MultiBoardInitPostMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/Pei > MultiBoardInitPreMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeKabylakeRvp3AcpiTableLib.c | 6 ++-- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c | 2 +- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmKabylakeRvp3AcpiEnableLib.c | 4 +-- > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiBoardInitPreMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c | 2 +- > 18 files changed, 47 insertions(+), 46 deletions(-) > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id. > h > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id. > h > deleted file mode 100644 > index d85a7dcf52..0000000000 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/GalagoPro3Id. > h > +++ /dev/null > @@ -1,13 +0,0 @@ > -/** @file > - > -Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef _GALAGO_PRO_3_ID_H_ > -#define _GALAGO_PRO_3_ID_H_ > - > -#define BoardIdGalagoPro3 0x20 > - > -#endif > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiGalagoPro3InitLib.h > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiGalagoPro3InitLib.h > index 81d99f7295..742b5f5e04 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiGalagoPro3InitLib.h > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi > +++ b/PeiGalagoPro3InitLib.h > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <PchHsioPtssTables.h> #include <IoExpander.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > extern const UINT8 mDqByteMapSklRvp3[2][6][2]; extern const UINT8 > mDqsMapCpu2DramSklRvp3[2][8]; diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > new file mode 100644 > index 0000000000..e83c56252d > --- /dev/null > +++ b/Platform/Intel/KabylakeOpenBoardPkg/Include/PlatformBoardId.h > @@ -0,0 +1,29 @@ > +/** @file > +Kaby Lake Platform Board Identifiers > + > + Copyright (c) 2019, Intel Corporation. All rights reserved.<BR> > + SPDX-License-Identifier: BSD-2-Clause-Patent **/ > + > +#ifndef _PLATFORM_BOARD_ID_H_ > +#define _PLATFORM_BOARD_ID_H_ > + > +#define FlavorUnknown 0x0 > +#define FlavorMobile 0x1 > +#define FlavorDesktop 0x2 > +#define FlavorWorkstation 0x3 > +#define FlavorUpServer 0x4 > +#define FlavorEmbedded 0x5 > +#define FlavorPlatformMax 0x6 > + > +#define TypeUnknown 0x0 > +#define TypeTrad 0x1 > +#define TypeUltUlx 0x2 > + > +#define BoardIdSkylakeRvp3 0x4 > +#define BoardIdGalagoPro3 0x20 > +#define BoardIdKabyLakeYLpddr3Rvp3 0x60 > + > +#define BoardIdUnknown1 0xffff > + > +#endif > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp > 3Id.h > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp > 3Id.h > deleted file mode 100644 > index 3b6397af1f..0000000000 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/KabylakeRvp > 3Id.h > +++ /dev/null > @@ -1,15 +0,0 @@ > -/** @file > - > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > -SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef _KABYLAKE_RVP3_ID_H_ > -#define _KABYLAKE_RVP3_ID_H_ > - > -// PUT SKL CRB BoardIds here > -#define BoardIdSkylakeRvp3 0x4 > -#define BoardIdKabyLakeYLpddr3Rvp3 0x60 > - > -#endif // _PEI_KABYLAKE_RVP3_BOARD_INIT_LIB_H_ > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiKabylakeRvp3InitLib.h > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiKabylakeRvp3InitLib.h > index bd60720137..5b2ccf6b0d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiKabylakeRvp3InitLib.h > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiKabylakeRvp3InitLib.h > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <PchHsioPtssTables.h> #include <IoExpander.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > extern const UINT8 mDqByteMapSklRvp3[2][6][2]; extern const UINT8 > mDqsMapCpu2DramSklRvp3[2][8]; diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > index 76a8da9cda..b9386d59b8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeGalagoPro3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeGalagoPro3AcpiTableLib.c > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/AslUpdateLib.h> #include <Protocol/GlobalNvsArea.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > GLOBAL_REMOVE_IF_UNREFERENCED EFI_GLOBAL_NVS_AREA_PROTOCOL > mGlobalNvsArea; > > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c > index 639524c7d0..42440b6b14 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > DxeMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/DxeMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmGalagoPro3AcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > SmmGalagoPro3AcpiEnableLib.c > index ee897e422a..265c00551a 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmGalagoPro3AcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/SmmGalagoPro3AcpiEnableLib.c > @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/ > SmmMultiBoardAcpiSupportLib.c > index c4c1e116c8..8eec028324 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLib/S > mmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardAcpiLi > +++ b/SmmMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c > index 5ddf04dece..2ef12ea399 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPostMemLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi > +++ b/PeiMultiBoardInitPostMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c > index 12e03b37cb..a21246444c 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLib/P > eiMultiBoardInitPreMemLib.c > +++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BoardInitLi > +++ b/PeiMultiBoardInitPreMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <GalagoPro3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeKabylakeRvp3AcpiTableLib.c > index e65742559a..154d859090 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeKabylakeRvp3AcpiTableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeKabylakeRvp3AcpiTableLib.c > @@ -1,7 +1,7 @@ > /** @file > Platform Hook Library instances > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -18,7 +18,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/AslUpdateLib.h> #include <Protocol/GlobalNvsArea.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > GLOBAL_REMOVE_IF_UNREFERENCED EFI_GLOBAL_NVS_AREA_PROTOCOL > mGlobalNvsArea; > > @@ -43,7 +43,7 @@ KabylakeRvp3UpdateGlobalNvs ( > mGlobalNvsArea.Area->PowerState = 1; // AC =1; for mobile platform, > will update this value in SmmPlatform.c > > mGlobalNvsArea.Area->NativePCIESupport = PcdGet8 > (PcdPciExpNative); > - > + > // > // Enable APIC > // > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/DxeMultiBoardAcpiSupportLib.c > index 4da685d0ac..0c78342a1d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /DxeMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/DxeMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmKabylakeRvp3AcpiEnableLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmKabylakeRvp3AcpiEnableLib.c > index 71c6e230fa..c9d0cda831 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmKabylakeRvp3AcpiEnableLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmKabylakeRvp3AcpiEnableLib.c > @@ -1,7 +1,7 @@ > /** @file > Platform Hook Library instances > > -Copyright (c) 2017, Intel Corporation. All rights reserved.<BR> > +Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent > > **/ > @@ -15,7 +15,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLi > b/SmmMultiBoardAcpiSupportLib.c > index 4a120e14eb..96eaf6e6e8 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpiLib > /SmmMultiBoardAcpiSupportLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardAcpi > +++ Lib/SmmMultiBoardAcpiSupportLib.c > @@ -16,7 +16,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiBoardInitPreMemLib.c > index 464f67e036..f1829c287d 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiBoardInitPreMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiBoardInitPreMemLib.c > @@ -12,7 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/BoardInitLib.h> #include <Library/PcdLib.h> #include > <Library/DebugLib.h> -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPostMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiMultiBoardInitPostMemLib.c > index cc800b552b..72cdeaa0b2 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPostMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiMultiBoardInitPostMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > diff --git > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPreMemLib.c > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib > /PeiMultiBoardInitPreMemLib.c > index 843ae9890c..3cf391c0bb 100644 > --- > a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInitLib/ > PeiMultiBoardInitPreMemLib.c > +++ > b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BoardInit > +++ Lib/PeiMultiBoardInitPreMemLib.c > @@ -14,7 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent #include > <Library/PcdLib.h> #include <Library/DebugLib.h> > > -#include <KabylakeRvp3Id.h> > +#include <PlatformBoardId.h> > > EFI_STATUS > EFIAPI > -- > 2.16.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48026): https://edk2.groups.io/g/devel/message/48026 Mute This Topic: https://groups.io/mt/34279350/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-