> -Original Message-
> From: Marcin Wojtas [mailto:m...@semihalf.com]
> Sent: Thursday, June 27, 2019 2:25 PM
> To: Albecki, Mateusz
> Cc: edk2-devel-groups-io; Wu, Hao A
> Subject: Re: [edk2-devel] [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe:
> Implement revision 3 of SdMmcOverrideProtocol
>
>
Hi Mateusz,
Can you please push those patches somewhere (github?) so that I can
easily do a quick check for regression?
Thanks,
Marcin
śr., 26 cze 2019 o 15:10 Albecki, Mateusz
napisał(a):
>
> To allow platform greater control over the bus settings for SD card and eMMC
> card we have added a n
Reviewed-By: Zailiang Sun
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42919): https://edk2.groups.io/g/devel/message/42919
Mute This Topic: https://groups.io/mt/32201140/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https
The commit will remove the deprecated edk2 SVN mirror at:
https://svn.code.sf.net/p/edk2/code/trunk/edk2
After this commit, the above minnor will not be synced with the changes
made in the GitHub upstream.
Cc: Liming Gao
Cc: Andrew Fish
Cc: Laszlo Ersek
Cc: Leif Lindholm
Cc: Michael D Kinney
The patch proposes to:
A. Remove the information on the SourceForge SVN mirror repository from
the Maintainers.txt file.
B. Stop the sync of the SourceForge SVN mirror from the upstream Github
Git repository. (At this moment, the SVN mirror is still syncing the
latest changes)
Cc: Liming
Hello:
I created a ticket for the CLANG build issue and attached the patch also.
Could you please review and comment on this
-Siva
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#42916): https://edk2.groups.io/g/devel/message/42916
Mute
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1944
--exclude cannot be used under certain circumstances
1.The value of the parameter USES an absolute path
2.The value of Exclude parameters is based on the value
of the Path parameter
Neither of these approaches currently works
This patch i
Except a minor comment in patch 2/2, the series looks good to me.
Hello Ard and Marcin, please let me know if you have comments on this
series.
If no other feedbacks, I plan to push the change at early next week.
Best Regards,
Hao Wu
> -Original Message-
> From: Albecki, Mateusz
> Sent
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Albecki, Mateusz
> Sent: Wednesday, June 26, 2019 9:10 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A
> Subject: [edk2-devel] [PATCH v4 1/2] MdeModulePkg/SdMmcOverride: Add
> GetO
One typo within SdCardSwitch():
if (Mode) {
if AccessMode & 0xF) != 0xF) && ((SwitchResp[16] & 0xF) != AccessMode)
||
...
(((PowerLimit & 0xF) != 0xF) && (((SwitchResp[15] >> 4) & 0xF) !=
PowerLimit {
return EFI_DEVICE_ERROR;
}
}
should be:
if (Mode)
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Wednesday, June 12, 2019 2:14 PM
> To: devel@edk2.groups.io
> Cc: Bret Barkelew ; Carsey, Jaben
> ; Ni, Ray ; Gao, Liming
> ; Sean Brogan ;
> Michael Tu
David,
I agree to expose *GetBootDescription() API.
But can you remove the 1st parameter Prefix and let caller to pre-pend it after
calling this API?
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> David Woodhouse
> Sent: Tuesday, June 25, 20
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855
UniTool is one python script to generate UQI (Universal Question
Identifier) unicode string for HII question PROMPT string.
UQI string can be used to identify each HII question.
The scripts function will sync up UQI definitions with uni files
Reviewed-by: Bob Feng
-Original Message-
From: Jin, Eric
Sent: Wednesday, June 26, 2019 2:03 PM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming ;
Kinney, Michael D
Subject: [PATCH V2] BaseTools/Capsule: Supports multiple payloads and drivers
in capsule
REF: https://bugzilla.t
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, June 25, 2019 9:44 AM
> To: Albecki, Mateusz; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe:
> Refactor UFS device presence detect
> -Original Message-
> From: Albecki, Mateusz
> Sent: Wednesday, June 26, 2019 5:55 PM
> To: Wu, Hao A; devel@edk2.groups.io
> Subject: RE: [PATCH v2] MdeModulePkg/UfsPassThruDxe: Fix unaligned data
> transfer handling
>
> Hi,
>
> No concerns from my side. I just didn't think ZeroMem woul
Thanks.
Pushed via commit c78008b4b2.
Best Regards,
Hao Wu
From: Ni, Ray [mailto:ray...@intel.com]
Sent: Tuesday, June 25, 2019 4:04 PM
To: Wu; Wu, Hao A; devel@edk2.groups.io
Subject: Re: [edk2-devel] [RFC][PATCH v1 0/1] PcAtChipsetPkg: Remove framework
modules
Reviewed-by: Ray Ni ray...@inte
Reviewed-by: Puja Pandya
-Original Message-
From: Desimone, Ashley E
Sent: Tuesday, June 25, 2019 11:05 AM
To: Desimone, Nathaniel L ; devel@edk2.groups.io
Cc: Pandya, Puja
Subject: RE: [PATCH] [staging/EdkRepo-Manifest]: Initial commit of manifests
for EdkRepo
Reviewed-by: Ashley DeS
Signed-off-by: Rebecca Cran
---
edksetup.sh | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/edksetup.sh b/edksetup.sh
index c7b2e1e201..61e988035f 100755
--- a/edksetup.sh
+++ b/edksetup.sh
@@ -108,27 +108,27 @@ function SetupEnv()
f
On 2019-06-25 22:46, Fan, ZhijuX wrote:
>
>
>
> Hi:
>
> Python3.6 and python3.7
>
> After the code removes some common values “python”, we compare “3.6”
> and “3.7”
>
> origin_version = “3.6”, python_version=”3.7”
>
>
>
> I'm going to change it to
>
> if [[ "$origin_version" < "$p
On 06/26/19 14:33, David Woodhouse wrote:
> On Wed, 2019-06-26 at 14:18 +0200, Laszlo Ersek wrote:
>>
>> Yes, it can be turned off. It is a common hiccup for new subscribers
>> (the groups.io default is broken). I think we meant to document it
>> somewhere (outside of the mailing list archive), and
Zhifu:
For new created UqiList.uni, please add the comments to describe this file is
generated by unitool. And, language is also required to be specified. Below is
the example of the file header for the new generated uni file.
//
// FILE auto-generated by UniTool
//
#langdef uqi "uqi"
Than
On 06/26/19 13:37, David Woodhouse wrote:
> For v3, leaving out the cosmetic parts that touch code outside OvmfPkg.
> This series is now purely the correctness fixes within OvmfPkg which are
> required to make CSM boots work properly again.
>
> The first two patches allow NVMe and VirtIO disks t
Laszlo,
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 26, 2019 8:46 PM
> To: devel@edk2.groups.io; Wang, Jian J ;
> dw...@infradead.org; Lu, XiaoyuX
> Cc: Ye, Ting ; Richard Levitte
> Subject: Re: [edk2
https://bugzilla.tianocore.org/show_bug.cgi?id=1882
The new notify phase allows platform to configure additional
bus paramters in addition to parameters that can already be configured
with capability override. Specifically we allow to configure bus width,
clock frequency and driver strength. If pl
From: "Albecki, Mateusz"
https://bugzilla.tianocore.org/show_bug.cgi?id=1882
Implement support for GetOperatingParamters notify phase
in SdMmcHcDxe driver. GetOperatingParameters notify phase
is signaled before we start card detection and initialization.
Code has been updated for both eMMC and S
To allow platform greater control over the bus settings for SD card and eMMC
card we have added a new notify phase to SdMmcOverrideProtocol called
GetOperatingParam.
This phase is signaled before SD card/eMMC initialization and allows platform
to tweak the values in new structure called EDKII_SD
Jian,
On 06/25/19 10:58, Wang, Jian J wrote:
> I take this as agreement. I pushed this patch at (fixed file ext)
>
> 51f7a3e6c5192d3f9a0fa63b0b5617c151180ad7
Please pay more attention to the process.
First, you pushed the patch, but the BZ (1881) is still open. You or
XiaoyuX should have close
On Wed, 2019-06-26 at 13:33 +0100, David Woodhouse wrote:
>
> Wow, this is just completely brain-damaged on so many levels. So people
> who do, and who don't, have that box checked will receive the same
> message with *different* Message-Id: headers?
>
> If one of them replies, the In-Reply-To: t
On Wed, 2019-06-26 at 14:18 +0200, Laszlo Ersek wrote:
>
> Yes, it can be turned off. It is a common hiccup for new subscribers
> (the groups.io default is broken). I think we meant to document it
> somewhere (outside of the mailing list archive), and I guess we may have
> even done so, but curren
On 06/26/19 13:43, David Woodhouse wrote:
> On Wed, 2019-06-26 at 12:37 +0100, David Woodhouse wrote:
>> For v3, leaving out the cosmetic parts that touch code outside OvmfPkg.
>> This series is now purely the correctness fixes within OvmfPkg which are
>> required to make CSM boots work properly
On Wed, 2019-06-26 at 12:37 +0100, David Woodhouse wrote:
> For v3, leaving out the cosmetic parts that touch code outside OvmfPkg.
> This series is now purely the correctness fixes within OvmfPkg which are
> required to make CSM boots work properly again.
>
> The first two patches allow NVMe an
For v3, leaving out the cosmetic parts that touch code outside OvmfPkg.
This series is now purely the correctness fixes within OvmfPkg which are
required to make CSM boots work properly again.
The first two patches allow NVMe and VirtIO disks to be used as Legacy
boot targets, since nobody reall
QemuVideoDxe installs its own legacy INT 10h handler for the benefit of
systems like Windows 2008r2 which attempt to use INT 10h even when booted
via EFI.
This interacts extremely badly with a CSM actually attempting to install
a real video BIOS.
The last thing done before invoking a legacy OpROM
Iterate over the available block devices in much the same way as
BdsLibEnumerateAllBootOption() does, but limiting to those devices
which are PCI-backed, which can be represented in the BbsTable.
One day we might need to extend the BbsTable to allow us to distinguish
between different NVMe namespa
Mostly, this is only necessary for devices that the CSM might have
native support for, such as VirtIO and NVMe; PciBusDxe will already
degrade devices to 32-bit if they have an OpROM.
However, there doesn't seem to be a generic way of requesting PciBusDxe
to downgrade specific devices.
There's In
This is hard-coded in the IntThunk structure, and the additional entries
will be needed for other devices like VirtIO and NVMe disks. So admit
that they exist.
Signed-off-by: David Woodhouse
Acked-by: Laszlo Ersek
---
OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 7 ---
1 file changed, 4 inserti
On Wed, 26 Jun 2019 at 11:35, Ooi, Tzy Way wrote:
>
> Hi Bieshuevel,
>
> You mentioned that "Are these discrete components? If so, I wonder we should
> use some kind of abstraction for the PHY operation". In our system, the MAC
> is only connected to this PHY, hence wonder if is it ok to still m
Hi Leif,
śr., 26 cze 2019 o 11:31 Leif Lindholm napisał(a):
>
> On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> > Ensure that in case of SlowMode or 3.3V operation,
> > also the HS400 capability will be disabled in the
> > SdMmc driver.
> >
> > Contributed-under: TianoCore Contri
Hi,
No concerns from my side. I just didn't think ZeroMem would be useful there
since buffer doesn't contain any data from device at that point so I didn't add
it.
Thanks,
Mateusz
> -Original Message-
> From: Wu, Hao A
> Sent: Wednesday, June 26, 2019 2:19 AM
> To: Albecki, Mateusz ; d
Hi Bieshuevel,
You mentioned that "Are these discrete components? If so, I wonder we should
use some kind of abstraction for the PHY operation". In our system, the MAC is
only connected to this PHY, hence wonder if is it ok to still maintain as it is
for now?
Also, may I know if you could expl
On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote:
> Ensure that in case of SlowMode or 3.3V operation,
> also the HS400 capability will be disabled in the
> SdMmc driver.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
Well done on keeping this tag. But I'm thinking we ne
On 06/26/19 03:55, Gary Lin wrote:
> On Tue, Jun 25, 2019 at 01:22:16PM +0200, Laszlo Ersek wrote:
>> On 06/25/19 10:50, Ard Biesheuvel wrote:
>>> On Mon, 24 Jun 2019 at 21:13, Laszlo Ersek wrote:
Port the [LibraryClasses], [PcdsFixedAtBuild] and [Components] settings
that are relat
Reviewed-by : Chao Zhang
From: Wang, Jian J
Sent: Wednesday, June 26, 2019 3:44 PM
To: Zhang, Chao B ; Yao, Jiewen ;
devel@edk2.groups.io
Cc: Hernandez Beltran, Jorge ; Han, Harry
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
Thanks, Chao. You're right your way is better. I'll u
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, June 25, 2019 2:54 PM
> To: Gao, Zhichao; devel@edk2.groups.io
> Cc: Wang, Jian J; Ni, Ray; Zeng, Star
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Add
>
Sorry, I think I've already added.
+ } else {
+
+DEBUG ((DEBUG_ERROR, "ERROR: No/invalid StoredHashFvPpi located\r\n"));
+
+ASSERT_EFI_ERROR (Status);
+ASSERT (StoredHashFvPpi != NULL && StoredHashFvPpi->FvNumber > 0);
+
+Status = EFI_NOT_FOUND;
+ }
Regards,
Jian
> -Origin
Thanks, Chao. You're right your way is better. I'll update it.
Regards,
Jian
From: Zhang, Chao B
Sent: Wednesday, June 26, 2019 3:29 PM
To: Wang, Jian J ; Yao, Jiewen ;
devel@edk2.groups.io
Cc: Hernandez Beltran, Jorge ; Han, Harry
Subject: RE: [PATCH v4 0/3] Common OBB verification feature
H
Hi Jian:
Patch is good to me. Just one comment for coding style
If (AlgInfo->HashAll (FvBuffer, (UINTN)FvInfo[FvIndex].Length, FvHashValue) ==
FALSE)
Is it better to be if (!AlgInfo->HashAll (FvBuffer,
(UINTN)FvInfo[FvIndex].Length, FvHashValue) ) ?
From: Wang, Jian J
Sent: Wednesday, Ju
Reviewed-by: Liming Gao
>-Original Message-
>From: Fan, ZhijuX
>Sent: Wednesday, June 26, 2019 12:50 PM
>To: devel@edk2.groups.io
>Cc: Gao, Liming ; Feng, Bob C
>; rebe...@bluestop.org
>Subject: [PATCH V2] BaseTools:Linux changes the way the latest version is
>judged
>
>Some Linux servers
Reviewed-by: Liming Gao
Please remove V2 in the commit message.
>-Original Message-
>From: Zhang, Shenglei
>Sent: Wednesday, June 26, 2019 11:37 AM
>To: devel@edk2.groups.io
>Cc: Feng, Bob C ; Gao, Liming
>Subject: [edk2-platform patch v2] Silicon/Tools: Add top level Makefile and
>GNU
Ensure that in case of SlowMode or 3.3V operation,
also the HS400 capability will be disabled in the
SdMmc driver.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h | 1 +
Silicon/Marvell/Drivers/S
51 matches
Mail list logo
