Re: Please use Add*VarCache and not Get* when reading pref values in any even possibly warm code paths

2017-02-23 Thread Masayuki Nakano
f the pref needs to be read just once, store the value in some static variable or so. -Olli ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform -- Masayuki Nakano Software Enginee

Intent to remove UIEvent.isChar

2017-03-14 Thread Masayuki Nakano
bugzilla.mozilla.org/show_bug.cgi?id=1347073 -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Is Alt+Shift+F10 a good shortcut key to open context menu forcibly on Windows and Linux?

2017-03-14 Thread Masayuki Nakano
your idea. The bug is bug 1347079: https://bugzilla.mozilla.org/show_bug.cgi?id=1347079 Thanks in advance. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to change editor newline behavior

2017-04-04 Thread Masayuki Nakano
ression reports after reaching risky patch to the release especially when it's limited to non-English users. So, in this case, I think we'd get regression reports of web apps which is used in world wide. Otherwise, we wouldn't get regression reports until releasing the

Intent to unship: MozPhonetic.phonetic (HTMLInputElement.phonetic) and nsIPhonetic

2017-05-09 Thread Masayuki Nakano
EditorBase and HTMLInputElement. https://searchfox.org/mozilla-central/rev/224cc663d54085994a4871ef464b7662e0721e83/dom/html/nsIPhonetic.idl Nobody (including add-ons) uses them now. So, we can get rid of them. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1363278 -- Masayuki Nakano Software

Intent to unship: nsIEditorIMESupport

2017-05-09 Thread Masayuki Nakano
nsIEditorIMESupport is an empty interface. Members were moved to nsIEditor and nsIEditorIMESupport was made a subclass of it. This interface is now completely unused. So, it should be removed from the tree completely. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1325281 -- Masayuki

Re: Using references vs. pointers in C++ code

2017-05-09 Thread Masayuki Nakano
I like using reference to argument if it's non-nullable. In Core::Editor module, such arguments are already replaced with reference in a lot of places. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-pla

Re: Using the accesskey attribute with HTML elements in browser chrome

2017-06-20 Thread Masayuki Nakano
I have no idea how to implement it easily in HTML. Perhaps, capsuling with Shadow DOM? -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to ship: Changing default Japanese fonts to modern fonts

2017-08-22 Thread Masayuki Nakano
"Meiryo" isn't available. Anyway, I believe that this makes 57 look nicer for Japanese users! [1] https://bugzilla.mozilla.org/show_bug.cgi?id=548311 [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1354004 [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1351332 [4] https://bugzilla.mo

You don't need to use nsIEditor, nsIPlaintextEditor and nsIHTMLEditor in most places of native code

2017-08-22 Thread Masayuki Nakano
or nsIHTMLEditor, you need to QI to nsIEditor first. So, if you need to add new scriptable method which treat editor, using nsIEditor is better than other editor interfaces since QI cost is not so cheap. [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1060051 -- Masayuki Nakan

Re: Intent to ship: Changing default Japanese fonts to modern fonts

2017-08-23 Thread Masayuki Nakano
47 AM, ISHIKAWA,chiaki wrote: Hi, I use firefox under Windows most of the time, and so it will be very nice. But obviously this is only for Windows platform, and does not affect linux or OSX versions. Correct? On 2017/08/23 14:19, Masayuki Nakano wrote: Hi, We decided that we should change our d

Re: Reminder on Try usage and infrastructure resources

2017-09-15 Thread Masayuki Nakano
o use `mach try` with a specific set of test directories. It will generate a set of --try-test-paths flags to restrict tests to those paths, and only run the first chunk of any group. Without that, groups shift around too much to be reliable. On Fri, Sep 15, 2017 at 10:03:00AM +0900, Masayuki N

Re: Reminder on Try usage and infrastructure resources

2017-09-15 Thread Masayuki Nakano
en I end up running all the mochitest-browser tests, looking at every log until I find the chunk where the test is, and retrigger just that chunk. The chunk number changes based on the platform and debug/opt, so it's painful. Is there a way to trigger only the chunk that will contain a given tes

How to get pretty stack trace on Linux?

2017-09-21 Thread Masayuki Nakano
n to check which path causes a bug. If it's impossible, I'll create a tryserver build with each ancestor caller logs the path, though. Thanks in advance. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platfo

Re: How to get pretty stack trace on Linux?

2017-10-13 Thread Masayuki Nakano
tryserver build from terminal. 7. Save stack trace to a text file. 8. Run |/tools/rb/fix_linux_stack.py < stack.txt| Thank you very much! On 9/22/2017 9:55 AM, Ted Mielczarek wrote: On Thu, Sep 21, 2017, at 08:51 PM, Masayuki Nakano wrote: I'd like to get pretty stack trance which shows

Re: How to get pretty stack trace on Linux?

2017-10-13 Thread Masayuki Nakano
On 10/14/2017 12:29 AM, Masayuki Nakano wrote: Ted, really sorry for the delay to say "Thank you" because of too busy of my life. I tried to do this on my environment (Ubuntu), then, I succeeded to get a pretty stack trace even from trysever build. 1. Put |#include "nsTrac

Intent to ship: New default action, horizontal scroll, of wheel with Shift key (except Firefox for macOS)

2017-10-17 Thread Masayuki Nakano
Note that this feature won't be exposed to attributes of "wheel" events. This is just a default action change and same behavior as Chrome. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lis

Re: Intent to ship: New default action, horizontal scroll, of wheel with Shift key (except Firefox for macOS)

2017-10-18 Thread Masayuki Nakano
On 10/18/2017 4:08 PM, Jet Villegas wrote: That is, do I owe you another steak? :-) Always welcome another steak :-D -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https

Intent to remove: some methods of nsIEditActionListener or the interface itself

2018-01-12 Thread Masayuki Nakano
id=1429676 And currently, I'm working on making HTMLEditRules not derived from nsIEditActionListener: https://bugzilla.mozilla.org/show_bug.cgi?id=1430021 And nsIEditActionListener::Will*() will be removed because of no users: https://bugzilla.mozilla.org/show_bug.cgi?id=1430319 -- Masayuki N

Please stop using keypress event to handle non-printable keys

2018-01-17 Thread Masayuki Nakano
ow_bug.cgi?id=968056 2: https://w3c.github.io/uievents/#legacy-keyboardevent-event-types -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to remove: nsIDOMWindowUtils.sendKeyEvent() and nsIFrameLoader.sendCrossProcessKeyEvent()

2018-01-31 Thread Masayuki Nakano
5f8ab/testing/mochitest/tests/SimpleTest/EventUtils.js#835-905 *4 https://bugzilla.mozilla.org/show_bug.cgi?id=553149 *5 https://bugzilla.mozilla.org/show_bug.cgi?id=1433648 *6 https://bugzilla.mozilla.org/show_bug.cgi?id=1434317 -- Masayuki Nakano Software Engineer, Mozilla

Intent to enable as default paragraph separator of contenteditable/designMode editor by default

2018-02-13 Thread Masayuki Nakano
with inserting this line: document.execCommand("defaultParagraphSeparator", false, "br"); -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to enable as default paragraph separator of contenteditable/designMode editor by default

2018-02-16 Thread Masayuki Nakano
/docs/Web/Guide/HTML/Editable_content#Differences_in_markup_generation -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to ship: setting keyCode value of punctuation keys (if US keyboard layout) to non-zero

2018-02-21 Thread Masayuki Nakano
ug to change this behavior: https://bugzilla.mozilla.org/show_bug.cgi?id=1036008 Document in MSDN: https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/keyCode#keyCode_of_punctuation_keys_on_some_keyboard_layout -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to stop dispatching "keypress" event for non-printable keys and key combinations in Nightly and early Beta

2018-02-27 Thread Masayuki Nakano
argument. However, I couldn't fix new oranges with this approach. So, it works with some condition, but I don't know about this. So, I'll keep struggling with regressions of this behavior change. However, probably, we won't get regression reports for minor UI, e.g., runn

Intent to ship: Start to dispatch "keydown" and "keyup" events even if composing (only in Nightly and early Beta)

2018-03-19 Thread Masayuki Nakano
h purpose, "input" event is the right event because "keydown" event and "keyup" event may not be fired even after the bug fix. For example, if the IME is backend of voice input or handwriting system, Gecko won't fire "keydown&quo

Intent to unship: nsIEditor.numberOfUntoItems and nsIEditor.numberOfRedoItems

2018-03-27 Thread Masayuki Nakano
l to nsIEditor.transactionManager.numberOfUntoItems and nsIEditor.transactionManager.numberOfRedoItems. So, we don't need to keep maintaining these shortcut methods anymore. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list de

Intent to unship: nsIClipboardDragDropHooks and nsIClipboardDragDropHookList interfaces

2018-03-27 Thread Masayuki Nakano
t used by anybody (it seems that it was used by ChatZilla, but according to its website, it's not active) and this causes a lot of unnecessary virtual calls and QI at D&D and Paste in editor. So, I don't think that we should keep this feature anymore. -- Masayuki Nakano So

Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-04-05 Thread Masayuki Nakano
bility issue in: https://bugzilla.mozilla.org/show_bug.cgi?id=1449564 -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-04-09 Thread Masayuki Nakano
toolbars. Then, you'll see grabber to move the black border box at top edge of the box and you can move the box with dragging. That's one of the feature of absolutely positioned editor available even on Firefox. -- Masayuki Nakano Software Engineer, Mozilla ___

Are there some lists of web sites which use vertical writing-mode?

2018-04-09 Thread Masayuki Nakano
sually read web sites written in Japanese... -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-04-09 Thread Masayuki Nakano
ral or just remove them completely. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-04-09 Thread Masayuki Nakano
On 4/7/2018 12:39 AM, Ehsan Akhgari wrote: On Thu, Apr 5, 2018 at 11:08 PM Masayuki Nakano <mailto:masay...@d-toybox.com>> wrote: On 4/6/2018 2:50 AM, Ehsan Akhgari wrote: > Hi Masayuki, > > First of all, thank you for taking on this task.  I have a

Re: Are there some lists of web sites which use vertical writing-mode?

2018-04-10 Thread Masayuki Nakano
On 4/10/2018 4:40 PM, Brian Birtles wrote: On Fri, Apr 6, 2018 at 10:26 AM, Masayuki Nakano wrote: Does somebody know some lists of web sites which use vertical writing-mode? Unfortunately, I don't know web sites which use writing-mode heavily even though I usually read web sites writt

Re: Are there some lists of web sites which use vertical writing-mode?

2018-04-10 Thread Masayuki Nakano
On 4/10/2018 5:53 PM, Karl Dubost wrote: Masayuki, Le 6 avr. 2018 à 17:26, Masayuki Nakano a écrit : Does somebody know some lists of web sites which use vertical writing-mode? Kobo Taiwan for example has preview of books in vertical writing mode. see https://webcompat.com/issues/14152

Re: Are there some lists of web sites which use vertical writing-mode?

2018-04-10 Thread Masayuki Nakano
ally. This is interesting case. This is not what we're looking for, but this is a case of web developers trying to fix the issue by themselves. I.e., they must be thinking that horizontal scroll isn't useful even if the block direction is completely horizontal. -- Masayuki Nakano S

Re: Are there some lists of web sites which use vertical writing-mode?

2018-04-11 Thread Masayuki Nakano
On 4/11/2018 4:34 PM, Karl Dubost wrote: Le 11 avr. 2018 à 15:14, Masayuki Nakano a écrit : However, oddly, I cannot show the preview on Firefox nor Nightly. When I click the "preview", the website says "saved the preview" but I cannot access the preview actually. It mi

Intent to ship: New AltGr key behavior on Windows

2018-06-04 Thread Masayuki Nakano
tensions shouldn't use Control - Alt combination for shortcut keys at least on Windows. Note that if active keyboard layout does not have AltGr key, getModifierState("AltGraph") always returns false (even if both Ctrl and Alt are pressed). The bug: https://bugzill

Intent to drop TSF (Text Services Framework) support on WinXP and WinServer 2003

2015-09-17 Thread Masayuki Nakano
hile to support limited support of TSF on legacy Windows. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Stepping down as the module owner of editor/

2015-10-22 Thread Masayuki Nakano
lp you. I am planning to finish my outstanding code reviews by the end of this month. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: sendKeyEvent doesn't support event.key

2015-10-28 Thread Masayuki Nakano
faces/base/nsITextInputProcessor.idl ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform -- Masayuki Nakano Manager, Internationalization, Mozilla

Why do we still need to include Qt widget in mozilla-central?

2016-04-11 Thread Masayuki Nakano
on of keeping it in mozilla-central? -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Why do we still need to include Qt widget in mozilla-central?

2016-04-12 Thread Masayuki Nakano
On 2016/04/12 20:27, Henri Sivonen wrote: On Tue, Apr 12, 2016 at 7:45 AM, Masayuki Nakano wrote: So, my question is, why do we still have Qt widget in mozilla-central? What the reason of keeping it in mozilla-central? My understanding is that https://git.merproject.org/mer-core/qtmozembed

Re: Intent to drop TSF (Text Services Framework) support on WinXP and WinServer 2003

2016-05-20 Thread Masayuki Nakano
Done. Will be in 49. On 2015/09/17 18:40, Masayuki Nakano wrote: Summary: Drop TSF support only from WinXP and WinServer 2003. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1205600 Platforms: Windows XP, Windows Server 2003 and Windows Server 2003 R2 Estimated or target release: Gecko 44

Bug 1260651 will rename whole classes under editor/libeditor, so, when you need to touch in it, let me know before landing

2016-06-24 Thread Masayuki Nakano
ow, let me know. Smaug might be a good reviewer for that. Thanks in advance. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Bug 1260651 will rename whole classes under editor/libeditor, so, when you need to touch in it, let me know before landing

2016-07-09 Thread Masayuki Nakano
::WSRunObject::WSFragment nsWSRunObject::WSPointmozilla::WSRunObject::WSPoint nsEditor::CreateTxnForIMEText() mozilla::EditorBase::CreateTxnForComposiiton() -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list

Re: Added --disable-e10s to mach run

2016-07-18 Thread Masayuki Nakano
rm mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

What's a good variable name for ErrorResult?

2016-10-25 Thread Masayuki Nakano
v;|. Anyway, I'd like we to add a rule to the coding style guide. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to remove: nsIHTMLEditor.setDocumentTitle()

2016-10-26 Thread Masayuki Nakano
/show_bug.cgi?id=1312991 Note that I don't want to do them in 52 because 52 will be the next ESR. So, I'd like to do them in 53. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platfor

Who loves multiple selection feature in editor?

2016-12-15 Thread Masayuki Nakano
be better to stop supporting multiple selection only in editor if the feature is not so loved by users. I filed a bug for discussing this issue here: https://bugzilla.mozilla.org/show_bug.cgi?id=1323681 Feel free to comment anything. Thanks in advance. -- Masayuki Nakano Manager, Internatio

Do we have some documents listing up when we need to touch CLOBBER?

2016-12-16 Thread Masayuki Nakano
Hi, I'm looking for some documents which explain when we need to touch CLOBBER to avoid build failure. However, I've not found such document yet. I see such information only in CLOBBER about WebIDL change. So, is there any document which lists up when we need to touch CLOBBER? -

Intent to unship: BeforeAftereKeyboardEvent

2016-12-16 Thread Masayuki Nakano
boardEvent#Dispatch_KeyboardEvent_across_BrowserElements [3] https://bugzilla.mozilla.org/show_bug.cgi?id=1322736 -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.m

Re: Do we have some documents listing up when we need to touch CLOBBER?

2016-12-16 Thread Masayuki Nakano
could be interesting. On Fri, Dec 16, 2016 at 12:16 AM, Masayuki Nakano wrote: Hi, I'm looking for some documents which explain when we need to touch CLOBBER to avoid build failure. However, I've not found such document yet. I see such information only in CLOBBER about WebIDL change. S

Re: Do we have some documents listing up when we need to touch CLOBBER?

2016-12-16 Thread Masayuki Nakano
On 2016/12/16 19:53, Mike Hommey wrote: On Fri, Dec 16, 2016 at 05:16:25PM +0900, Masayuki Nakano wrote: Hi, I'm looking for some documents which explain when we need to touch CLOBBER to avoid build failure. However, I've not found such document yet. I see such information only

Re: Who loves multiple selection feature in editor?

2016-12-19 Thread Masayuki Nakano
T, SELECTION_IME_CONVERTEDTEXT, SELECTION_IME_SELECTEDCONVERTEDTEXT and SELECTION_FIND. So, perhaps, you don't need to mind about such feature. (Although, I don't know which selection type is used in location bar.) -- Masayuki Nakano Mana

Re: Who loves multiple selection feature in editor?

2016-12-19 Thread Masayuki Nakano
On 2016/12/20 8:00, Mats Palmgren wrote: On 12/15/2016 10:46 AM, Masayuki Nakano wrote: > Supporting multiple selection in editor makes our editor code > complicated. Why is that so exactly? By necessity, the code already operates on one Range, right? so why can't we implemen

Re: Who loves multiple selection feature in editor?

2016-12-19 Thread Masayuki Nakano
ng all selection ranges, but the ranges may be changed/removed during handling other selection ranges. We don't have any spec how do we behave in such case. I think we should probably ask other browser vendors about this again so that we can plan our future here better. I agree. -- M

Re: Removing support for OS/2

2013-08-06 Thread Masayuki Nakano
dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform -- Masayuki Nakano Mana

nsGUIEvent.h related stuff has been sorted out

2013-10-23 Thread Masayuki Nakano
t +- WidgetMouseEventBase +- WidgetMouseEvent +- WidgetDragEvent If an instance is WidgetDragEvent, AsGUIEvent(), AsInputEvent(), AsMouseEventBase(), AsMouseEvent() and AsDragEvent() returns its pointer. The other As*Event() methods return nullptr.

Re: nsGUIEvent.h related stuff has been sorted out

2013-10-25 Thread Masayuki Nakano
h code even only one, the change would cause regression. Although, I don't think that it causes problem when it checks only the most derived class. Therefore, I think that creating Is*EventClass() methods which *cannot* be used in switch statement is better for such

Re: nsGUIEvent.h related stuff has been sorted out

2013-10-28 Thread Masayuki Nakano
| for downcasts to most-derived event types, and dynamic_cast for downcasts to non-most-derived event types. Masayuki Nakano: Please use As*Event() in case #1 and #2. As you said, we can use static_cast since there is eventStructType. However, it's NOT safe because we *might* take mistakes. Act

Please handle non-printable keys with keydown event handler instead of keypress event handler

2014-02-04 Thread Masayuki Nakano
mark it as blocking bug 968056. Of course, if you fix the new bugs filed for #2, it helps me very much. But it's very helpful to me if you just file bugs for #2. Thanks in advance. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan.

Re: Please handle non-printable keys with keydown event handler instead of keypress event handler

2014-02-05 Thread Masayuki Nakano
s no problem on cross-browser script. If there is a problem, it must be like this: > if (navigator.userAgent.indexOf("Firefox") > 0) { > // handling non-printable keys with keypress event handler > } I cannot say there is no such web sites, however, I guess (and hope)

[Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-12 Thread Masayuki Nakano
vent. If we use mozilla::dom namespace for DOM event classes, DOM prefix may be redundant. However, DOM prefix is clearer if its users use "using namespace mozilla::dom;". Any ideas? -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-21 Thread Masayuki Nakano
Hi, On 2014/02/12 23:22, Boris Zbarsky wrote: On 2/12/14 4:46 AM, Masayuki Nakano wrote: I'm not sure which is the best name for the classes. E.g., DOMWheelEvent vs. PointerEvent. I believe in this case PointerEvent is correct, because http://www.w3.org/TR/pointerevents/#pointer

VK_ENTER has gone

2014-02-21 Thread Masayuki Nakano
g on bug 969247. Thanks in advance. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-21 Thread Masayuki Nakano
', 40 'PointerEvent.h', 41 'Touch.h', 42 ] Now, they are exported as mozilla/dom/*.h. -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: [Proposal] Move global namespace classes under dom/events to mozilla or mozilla::dom

2014-02-26 Thread Masayuki Nakano
es about DOM implementation. 3. Or, all of them should be in "mozilla::dom". Any ideas? # I like #1 because it's clear rule and non-nsDOM* classes use classes which are defined in other modules (i.e., not in mozilla::dom namespace). -- Masayuki Nakano Manager, Internati

Guidelines for naming preferences?

2014-06-19 Thread Masayuki Nakano
For preventing these unfortunate things, we should define good guidelines about pref names. # Anyway, if it's allowed, we should rename the pref names referred from nxXPLookAndFeel even though customized users will need to set them again. Thanks in advance. --

Re: Guidelines for naming preferences?

2014-06-30 Thread Masayuki Nakano
Thank you for the reply, but sorry for the delay. On 2014/06/20 23:25, Benjamin Smedberg wrote: On 6/19/2014 10:00 PM, Masayuki Nakano wrote: When I work on some bugs, I need to add a new option for a pref switchable behavior, e.g., if we need to add a new option to a feature and the new one

Re: Guidelines for naming preferences?

2014-06-30 Thread Masayuki Nakano
Hi, I wrote a draft of the guideline in MDN roughly. I hope a lot of developers discuss the rules and improve this draft! Thanks in advance. On 2014/06/30 16:24, Masayuki Nakano wrote: Thank you for the reply, but sorry for the delay. On 2014/06/20 23:25, Benjamin Smedberg wrote: On 6/19

Re: Guidelines for naming preferences?

2014-06-30 Thread Masayuki Nakano
On 2014/06/30 22:51, Masayuki Nakano wrote: Hi, I wrote a draft of the guideline in MDN roughly. I hope a lot of developers discuss the rules and improve this draft! Oops, the draft is here. Sorry for the spam. https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Preferences

Intent to ship: KeyboardEvent.code attribute

2015-01-27 Thread Masayuki Nakano
efault in release build: https://bugzilla.mozilla.org/show_bug.cgi?id=1126673 -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to Implement and Ship: UI Events (formerly DOM Level 3 Events) EventModifierInit

2015-04-08 Thread Masayuki Nakano
to implement: Support D3E EventModifierInit https://bugzilla.mozilla.org/show_bug.cgi?id=1124608 Link to standard: https://dvcs.w3.org/hg/dom3events/raw-file/tip/html/DOM3-Events.html#h-event-modifier-initializers -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to Implement and Ship: UI Events (formerly DOM Level 3 Events) EventModifierInit

2015-04-09 Thread Masayuki Nakano
t. (of course, mochitest has them, though) -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to deprecate: nsIDOMWindowUtils.sendKeyEvent()

2015-04-13 Thread Masayuki Nakano
134542 for the progress. https://bugzilla.mozilla.org/show_bug.cgi?id=1134542 -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to ship: Enabling TSF mode in release builds (Vista or later)

2015-04-14 Thread Masayuki Nakano
reported, we should disable it before release. The bug to turn on: https://bugzilla.mozilla.org/show_bug.cgi?id=478029 -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https

Intent to change UA stylesheet of and (using border-bottom -> CSS 3 text-decoration)

2015-04-22 Thread Masayuki Nakano
as our current style. IE doesn't have any special style for them (i.e., rendered like simple ). The bug to change the style: https://bugzilla.mozilla.org/show_bug.cgi?id=1157083 -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. __

Re: Replacing PR_LOG levels

2015-05-22 Thread Masayuki Nakano
Error, Warning, Debug, }; -- Masayuki Nakano Manager, Internationalization, Mozilla Japan. ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to disable (hide) Gecko specific editing UI of HTML editor by default

2018-08-16 Thread Masayuki Nakano
gzilla.mozilla.org/show_bug.cgi?id=1452538#c19 On 2018/04/05 15:58, Masayuki Nakano wrote: This incompatibility is pointed by W3C's Editing API WG: https://github.com/w3c/editing/issues/171 Gecko has some specific editing UI of HTML editor. 1. Resiziers of , , absolute positioned elements.

Intent to unship "namedanchor" keyword from nsIHTMLEditor.createElementWithDefaults(), nsIHTMLEditor.getSelectedElement() and nsIHTMLEditor.getElementOrParentByTagName()

2018-08-16 Thread Masayuki Nakano
;anchor" is used in comm-central and BlueGriffon. Due to not defined as an Atom, it does not make sense to keep supporting this value. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1484092 The first release of this change will be 63. -- Masayuki Naka

Intent to (re-)enable new keyCode/charCode values of keypress events in Nightly

2018-11-06 Thread Masayuki Nakano
regression about key operation in some web apps, please file a bug for each web app, and block bug 1479964. 1: https://bugzilla.mozilla.org/show_bug.cgi?id=218415 2: https://bugzilla.mozilla.org/show_bug.cgi?id=1479964 3: https://bugzilla.mozilla.org/show_bug.cgi?id=1497546 4: https://bugzilla.m

Intent to unship: DOM "text" event

2018-11-26 Thread Masayuki Nakano
ely later. Note that this event is listened by only 0.0003% inner-windows for now (currently, we collect the data only from Nightly testers). -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to ship: dispatching "keydown" and "keyup" events during IME composition

2018-11-29 Thread Masayuki Nakano
ress event changes which will be mentioned in following posts. Enabling patch has been landed from: https://bugzilla.mozilla.org/show_bug.cgi?id=1496288 because we need to manage those changes as a set. -- Masayuki Nakano Software Engineer, Mozilla _

Intent to ship: stop dispatching "keypress" events when pressed key (key combination) does not introduce text input

2018-11-29 Thread Masayuki Nakano
s) to disable this new behavior only in specific domains. If we'll get broken web apps even after release, we and users can disable it with using this blacklist. Enabling patch has been landed from: https://bugzilla.mozilla.org/show_bug.cgi?id=1496288 because we need to manage those ch

Intent to ship: set keyCode or charCode of "keypress" event to the other's non-zero value

2018-11-29 Thread Masayuki Nakano
org/show_bug.cgi?id=1496288 because we need to manage those changes as a set. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Intent to ship: window.event

2018-11-29 Thread Masayuki Nakano
m/forum/#!topic/mozilla.dev.platform/E8DyIJBhu1g https://groups.google.com/forum/#!topic/mozilla.dev.platform/IWLLJmoGroA -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to ship: stop dispatching "keypress" events when pressed key (key combination) does not introduce text input

2018-12-03 Thread Masayuki Nakano
vent of text input from keyboard directly (i.e., not via IME). "input" and "beforeinput" are similar to "keypress", but they are fired only when an editor has focus and with any input devices/middle wares. Currently, I'm working on implementing "beforeinput&qu

Re: Intent to ship: set keyCode or charCode of "keypress" event to the other's non-zero value

2018-12-03 Thread Masayuki Nakano
On 2018/11/30 20:42, James Graham wrote: On 30/11/2018 01:37, Masayuki Nakano wrote: web-platform-tests: N/A due to requiring user input, but we have mochitests with synthesized events. I think it should be possible to write web-platform-tests for this kind of thing now, using the testdriver

Intent to ship: InputEvent.inputType (with Input Events Level 1)

2018-12-13 Thread Masayuki Nakano
to Level 2 support with pref, "dom_input_events.conform_to_level_1", although could be changed in review process). -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Intent to ship: window.event

2019-01-17 Thread Masayuki Nakano
We've decided to put this off at least 66. https://bugzilla.mozilla.org/show_bug.cgi?id=1520756 On 2018/11/30 10:47, Masayuki Nakano wrote: Summary: Enable window.event which can access dispatching event from everywhere. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=218415 Li

Re: Intent to ship: set keyCode or charCode of "keypress" event to the other's non-zero value

2019-01-17 Thread Masayuki Nakano
We've decided to put this off at least 66. https://bugzilla.mozilla.org/show_bug.cgi?id=1520756 On 2018/11/30 10:37, Masayuki Nakano wrote: Summary: We'll set keyCode of "keypress" event to its charCode value if keyCode is 0, charCode of "keypress" event to its k

Intent to put off to ship: Event.returnValue

2019-01-17 Thread Masayuki Nakano
fix broke another internet app (bug 1514940). Therefore, we put off to reship this at least until 66. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev

Re: Moving reviews to Phabricator

2019-02-06 Thread Masayuki Nakano
have been set as blocker bugs to https://bugzil.la/1514775. -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Moving reviews to Phabricator

2019-02-07 Thread Masayuki Nakano
- brennie On Wed, Feb 6, 2019 at 7:27 PM Masayuki Nakano wrote: I sometimes rewrite patches from new contributor and commit them with `-u` and the contributors name and email address, and land the patches for them. E.g., https://bugzil.la/1513405 Is it possible to do that via Phabricator and Lan

Intent to implement and ship: InputEvent.data and InputEvent.dataTransfer

2019-02-10 Thread Masayuki Nakano
ll file bugs for them. Currently, I plan to enable them by default in all channels like InputEvent.inputType. If we would get web-compat issues, e.g., they are used to detect "beforeinput" event support, then, I'd disable them in a follow up bug. -- Masayuki Nakano Software Eng

Each piece of PresShell::HandleEvent() and PresShell::HandleEventInternal() was spun out to each method of PresShell::EventHandler class

2019-03-14 Thread Masayuki Nakano
/PresShell.cpp#7190-7586 3. https://searchfox.org/mozilla-central/rev/8ff2cd0a27e3764d9540abdc5a66b2fb1e4e9644/layout/base/PresShell.h#499-1261 -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https

Stop including nsIPresShell.h, include mozilla/PresShell.h instead

2019-04-03 Thread Masayuki Nakano
g the result. I'll keep changing other GetPresShell() methods too when I have time, but of course, you're welcome if you do that instead of me ;-) Regards, -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing li

Re: Core : Spell checker ownership

2019-04-11 Thread Masayuki Nakano
s.mozilla.org/listinfo/dev-platform -- Masayuki Nakano Software Engineer, Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: Patching FF 52.9esr with v60+ Security updates possible?

2019-04-12 Thread Masayuki Nakano
tform -- Masayuki Nakano Working on DOM, Events, editor and IME handling at Mozilla ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

  1   2   >