Re: Intent to ship: window.event

2019-01-17 Thread Masayuki Nakano
We've decided to put this off at least 66. https://bugzilla.mozilla.org/show_bug.cgi?id=1520756 On 2018/11/30 10:47, Masayuki Nakano wrote: Summary: Enable window.event which can access dispatching event from everywhere. Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=218415 Link to standar

Re: Intent to ship: set keyCode or charCode of "keypress" event to the other's non-zero value

2019-01-17 Thread Masayuki Nakano
We've decided to put this off at least 66. https://bugzilla.mozilla.org/show_bug.cgi?id=1520756 On 2018/11/30 10:37, Masayuki Nakano wrote: Summary: We'll set keyCode of "keypress" event to its charCode value if keyCode is 0, charCode of "keypress" event to its keyCode value if charCode is 0.

Intent to put off to ship: Event.returnValue

2019-01-17 Thread Masayuki Nakano
Event.returnValue is legacy attribute which was introduced by IE. We released this feature at 63, but it broke an internet application (bug 1478102). Therefore, we unshipped it temporarily at 64 because the fix of bug 1479964 will fix the intranet application. However, unfortunately, the fix

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-17 Thread jmaher
Following up on this, thanks to Chris we have fast artifact builds for PGO, so the time to develop and use try server is in parity with current opt solutions for many cases (front end development, most bisection cases). I have also looked in depth at what the impact on the integration branches

Crash-stop integrated by default for crash reports in Bugzilla

2019-01-17 Thread Calixte Denizet
Hi, A few months ago, we published the first version of the crash-stop addon [1]. The goal was to integrate crash data along with some analysis (ex: startup crashes) directly into Bugzilla. The goal is to help with bug prioritization and make it easier to determine if a patch has fixed the issue a

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-17 Thread James Graham
On 17/01/2019 16:42, jmaher wrote: Following up on this, thanks to Chris we have fast artifact builds for PGO, so the time to develop and use try server is in parity with current opt solutions for many cases (front end development, most bisection cases). Even as someone not making frequent ch

Re: Crash-stop integrated by default for crash reports in Bugzilla

2019-01-17 Thread Andrew Overholt
That looks like it could be incredibly useful! Thanks for pointing it out and for doing the work. On Thu, Jan 17, 2019 at 11:50 AM Calixte Denizet wrote: > Hi, > > A few months ago, we published the first version of the crash-stop addon > [1]. The goal was to integrate crash data along with some

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-17 Thread Jan de Mooij
Hi Joel, Can you say more about this point in your original email: "3) This will reduce the jobs (about 16%) we run which in turn reduces, cpu time, money spent, turnaround time, intermittents, complexity of the taskgraph." It seems to me that if we remove non-PGO opt builds even on Try, we might

[IMPORTANT] QA Firefox 67 feature testing pi-requests deadline is January 23

2019-01-17 Thread Tom Grabowski
Hi, Similar to what QA did for previous Firefox feature testing prioritization , we would like to do the same for Fx67. In order to help with the process, *please submit your pi-request

Intent to Implement and Ship: The border-{start,end}-{start,end}-radius CSS properties

2019-01-17 Thread Mats Palmgren
Summary: The border-{start,end}-{start,end}-radius CSS properties are flow-relative versions of their corresponding physical property, border-top-left-radius etc Bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1520684 Link to standard: https://drafts.csswg.org/css-logical-1/#border-radius-prop

DataMutex

2019-01-17 Thread Jeff Muizelaar
DataMutex is a Rust style Mutex that's templated on the type of data that it's locking. We've had an implementation of this in EME for a while but it hasn't been used more widely. I've moved DataMutex from EME to xpcom/threads to encourage it's use. Generally, one should prefer to use a DataMutex

[Bugzilla Change] "Mac OS X" deprecated, "macOS" added

2019-01-17 Thread Emma Humphries
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1520927, we've disabled Mac OS X as an OS choice. This doesn't affect existing bugs marked with Mac OS X. New bugs on Mac desktop should select "macOS". Please update your saved searches accordingly. -- Emma __

Re: Proposal to adjust our clang-format rules to include spaces after the hash for nested preprocessor directives

2019-01-17 Thread Ehsan Akhgari
I've received some on and off-list responses to this, all in favour. I've filed https://bugzilla.mozilla.org/show_bug.cgi?id=1521000 to make the change. Thanks to everyone who provided feedback. On Thu, Jan 10, 2019 at 8:01 PM Ehsan Akhgari wrote: > Hi everyone, > > I'd like to propose the fir