Re: Improvement to build times through cleanup of C++ include dependencies

Hello, Le 15/12/2020 à 10:36, Gabriele Svelto a écrit : Thanks for this work Simon, this is awesome! There's also plenty of side effects to this that will make life better for developers, just a few off the top of my mind: - All our static analysis passes need to go through the preprocessed s

Re: Improvement to build times through cleanup of C++ include dependencies

Hi Chris, I am not 100% sure if that's feasible with a near-zero rate of false positives, but it definitely seems worth trying out. I filed https://bugzilla.mozilla.org/show_bug.cgi?id=1682477 to address this. Simon On Mon, Dec 14, 2020 at 8:00 PM Chris Peterson wrote: > On 12/14/2020 3:23 AM,

Re: Improvement to build times through cleanup of C++ include dependencies

Thanks for this work Simon, this is awesome! There's also plenty of side effects to this that will make life better for developers, just a few off the top of my mind: - When sccache is in use files are preprocessed before being sent to sccache, so even when hitting the cache we pay the price of r

Re: Improvement to build times through cleanup of C++ include dependencies

Due to the noisy nature of build times it might be too early to tell. Here's the telemetry dashboard for build: https://sql.telemetry.mozilla.org/dashboard/build?p_date=d_last_60_days (sorry - Mozilla employees only). Mike Conley wrote on 15/12/20 12:18 am: Thank you so much for investing ti

Re: Improvement to build times through cleanup of C++ include dependencies

On 12/14/2020 3:23 AM, Simon Giesecke wrote: I was using some tools to support this, notably ClangBuildAnalyzer [2] and include-what-you-use [3]. ClangBuildAnalyzer helped to detect headers that are expensive to parse throughout the build, and direct efforts to reduce those specifically. But ther

Re: Improvement to build times through cleanup of C++ include dependencies

Thank you so much for investing time and effort into this area! Improvements to build times are always always welcome. I seem to recall we collect opt-in Telemetry on things like build times. If so, have we noticed any changes in those graphs? -Mike On Mon, 14 Dec 2020 at 11:11, Botond Ballo wr

Re: Improvement to build times through cleanup of C++ include dependencies

Hey Simon, Thanks a lot for working on this! It's hard to notice the effect of individual changes in this area, but in aggregate they can add up to a significant build speed improvement. Botond On Mon, Dec 14, 2020 at 6:23 AM Simon Giesecke wrote: > > tl;dr Build times on all platforms, in par

Improvement to build times through cleanup of C++ include dependencies

tl;dr Build times on all platforms, in particular for incremental builds, have decreased in the last weeks by landing several cleanups to C++ include dependencies that reduce the aggregated number of included files by about 30%. Hi, Did you notice a reduction in build times lately? This might no