[GitHub] incubator-zeppelin pull request: Documentation for setting Azure n...

2016-05-24 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/902#issuecomment-221197566 thanks for review! @AhyoungRyu then do we need to add link [here](https://github.com/apache/incubator-zeppelin/blob/master/docs/_includes/themes

[GitHub] incubator-zeppelin pull request: ZeppelinHub notebook storage/conn...

2016-05-24 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/880#issuecomment-221485915 @AhyoungRyu @astroshim @bzz thanks for review! the comments have been addressed --- If your project is set up for it, you can reply to this email

[GitHub] incubator-zeppelin pull request: Documentation for setting Azure n...

2016-05-27 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/902#issuecomment-222083200 @bzz rebased from master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZeppelinHub notebook storage/conn...

2016-05-27 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/880#issuecomment-222116385 @bzz rebased from master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] incubator-zeppelin pull request: ZeppelinHub notebook storage/conn...

2016-05-27 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/880#issuecomment-222117802 /cc @Leemoonsoo @anthonycorbacho to test/review --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] incubator-zeppelin pull request: ZEPPELIN-928: fix flaky ZeppelinIT test for...

2016-05-31 Thread khalidhuseynov
Github user khalidhuseynov commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/939 thanks for fixing this flaky test, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] incubator-zeppelin issue #947: [ZEPPELIN-939] Improve notebook authorization...

2016-06-07 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/incubator-zeppelin/pull/947 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin pull request #998: Update api/pass auth info to repo

2016-06-10 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/998 Update api/pass auth info to repo ### What is this PR for? This PR is to make available information on the currently authenticated user(subject) in the Notebook storage level. It can

[GitHub] zeppelin issue #996: [ZEPPELIN-890] Cache downloaded file from 'maven-downlo...

2016-06-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/996 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1007: Update and refactor NotebookRepo versioning API

2016-06-13 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1007 Update and refactor NotebookRepo versioning API ### What is this PR for? This is firstly to refactor API for versioning and keep everthing inside of one interface (NotebookRepo

[GitHub] zeppelin issue #1006: [MINOR] Small ui modification in notebook actionbar

2016-06-13 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1006 thanks for fixing this UI issues! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin issue #998: Authenticated user aware notebook storage layer

2016-06-14 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/998 somehow selenium tests keep error with ``` Tests in error: ParagraphActionsIT.testRemoveButton:145->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWa

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

2016-06-14 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1007 ready for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

2016-06-14 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1007 the reason is quite simple, that's to have only one interface to be implemented (instead of choosing from two, given that documentation doesn't mention `NotebookRepoVersion

[GitHub] zeppelin pull request #1007: Update and refactor NotebookRepo versioning API

2016-06-14 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1007: Update and refactor NotebookRepo versioning API

2016-06-14 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1007 Update and refactor NotebookRepo versioning API ### What is this PR for? This is firstly to refactor API for versioning and keep everthing inside of one interface (NotebookRepo

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

2016-06-15 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1007 yeah, I agree that having two interfaces is more elegant, but let's see some more detailed downsides. if you see [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengin

[GitHub] zeppelin issue #1007: Update and refactor NotebookRepo versioning API

2016-06-16 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1007 @bzz thanks for the review, I'll be glad to hear for the elegant solutions of the mentioned issues, even can help with implementation :) --- If your project is set up for it, yo

[GitHub] zeppelin issue #998: Authenticated user aware notebook storage layer

2016-06-17 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/998 rebased from master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin pull request #1041: Get note revision of note - git repo

2016-06-17 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1041 Get note revision of note - git repo ### What is this PR for? This PR implements the backend of git storage layer for `get(noteId, revision)`, so that you can get the note of certain

[GitHub] zeppelin issue #1048: [ZEPPELIN-1033] HotFixing of paragraph deletion and re...

2016-06-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1048 I checked it, and behavior with paragraph reordering fixed. So basically, previously shiro was initialized only when needed from `shiro.ini`, and now it's initialized always when sta

[GitHub] zeppelin issue #1041: Get note revision of note - git repo

2016-06-21 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1041 rebased from master --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

2016-06-22 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1013 I've just went through the conversation here, and i think that having `userName` instead of `connected` status in authenticated mode with additional `logout` menu is quite misle

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

2016-06-22 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1013 @minahlee thanks for quick mockup! looks good and as @corneadoug said we can omit `anonymous` when no one logged in, and only show username if authentication is enabled. One more thing is

[GitHub] zeppelin issue #1070: [HOTFIX] Fix compile error caused by merging #1043

2016-06-22 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1070 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1013: [ZEPPELIN-1002] Move configuration menus under dropdow...

2016-06-23 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1013 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1105: [ZEPPELIN-385] Notebook offline view mode

2016-06-28 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1105 [ZEPPELIN-385] Notebook offline view mode ### What is this PR for? This PR is to address so called `offline view` (view only + offline mode) mode. In this mode you open notebook in

[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode

2016-07-02 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1105 @r-kamath that's good point, but that differs according to use cases (also as a workaround, possible to set those before switching to `offline link`). from point of view having `of

[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...

2016-07-04 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1123 [Zeppelin - 1104] ZeppelinHub storage max note size to 64Mb ### What is this PR for? This is to increase default note (text message) size used in ZeppelinHub storage layer from 64Kb

[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...

2016-07-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1123 I get the following failure which is unrelated ``` Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.486 sec <<< FAIL

[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...

2016-07-04 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1123: [Zeppelin - 1104] ZeppelinHub storage max note ...

2016-07-04 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1123 [Zeppelin - 1104] ZeppelinHub storage max note size to 64Mb ### What is this PR for? This is to increase default note (text message) size used in ZeppelinHub storage layer from 64Kb

[GitHub] zeppelin issue #1119: [DOC] Zeppelin 0.6.0 release note

2016-07-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1119 LGTM! #880 was missing the issue, so i fixed it under https://issues.apache.org/jira/browse/ZEPPELIN-. I believe it's new feature as well, and could be included in release

[GitHub] zeppelin issue #1128: [HOTFIX] NPE when there's no properties field in inter...

2016-07-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1128 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...

2016-07-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1123 @bzz actually i checked, but couldn't find anything with similar content (stacktrace, or tag?). please let me know if it's existing, otherwise i could create one. --- If your

[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...

2016-07-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1123 @bzz you're right, the latest build was failing because of no header in `zeppelin-examples/zeppelin-example-horizontalbar/src/main/resources/example/app/horizont

[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...

2016-07-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1123 CI is green, and i think it's better to be included in 0.6 branch as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1123: [Zeppelin - 1104] ZeppelinHub storage max note size to...

2016-07-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1123 @bzz done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] zeppelin pull request #1160: WIP [Zeppelin - 1152] Listing note revision his...

2016-07-11 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1160 WIP [Zeppelin - 1152] Listing note revision history ### What is this PR for? This PR addresses ability to view the history of note revisions from the `version control` menu

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-13 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 @corneadoug thanks for the help with rendering list, and i've fixed the tests. CI is green and ready for review. --- If your project is set up for it, you can reply to this email and

[GitHub] zeppelin issue #1164: ZEPPELIN-1115: Python - interpreter for SQL over DataF...

2016-07-13 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1164 Thanks for the improvement, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin pull request #1183: [Zeppelin - 1174] Cleanup unused methods in rep...

2016-07-13 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1183 [Zeppelin - 1174] Cleanup unused methods in repo layer ### What is this PR for? This is to cleanup some unused print methods from repository layer ### What type of PR is it

[GitHub] zeppelin pull request #1183: [Zeppelin - 1174] Cleanup unused methods in rep...

2016-07-14 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1183 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1183: [Zeppelin - 1174] Cleanup unused methods in rep...

2016-07-14 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1183 [Zeppelin - 1174] Cleanup unused methods in repo layer ### What is this PR for? This is to cleanup some unused print methods from repository layer ### What type of PR is it

[GitHub] zeppelin pull request #1192: Versioning/get note revision api

2016-07-15 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1192 Versioning/get note revision api ### What is this PR for? Adds websocket api for getting note revision. ### What type of PR is it? Improvement | Feature ### Todos

[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api

2016-07-18 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1192 @bzz fixed the issue with CI. regarding change in api, you're right. it's better not to change api as a part of different PR, so I reverted it back. The main point i

[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api

2016-07-18 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1192 [ZEPPELIN-1189] Get note revision websocket api ### What is this PR for? Adds websocket api for getting note revision. ### What type of PR is it? Improvement | Feature

[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api

2016-07-18 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1192: [ZEPPELIN-1189] Get note revision websocket api

2016-07-18 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1192 @bzz addressed the changes and CI is green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 @Leemoonsoo updated code and screenshot with feedback --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] zeppelin pull request #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1160 [Zeppelin - 1152] Listing note revision history ### What is this PR for? This PR addresses ability to view the history of note revisions from the `version control` menu

[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api

2016-07-19 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1192 [ZEPPELIN-1189] Get note revision websocket api ### What is this PR for? Adds websocket api for getting note revision. ### What type of PR is it? Improvement | Feature

[GitHub] zeppelin pull request #1192: [ZEPPELIN-1189] Get note revision websocket api

2016-07-19 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 @corneadoug i'm not sure exactly what you mean, could you provide an example? @anthonycorbacho because: * there're cases when backend will send the list triggered by

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 @corneadoug yeah i changed the order since it's more intuitive to have name first, and date afterwards. But you're right when too long name, the ellipse doesn't look good. h

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-19 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 okay, i'll play with it a bit then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 @corneadoug @Leemoonsoo @anthonycorbacho how about this one? https://cloud.githubusercontent.com/assets/1642088/16978793/c2873624-4e98-11e6-910c-27977cb3ed98.png";> ---

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 @corneadoug how about this one 614ed61ab1b47bd5276d64d477983b605a25f6b8 : https://cloud.githubusercontent.com/assets/1642088/16980145/82ffe7f6-4e9f-11e6-95ca-8c8202bae1be.png

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1173 build failed on `zeppelin-web`, which is not relevant. can we still re-trigger CI here? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] zeppelin pull request #1160: [Zeppelin - 1152] Listing note revision history

2016-07-20 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1160 [Zeppelin - 1152] Listing note revision history ### What is this PR for? This PR addresses ability to view the history of note revisions from the `version control` menu

[GitHub] zeppelin pull request #1160: [Zeppelin - 1152] Listing note revision history

2016-07-20 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1160: [Zeppelin - 1152] Listing note revision history

2016-07-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1160 addressed comments and CI is green. /cc @corneadoug @Leemoonsoo @bzz for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-20 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1173 It looks good. one thing is that it should be documented as well so that others may implement their own authentication/authorization realms with their server. do you want to add it as a

[GitHub] zeppelin issue #1173: [ZEPPELIN-1164] ZeppelinHub Realm

2016-07-21 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1173 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1226: Fix logger class name to correct one

2016-07-25 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1226 Fix logger class name to correct one ### What is this PR for? This is to fix logger source class name for correct logs. ### What type of PR is it? Bug Fix

[GitHub] zeppelin pull request #1226: Fix logger class name to correct one

2016-07-30 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin pull request #1226: Fix logger class name to correct one

2016-07-30 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1226 Fix logger class name to correct one ### What is this PR for? This is to fix logger source class name for correct logs. ### What type of PR is it? Bug Fix

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-07-31 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1254 [ZEPPELIN-1257] storage - fix get note revision api ### What is this PR for? Getting revision of note requires only unique revision id and the whole revision object isn't req

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-07-31 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1254 /cc @corneadoug @bzz for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-07-31 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1254 @bzz CI failure was due to test, fixed now. Further, regarding the flexibility and narrowing scope. Revision class is implemented [here](https://github.com/apache/zeppelin/blob

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-08-01 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1254 [ZEPPELIN-1257] storage - fix get note revision api ### What is this PR for? Getting revision of note requires only unique revision id and the whole revision object isn't req

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-08-01 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-01 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1254 @bzz regarding the CI issue, I keep getting the following: ``` 14:05:27,226 ERROR org.apache.zeppelin.interpreter.remote.RemoteInterpreter:237 - Failed to create interpreter

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

2016-08-02 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1231 @onkarshedge thanks for this contribution. as i can see, the design issue on passing `BittorrentNotebookRepo` to `TorrentSocket` was solved by passing through constructor. also better have

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-02 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1254 @bzz i believe we decided not to merge it for now. I'll revise it and let you know --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] zeppelin issue #1231: [Zeppelin - 683][WIP] BittorrentNotebookRepo

2016-08-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1231 @onkarshedge conf object can be obtained on the fly from current configurations by `ZeppelinConfiguration.create()`. However, as you mentioned, all repository storages are currently being

[GitHub] zeppelin pull request #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-03 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1277 [ZEPPELIN-1257] Decouple revision id handling ### What is this PR for? This PR is to decouple Revision from RevisionId and let users to provide their own RevisionId class as a generic

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-08-03 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1254 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-03 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1277 @bzz this is different approach to the problems you mentioned in #1254. Here i decouple Revision from RevisionId class and make the latter one generic so that developers can provide their

[GitHub] zeppelin issue #1286: [ZEPPELIN-1294] Implement one-way sync for notebook re...

2016-08-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1286 @jasonxh as you mentioned it makes sense in cases when you control your primary storage by yourself and want your secondary storage be exactly the reflection of it. may need to add some

[GitHub] zeppelin issue #1286: [ZEPPELIN-1294] Implement one-way sync for notebook re...

2016-08-05 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1286 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] zeppelin pull request #1293: [ZEPPELIN- 1298] Log instead of throwing trace ...

2016-08-06 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1293 [ZEPPELIN- 1298] Log instead of throwing trace for ping messages ### What is this PR for? When non authenticated user in non-anonymous mode tries to send any websocket api message it

[GitHub] zeppelin pull request #1293: [ZEPPELIN- 1298] Log instead of throwing trace ...

2016-08-06 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1293 [ZEPPELIN- 1298] Log instead of throwing trace for ping messages ### What is this PR for? When non authenticated user in non-anonymous mode tries to send any websocket api message

[GitHub] zeppelin pull request #1293: [ZEPPELIN- 1298] Log instead of throwing trace ...

2016-08-06 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1293: [ZEPPELIN- 1298] Log instead of throwing trace for pin...

2016-08-06 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1293 @Leemoonsoo thanks for review. i addressed your comments by changing all the invalid cases to log in debug mode instead of throwing exception. let me know if there's something else

[GitHub] zeppelin issue #1293: [ZEPPELIN- 1298] Log instead of throwing trace for pin...

2016-08-08 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1293 @minahlee done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] zeppelin issue #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1277 @bzz giving some context 1. this is not about whole `NotebookRepo` api, it's related to only one method [here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src

[GitHub] zeppelin pull request #1308: [ZEPPELIN-1312] Hotfix - consistent getNoteRevi...

2016-08-09 Thread khalidhuseynov
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1308 [ZEPPELIN-1312] Hotfix - consistent getNoteRevision in websocket call ### What is this PR for? This pr fixes inconsistency on websocket call of getNoteRevision method on frontend

[GitHub] zeppelin issue #1308: [ZEPPELIN-1312] Hotfix - consistent getNoteRevision in...

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1308 /cc @corneadoug @bzz for review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] zeppelin issue #1308: [ZEPPELIN-1312] Hotfix - consistent getNoteRevision in...

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1308 @bzz added fix version to issue. merging into master sounds good --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug thanks for taking care of this! #1308 is merged and instead of `RevisionId` just send `Revision`. rebase should solve the problems. --- If your project is set up for it, you

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-09 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug thanks for clarification. in this case, how do you think it would look like if `revisionId` cannot be represented as simple string and it's more like complex o

[GitHub] zeppelin pull request #1105: [ZEPPELIN-385] Notebook offline view mode

2016-08-10 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1105: [ZEPPELIN-385] Notebook offline view mode

2016-08-10 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1105 @bzz thanks for ping, i'm closing it for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision

2016-08-11 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @bzz exactly, that's the point i was trying to make in #1254. @anthonycorbacho i'm completely agree with you, and that was the original starting premise. I'm happ

[GitHub] zeppelin pull request #1254: [ZEPPELIN-1257] storage - fix get note revision...

2016-08-11 Thread khalidhuseynov
GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/1254 [ZEPPELIN-1257] storage - fix get note revision api ### What is this PR for? Getting revision of note requires only unique revision id and the whole revision object isn't req

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-12 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1254 @bzz rebased and addressed comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] zeppelin pull request #1277: [ZEPPELIN-1257] Decouple revision id handling

2016-08-12 Thread khalidhuseynov
Github user khalidhuseynov closed the pull request at: https://github.com/apache/zeppelin/pull/1277 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] zeppelin issue #1254: [ZEPPELIN-1257] storage - fix get note revision api

2016-08-15 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1254 ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

  1   2   3   4   5   >