Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1254
  
    @bzz CI failure was due to test, fixed now.
    
    Further, regarding the flexibility and narrowing scope. Revision class is 
implemented 
[here](https://github.com/apache/zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/repo/NotebookRepo.java#L106)
 and as you can see currently when implementing your own NotebookRepo you reuse 
same class (without implementing your own one). Implementing your own revision 
class is a good idea which is not supported yet (it should be handled properly 
in frontend as well). 
    
    The point of this PR was not to send unnecessary info in the Revision 
object since only thing to identify the revision is supposed to be its 
revisionId and it being String seems at least intuitive since noteId, and 
paragraphId are identified in the same way by String id. So having noteId, 
revisionId should uniquely identify the revision. Can you give some example of 
ID that's more than one element and not presented as string?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to