GitHub user khalidhuseynov opened a pull request:

    https://github.com/apache/zeppelin/pull/1041

    Get note revision of note - git repo

    ### What is this PR for?
    This PR implements the backend of git storage layer for `get(noteId, 
revision)`, so that you can get the note of certain revision. It doesn't 
provide frontend api yet, which is future work.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - implement `get` of GitNotebookRepo
    * [ ] - add tests
    
    
    ### What is the Jira issue?
    N/A
    
    ### How should this be tested?
    two tests for `get` function should pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/khalidhuseynov/incubator-zeppelin 
feat/git-get-note-revision-of-note

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1041.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1041
    
----
commit c91dff08c255efd69b9fde5068c36b7a3ad74dd2
Author: Khalid Huseynov <khalid...@nflabs.com>
Date:   2016-06-16T23:53:58Z

    change field name: revId -> id

commit 01d16463048fb65551e716af2da540d109347f1f
Author: Khalid Huseynov <khalid...@nflabs.com>
Date:   2016-06-16T23:55:07Z

    basic impl of get specific version of note

commit d71b4036069422a70bdd2242b7bf3755182d7bd6
Author: Khalid Huseynov <khalid...@nflabs.com>
Date:   2016-06-17T00:23:32Z

    add edge case fail test

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to