[GitHub] [zeppelin] asfgit closed pull request #4076: [ZEPPELIN-5284]. savepoint & checkpoint don't work in flink 1.12

asfgit closed pull request #4076: URL: https://github.com/apache/zeppelin/pull/4076 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] asfgit closed pull request #4058: [ZEPPELIN-5257] Refactoring of ExecutionContext

asfgit closed pull request #4058: URL: https://github.com/apache/zeppelin/pull/4058 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [zeppelin] Teo920127 commented on pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Teo920127 commented on pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#issuecomment-802489730 In Kubernetes, would it be possible to use customized interpreter image for particular interpreters ? -- This is an automated message from the Apache Git Service. To respo

[GitHub] [zeppelin] Teo920127 edited a comment on pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Teo920127 edited a comment on pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#issuecomment-802489730 In Kubernetes, Can interpreters of the same type (such as Python) be configured to enable different images? -- This is an automated message from the Apache Git Servi

[GitHub] [zeppelin] Reamer commented on pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#issuecomment-802608364 > In Kubernetes, Can interpreters of the same type (such as Python) be configured to enable different images? At the moment, this is not possible. For a discussion, see h

[GitHub] [zeppelin] Reamer commented on pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#issuecomment-806743948 The infrastructure tests have been passed. I would like to merge this into Master. I think we can also merge this into branch-0.9 as it doesn't break anything. What is your opin

[GitHub] [zeppelin] cuspymd commented on a change in pull request #3947: [ZEPPELIN-5066] Notebook creation fails in Zeppelin 0.9 with namespace collision

cuspymd commented on a change in pull request #3947: URL: https://github.com/apache/zeppelin/pull/3947#discussion_r601994732 ## File path: zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java ## @@ -359,6 +359,19 @@ public void unicastParagraph(Note

[GitHub] [zeppelin] zjffdu commented on pull request #4079: [ZEPPELIN-5288]. Add rest api to reload note

zjffdu commented on pull request #4079: URL: https://github.com/apache/zeppelin/pull/4079#issuecomment-807916684 @cuspymd You are right, thanks for your review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

zjffdu commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602051890 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java ## @@ -557,4 +563,58 @@ public void update

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

zjffdu commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602051890 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java ## @@ -557,4 +563,58 @@ public void update

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602089778 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java ## @@ -557,4 +563,58 @@ public void update

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

cuspymd commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602090937 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,140 @@ +/* + * Li

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602096654 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,140 @@ +/* + * Lic

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

zjffdu commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602102340 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java ## @@ -557,4 +563,58 @@ public void update

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602111388 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java ## @@ -557,4 +563,58 @@ public void update

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602129604 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,140 @@ +/* + * Lic

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

zjffdu commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602144305 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java ## @@ -557,4 +563,58 @@ public void update

[GitHub] [zeppelin] zjffdu opened a new pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already fails

zjffdu opened a new pull request #4080: URL: https://github.com/apache/zeppelin/pull/4080 ### What is this PR for? This PR is to exist the waitForReady method earlier when process launcher is failed. Currently it would only exit when launch timeout. ### What type of PR is

[GitHub] [zeppelin] zjffdu opened a new pull request #4081: [ZEPPELIN-5299]. Comment at end of query causes query to be ignored

zjffdu opened a new pull request #4081: URL: https://github.com/apache/zeppelin/pull/4081 ### What is this PR for? This is to fix the corner case that when the comment is at the end of query, the query will be skipped due to bug in SqlSplitter. This PR fix the bug in SqlSplitter a

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4080: [ZEPPELIN-5300] Paragraph pending until timeout when process launcher has already fails

cuspymd commented on a change in pull request #4080: URL: https://github.com/apache/zeppelin/pull/4080#discussion_r602709246 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/remote/ExecRemoteInterpreterProcess.java ## @@ -175,6 +177,7 @@ public void

[GitHub] [zeppelin] zjffdu commented on pull request #4077: [ZEPPELIN-5273] Support Spark 3.1.1

zjffdu commented on pull request #4077: URL: https://github.com/apache/zeppelin/pull/4077#issuecomment-808723651 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] Reamer commented on pull request #4077: [ZEPPELIN-5273] Support Spark 3.1.1

Reamer commented on pull request #4077: URL: https://github.com/apache/zeppelin/pull/4077#issuecomment-809162672 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] Leemoonsoo commented on pull request #4077: [ZEPPELIN-5273] Support Spark 3.1.1

Leemoonsoo commented on pull request #4077: URL: https://github.com/apache/zeppelin/pull/4077#issuecomment-809400582 Thank @Reamer and @zjffdu for the review and guide this PR. I'm merging this one to master. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [zeppelin] asfgit closed pull request #4077: [ZEPPELIN-5273] Support Spark 3.1.1

asfgit closed pull request #4077: URL: https://github.com/apache/zeppelin/pull/4077 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] eljur commented on pull request #3712: [ZEPPELIN-4721]Fix the ConcurrentModificationException occured when connect presto via JDBC generic interpreter

eljur commented on pull request #3712: URL: https://github.com/apache/zeppelin/pull/3712#issuecomment-809625313 I just tried preview2, it throws NoClassDefFoundError for hive interpreter and does not fix presto one. Is it expected? -- This is an automated message from the Apache Git Serv

[GitHub] [zeppelin] zjffdu commented on pull request #3712: [ZEPPELIN-4721]Fix the ConcurrentModificationException occured when connect presto via JDBC generic interpreter

zjffdu commented on pull request #3712: URL: https://github.com/apache/zeppelin/pull/3712#issuecomment-809853017 @eljur Your issue should not related with this PR, you can try 0.9.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

cuspymd commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r603758497 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,148 @@ +/* + * Li

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r603865473 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,148 @@ +/* + * Lic

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r603876767 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,148 @@ +/* + * Lic

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

cuspymd commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r603921780 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -0,0 +1,148 @@ +/* + * Li

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

cuspymd commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r603933999 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -51,22 +50,21 @@ public R

[GitHub] [zeppelin] Reamer commented on a change in pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on a change in pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#discussion_r603963761 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterDownloader.java ## @@ -51,22 +50,21 @@ public Re

[GitHub] [zeppelin] Reamer opened a new pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plug-ins in our CI infrastructure

Reamer opened a new pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082 ### What is this PR for? Activates the tests for all Zeppelin plug-ins in our CI infrastructure ### What type of PR is it? - Bug Fix ### What is the Jira issue? * https://issues.

[GitHub] [zeppelin] cuspymd commented on pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

cuspymd commented on pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082#issuecomment-810734456 I have one question. Some tests sometimes cause errors, why is this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [zeppelin] Reamer edited a comment on pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

Reamer edited a comment on pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082#issuecomment-810852869 > have one question. Some tests sometimes cause errors, why is this? At the moment we have a CI problem. I have informed the other devs via our [mailing list](htt

[GitHub] [zeppelin] Reamer commented on pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

Reamer commented on pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082#issuecomment-810852869 At the moment we have a CI problem. I have informed the other devs via our [mailing list](https://lists.apache.org/thread.html/r7555a8a39a493ef3588d7000e450fd7801affac14b970b8f8

[GitHub] [zeppelin] cuspymd commented on pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

cuspymd commented on pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082#issuecomment-810933409 > At the moment we have a CI problem. I have informed the other devs via our [mailing list](https://lists.apache.org/thread.html/r7555a8a39a493ef3588d7000e450fd7801affac14b

[GitHub] [zeppelin] zjffdu opened a new pull request #4083: [ZEPPELIN-5307] Ignore the single quote and double quote in sql comment

zjffdu opened a new pull request #4083: URL: https://github.com/apache/zeppelin/pull/4083 ### What is this PR for? This PR is to fix the bug of SqlSplitter when single/double quote in sql comment. UT is added. ### What type of PR is it? [Bug Fix] ### Todos * [ ]

[GitHub] [zeppelin] zjffdu opened a new pull request #4084: [ZEPPELIN-5296]. NPE when calling completion for %spark.sql

zjffdu opened a new pull request #4084: URL: https://github.com/apache/zeppelin/pull/4084 ### What is this PR for? Trivial PR to fix NPE in Spark interpreter when calling code completion. ### What type of PR is it? [Bug Fix ### Todos * [ ] - Task ### What

[GitHub] [zeppelin] zjffdu commented on pull request #4081: [ZEPPELIN-5299]. Comment at end of query causes query to be ignored

zjffdu commented on pull request #4081: URL: https://github.com/apache/zeppelin/pull/4081#issuecomment-812278438 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu opened a new pull request #4085: [ZEPPELIN-5255] Exported note name should included the note id

zjffdu opened a new pull request #4085: URL: https://github.com/apache/zeppelin/pull/4085 ### What is this PR for? Trivial PR to include note id into the exported note name so that the exported note name is consistent with the note name we stored in notebook repo. ### What typ

[GitHub] [zeppelin] zjffdu opened a new pull request #4086: [ZEPPELIN-5243]. Get HIVE_CONF_DIR from enviroment in flink interpreter

zjffdu opened a new pull request #4086: URL: https://github.com/apache/zeppelin/pull/4086 ### What is this PR for? Trivial PR to get HIVE_CONF_DIR from environment variable in flink interpreter ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ###

[GitHub] [zeppelin] zjffdu opened a new pull request #4087: [ZEPPELIN-5234]. Increase default value of ZEPPELIN_INTERPRETER_CONNECTION_POOL_SIZE

zjffdu opened a new pull request #4087: URL: https://github.com/apache/zeppelin/pull/4087 ### What is this PR for? Trivial PR to increase the default value of `ZEPPELIN_INTERPRETER_CONNECTION_POOL_SIZE` ### What type of PR is it? [ Improvement ] ### Todos * [ ] -

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4083: [ZEPPELIN-5307] Ignore the single quote and double quote in sql comment

cuspymd commented on a change in pull request #4083: URL: https://github.com/apache/zeppelin/pull/4083#discussion_r606124319 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/util/SqlSplitter.java ## @@ -102,15 +102,15 @@ public SqlSplitter(Strin

[GitHub] [zeppelin] zjffdu commented on pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

zjffdu commented on pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082#issuecomment-812404735 LGTM, thanks @Reamer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4083: [ZEPPELIN-5307] Ignore the single quote and double quote in sql comment

zjffdu commented on a change in pull request #4083: URL: https://github.com/apache/zeppelin/pull/4083#discussion_r606133784 ## File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/util/SqlSplitter.java ## @@ -102,15 +102,15 @@ public SqlSplitter(String

[GitHub] [zeppelin] Reamer commented on pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

Reamer commented on pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082#issuecomment-812438401 I will merge this into Master and Branch-0.9 next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4079: [ZEPPELIN-5288]. Add rest api to reload note

cuspymd commented on a change in pull request #4079: URL: https://github.com/apache/zeppelin/pull/4079#discussion_r606168837 ## File path: zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java ## @@ -78,6 +78,39 @@ public void setUp() { anonymous

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4086: [ZEPPELIN-5243]. Get HIVE_CONF_DIR from enviroment in flink interpreter

cuspymd commented on a change in pull request #4086: URL: https://github.com/apache/zeppelin/pull/4086#discussion_r606174794 ## File path: flink/interpreter/src/main/scala/org/apache/zeppelin/flink/FlinkScalaInterpreter.scala ## @@ -450,9 +450,9 @@ class FlinkScalaInterpreter(

[GitHub] [zeppelin] zjffdu commented on pull request #4083: [ZEPPELIN-5307] Ignore the single quote and double quote in sql comment

zjffdu commented on pull request #4083: URL: https://github.com/apache/zeppelin/pull/4083#issuecomment-813027604 Thanks for the review @cuspymd Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4079: [ZEPPELIN-5288]. Add rest api to reload note

zjffdu commented on a change in pull request #4079: URL: https://github.com/apache/zeppelin/pull/4079#discussion_r606797662 ## File path: zeppelin-server/src/test/java/org/apache/zeppelin/rest/NotebookRestApiTest.java ## @@ -78,6 +78,39 @@ public void setUp() { anonymous

[GitHub] [zeppelin] zjffdu opened a new pull request #4088: SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

zjffdu opened a new pull request #4088: URL: https://github.com/apache/zeppelin/pull/4088 ### What is this PR for? The root cause is that we didn't get SPARK_HOME from env first when detecting scala version. ### What type of PR is it? [Bug Fix ] ### Todos * [ ] -

[GitHub] [zeppelin] zjffdu commented on pull request #4085: [ZEPPELIN-5255] Exported note name should included the note id

zjffdu commented on pull request #4085: URL: https://github.com/apache/zeppelin/pull/4085#issuecomment-813769369 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] zjffdu commented on pull request #4084: [ZEPPELIN-5296]. NPE when calling completion for %spark.sql

zjffdu commented on pull request #4084: URL: https://github.com/apache/zeppelin/pull/4084#issuecomment-813769536 Will merge if no more comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [zeppelin] asfgit closed pull request #4083: [ZEPPELIN-5307] Ignore the single quote and double quote in sql comment

asfgit closed pull request #4083: URL: https://github.com/apache/zeppelin/pull/4083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] asfgit closed pull request #4082: [ZEPPELIN-5305] Activate tests for Zeppelin plugins in our CI infrastructure

asfgit closed pull request #4082: URL: https://github.com/apache/zeppelin/pull/4082 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu commented on pull request #4088: SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

zjffdu commented on pull request #4088: URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-814566829 @cuspymd Could you point where it inconsistent ? Any place we take environment variable first ? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] asfgit closed pull request #4087: [ZEPPELIN-5234]. Increase default value of ZEPPELIN_INTERPRETER_CONNECTION_POOL_SIZE

asfgit closed pull request #4087: URL: https://github.com/apache/zeppelin/pull/4087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] asfgit closed pull request #4084: [ZEPPELIN-5296]. NPE when calling completion for %spark.sql

asfgit closed pull request #4084: URL: https://github.com/apache/zeppelin/pull/4084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] asfgit closed pull request #4085: [ZEPPELIN-5255] Exported note name should included the note id

asfgit closed pull request #4085: URL: https://github.com/apache/zeppelin/pull/4085 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] cuspymd commented on pull request #4088: [ZEPPELIN-5310] SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

cuspymd commented on pull request #4088: URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-814575595 > > > @cuspymd Could you point where it inconsistent ? Any place we take environment variable first ? Oh, I'm not saying because there is an error in the code. Yo

[GitHub] [zeppelin] zjffdu commented on pull request #4088: [ZEPPELIN-5310] SPARK_HOME in zeppelin-env.sh doesn't take effect in yarn cluster mode

zjffdu commented on pull request #4088: URL: https://github.com/apache/zeppelin/pull/4088#issuecomment-814578428 No problem @cuspymd Thanks for your time on the code review. Very appreciated ! -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [zeppelin] asfgit closed pull request #4081: [ZEPPELIN-5299] Comment at end of query causes query to be ignored

asfgit closed pull request #4081: URL: https://github.com/apache/zeppelin/pull/4081 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] PrarthiJain opened a new pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

PrarthiJain opened a new pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089 ### What is this PR for? • This PR is to upgrade thrift to 0.14.1 ### What type of PR is it? • [Improvement] ### Todos • [ ] - Task ### What is the Jira issue? • ht

[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

PrarthiJain commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-815744305 @prabhjyotsingh @VipinRathor @zjffdu, Could you please help in reviewing? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

Reamer commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-815769361 Please remove your changes in the zeppelin-web submodule. I closed your JIRA ticket because it duplicates another one. Please change your PR title and link to your PR text.

[GitHub] [zeppelin] cuspymd opened a new pull request #4090: [ZEPPELIN-5316] Incorrect markdown at '/quickstart/docker.html'

cuspymd opened a new pull request #4090: URL: https://github.com/apache/zeppelin/pull/4090 ### What is this PR for? Fix incorrect markdown at /quickstart/docker.md ### What type of PR is it? [Documentation] ### Todos * [ ] - Task ### What is the Jira issue? *

[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

Reamer commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-816508269 This PR also affects #4072, which still uses the old Thrift version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [zeppelin] PrarthiJain commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

PrarthiJain commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-816593386 Thanks, @Reamer. Could you please help with the steps to test for a successful shutdown of the Zeppelin interpreter? -- This is an automated message from the Apache Git S

[GitHub] [zeppelin] Reamer edited a comment on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

Reamer edited a comment on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-815769361 Please remove your changes in the zeppelin-web submodule. I closed your JIRA ticket because it duplicates another one. Please change your PR title and link in your PR tex

[GitHub] [zeppelin] Reamer commented on pull request #4089: [ZEPPELIN-5314]. Upgrade thrift to 0.14.1

Reamer commented on pull request #4089: URL: https://github.com/apache/zeppelin/pull/4089#issuecomment-816623685 > Thanks, @Reamer. Could you please help with the steps to test for a successful shutdown of the Zeppelin interpreter? After #4072 has been merged, I can help you, -- T

[GitHub] [zeppelin] cuspymd opened a new pull request #4091: [ZEPPELIN-5319] Incorrect markdown in the documentation of sap interpreter

cuspymd opened a new pull request #4091: URL: https://github.com/apache/zeppelin/pull/4091 ### What is this PR for? Fix incorrect example code display at "/interpreter/sap.html" ### What type of PR is it? [Documentation] ### What is the Jira issue? * https://issues

[GitHub] [zeppelin] dannycranmer opened a new pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer opened a new pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092 ### What is this PR for? When a user renames a note Zeppelin does not check for existing notes with the same name/path. This can result in errors as multiple notes can have conflicting paths.

[GitHub] [zeppelin] Reamer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

Reamer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611652026 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -225,6 +228,8 @@ public void moveNote(String noteId,

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

cuspymd commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611663144 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -539,11 +539,23 @@ function NotebookCtrl($scope, $route, $routeParams, $locatio

[GitHub] [zeppelin] Reamer commented on pull request #4091: [ZEPPELIN-5319] Incorrect markdown in the documentation of sap interpreter

Reamer commented on pull request #4091: URL: https://github.com/apache/zeppelin/pull/4091#issuecomment-817857107 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For q

[GitHub] [zeppelin] Reamer commented on pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

Reamer commented on pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072#issuecomment-817859179 I will merge this PR into master and branch-0.9 on Thursday if no further comments are received. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [zeppelin] dannycranmer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r611713414 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -539,11 +539,23 @@ function NotebookCtrl($scope, $route, $routeParams, $lo

[GitHub] [zeppelin] dannycranmer commented on pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-817891494 > I see that you have made changes in the `zeppelin-web` submodule. We a newer frontend submodule `zeppelin-web-angular`. Unfortunately, I am not a NodeJS developer, so I

[GitHub] [zeppelin] dannycranmer commented on pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-817891879 Looks like I have a flaky UI test, will address -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [zeppelin] dannycranmer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r612252990 ## File path: zeppelin-web/src/app/notebook/notebook.controller.js ## @@ -539,11 +539,23 @@ function NotebookCtrl($scope, $route, $routeParams, $lo

[GitHub] [zeppelin] dannycranmer commented on pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#issuecomment-818563782 I have reworked this change to be server side only, no UI changes required now -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [zeppelin] Reamer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

Reamer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r612301146 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -378,6 +386,24 @@ private String getNoteName(String note

[GitHub] [zeppelin] Bowen0729 opened a new pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

Bowen0729 opened a new pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093 ### What is this PR for? Add Feature 'delete paragraph' for ZeppelinClient ### What type of PR is it? [Improvement] ### What is the Jira issue? https://issues.apache.org/jira/b

[GitHub] [zeppelin] dannycranmer commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

dannycranmer commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r612393692 ## File path: zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java ## @@ -378,6 +386,24 @@ private String getNoteName(Strin

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4092: [ZEPPELIN-4506] Check for duplicate note on rename of a notebook

cuspymd commented on a change in pull request #4092: URL: https://github.com/apache/zeppelin/pull/4092#discussion_r612500675 ## File path: zeppelin-server/src/test/java/org/apache/zeppelin/service/NotebookServiceTest.java ## @@ -331,6 +333,26 @@ public void testNoteOperations(

[GitHub] [zeppelin] cuspymd opened a new pull request #4094: [ZEPPELIN-5321] Missing links of some interpreters in index page and link menu

cuspymd opened a new pull request #4094: URL: https://github.com/apache/zeppelin/pull/4094 ### What is this PR for? Fix missing interpreter links in document page ### What type of PR is it? [Documentation] ### What is the Jira issue? * https://issues.apache.org/jira/br

[GitHub] [zeppelin] zjffdu commented on pull request #4094: [ZEPPELIN-5321] Missing links of some interpreters in index page and link menu

zjffdu commented on pull request #4094: URL: https://github.com/apache/zeppelin/pull/4094#issuecomment-819176499 Thanks @cuspymd for the contribution, LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

cuspymd commented on a change in pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093#discussion_r612913260 ## File path: zeppelin-client/src/main/java/org/apache/zeppelin/client/ZeppelinClient.java ## @@ -559,6 +559,24 @@ public String addParagraph(String not

[GitHub] [zeppelin] Bowen0729 commented on pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

Bowen0729 commented on pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093#issuecomment-819272541 > It would be nice if there were more helpful descriptions. Of course you've referenced the existing code, but isn't there a need to copy the existing bad parts? Sure,

[GitHub] [zeppelin] Bowen0729 closed pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

Bowen0729 closed pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [zeppelin] Bowen0729 commented on pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

Bowen0729 commented on pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093#issuecomment-819273546 @zjffdu should I close this pr or merge it after review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [zeppelin] zjffdu commented on pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

zjffdu commented on pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093#issuecomment-819288928 @Bowen0729 If this PR is not needed, you can close it an its jira ticket as well. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [zeppelin] Bowen0729 closed pull request #4093: [ZEPPELIN-55322] Add Feature 'delete paragraph' for ZeppelinClient

Bowen0729 closed pull request #4093: URL: https://github.com/apache/zeppelin/pull/4093 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, ple

[GitHub] [zeppelin] cuspymd opened a new pull request #4095: [ZEPPELIN-5325] Broken table column at yarn.html

cuspymd opened a new pull request #4095: URL: https://github.com/apache/zeppelin/pull/4095 ### What is this PR for? Add missing column of table in yarn document ### What type of PR is it? [Documentation] ### What is the Jira issue? * https://issues.apache.org/jira/brow

[GitHub] [zeppelin] asfgit closed pull request #4072: [ZEPPELIN-4983] Download local repo to interpreter nodes

asfgit closed pull request #4072: URL: https://github.com/apache/zeppelin/pull/4072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [zeppelin] zjffdu opened a new pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

zjffdu opened a new pull request #4096: URL: https://github.com/apache/zeppelin/pull/4096 ### What is this PR for? This is a hotfix to fix the ci failure due to dns reverse lookup issue. Some of the code is copied from pulsar project. https://github.com/lhotari/pulsar/commit/b430

[GitHub] [zeppelin] cuspymd commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

cuspymd commented on a change in pull request #4096: URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615405020 ## File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java ## @@ -102,7 +102,7 @@ public void testSparkShiny

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

zjffdu commented on a change in pull request #4096: URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615417651 ## File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java ## @@ -102,7 +102,7 @@ public void testSparkShinyA

[GitHub] [zeppelin] zjffdu commented on a change in pull request #4096: [HOTFIX] CI failed due to dns reverse lookup issue

zjffdu commented on a change in pull request #4096: URL: https://github.com/apache/zeppelin/pull/4096#discussion_r615421141 ## File path: spark/interpreter/src/test/java/org/apache/zeppelin/spark/SparkShinyInterpreterTest.java ## @@ -102,7 +102,7 @@ public void testSparkShinyA

  1   2   3   4   5   6   7   8   9   10   >