zjffdu commented on a change in pull request #4072:
URL: https://github.com/apache/zeppelin/pull/4072#discussion_r602102340
##########
File path:
zeppelin-zengine/src/main/java/org/apache/zeppelin/interpreter/RemoteInterpreterEventServer.java
##########
@@ -557,4 +563,58 @@ public void updateParagraphConfig(String noteId,
LOGGER.error("Fail to updateParagraphConfig", e);
}
}
+
+ @Override
+ public List<LibraryMetadata> getAllLibraryMetadatas(String interpreter)
throws TException {
+ if (StringUtils.isBlank(interpreter)) {
+ LOGGER.warn("Interpreter is blank");
+ return Collections.emptyList();
+ }
+ File interpreterLocalRepo = new File(
+
zConf.getAbsoluteDir(ZeppelinConfiguration.ConfVars.ZEPPELIN_DEP_LOCALREPO)
+ + File.separator
+ + interpreter);
+ if (!interpreterLocalRepo.exists()) {
+ LOGGER.warn("Local interpreter repository {} for interpreter {} doesn't
exists", interpreterLocalRepo,
+ interpreter);
+ return Collections.emptyList();
+ }
+ if (!interpreterLocalRepo.isDirectory()) {
+ LOGGER.warn("Local interpreter repository {} is no folder",
interpreterLocalRepo);
+ return Collections.emptyList();
+ }
+ Collection<File> files = FileUtils.listFiles(interpreterLocalRepo, new
String[] { "jar" }, false);
Review comment:
In most of cases it should be OK, Just concern some corner cases that
some library may depend on non-jar files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
