[GitHub] [zeppelin] cuspymd commented on a change in pull request #3947: [ZEPPELIN-5066] Notebook creation fails in Zeppelin 0.9 with namespace collision

[GitBox]

cuspymd commented on a change in pull request #3947:
URL: https://github.com/apache/zeppelin/pull/3947#discussion_r601994732



##########
File path: 
zeppelin-server/src/main/java/org/apache/zeppelin/socket/ConnectionManager.java
##########
@@ -359,6 +359,19 @@ public void unicastParagraph(Note note, Paragraph p, 
String user, String msgId)
     }
   }
 
+  public static abstract class UserIterator {
+    public abstract void handleUser(String user, Set<String> userAndRoles);
+  }

Review comment:
       This class doesn't iterate a collection. Wouldn't the name `UserHandler` 
or `UserRoleHandler` be more appropriate?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org