Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1593
@jongyoul @Leemoonsoo Could you help review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1672
It still doesn't work for me.
This is the error I get, it seems permission issue because it use another
user to run the interpreter process.
```
DEBUG [2016-11-23 16:13:06,100] ({Exec St
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1672
can you try
`chmod 777
/Users/jzhang/github/zeppelin/logs/zeppelin-interpreter-spark-jzhang-jzhangMBPr.local.log`
---
If your project is set up for it, you can reply to this email
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Thank you for fixing bug.
It's working as expected and adding test is also great!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1672
I can do that, but it doesn't make sense to force user to do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1672
I assumed this log file should have group permission to log into this file.
What do you recommend ?
---
If your project is set up for it, you can reply to this email and have your
reply ap
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1672
I found another crtitical issue is that all the enviroment variables
defined in zeppelin-env.sh (like HADOOP_CONF_DIR) won't be passed to the
interpreter process because you use ssh. This will caus
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1638
I will rebase to clean useless commits
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1672
I think that should be fine;
```
...
ZEPPELIN_INTP_CLASSPATH+=":${HADOOP_CONF_DIR}"
...
CLASSPATH+=":${ZEPPELIN_INTP_CLASSPATH}"
...
SPARK_SUBMIT_R
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1672
Actually it doesn't work for spark interpreter if you try that.
https://github.com/apache/zeppelin/blob/master/bin/interpreter.sh#L171 is for
pig. And it is not safe if we add other enviroment var
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/1672
I see your point, let me check that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1659
Great, thank you @1ambda !
Looks great to me, @asanjar if there is no more input on Node version (this
PR uses v6, latest LTS) - merging it to master.
---
If your project is set up for it,
Github user asanjar commented on the issue:
https://github.com/apache/zeppelin/pull/1659
+1
sorry for the delay in responding. you guys have been superb
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user asanjar commented on the issue:
https://github.com/apache/zeppelin/pull/1666
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1659
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is e
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear Could you resolve conflict?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
Thank you @1ambda !
@felizbear as soon as #1659 with CI improvements was merged, let's rebase
and see if we can merge this guy
---
If your project is set up for it, you can reply to this ema
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1639
You guys rock! ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1647
## Review Summary
It works as @Mleekko described (I attached GIF)
I think this is better for the default behavior of dynamic selectbox. Since
user can choose to run or not to run.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1168
@jongyoul how do you think, could you interactively rebase this branch to
have only `./_tools/*` changes? Or is it better to start a JIRA issue and close
this guy?
@1ambda do you know any way
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Looks great to me, except for code style noted above.
Thank you @1ambda for tests improvements, would be happy to merge as soon
as the style issue addressed, if there is no further discussion.
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1671
LGTM ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user mfelgamal commented on the issue:
https://github.com/apache/zeppelin/pull/1538
@1ambda It's good if we did that in apache zeppelin repo. but in this case
instead of using the created binary versions, we should build the source code
inside the docker.
Like that:
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1656
Perhaps just check for master starts with "yarn"?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user felizbear commented on the issue:
https://github.com/apache/zeppelin/pull/1639
rebased
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Luca Grazioli created ZEPPELIN-1702:
---
Summary: Spark Contexts Profile
Key: ZEPPELIN-1702
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1702
Project: Zeppelin
Issue Type: Improvement
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1548
Seems the reason of CI failure is irrelevant with this change. Several
tests are failed because of Livy.
```
[INFO]
---
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1656
@felixcheung It makes sense. Thank you.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user astroshim commented on the issue:
https://github.com/apache/zeppelin/pull/1671
@tae-jun Thank you for your review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
GitHub user tae-jun reopened a pull request:
https://github.com/apache/zeppelin/pull/1630
[ZEPPELIN-1629] Enable renaming folder from the main page
### What is this PR for?
This PR will enable renaming folder from the main page.
I wrote some codes. Hope this PR is the st
Github user tae-jun closed the pull request at:
https://github.com/apache/zeppelin/pull/1630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tae-jun commented on the issue:
https://github.com/apache/zeppelin/pull/1630
@AhyoungRyu Yeah!!! Finally!!!
CI is green!!! It was my fault! I didn't import `Folder` at
`zeppelin-server`.
(Why was it green before...?)
Please take a look!
---
If y
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1613
I did a code reading to see how to fix this.. Looks like I will need to
handle it per user as well.
To complete this PR, I can quickly make the changes to show the link in
interpreter page,
Github user karup1990 commented on the issue:
https://github.com/apache/zeppelin/pull/1663
Thanks @1ambda for looking into this PR and for the suggestions.
For the 3rd point,
I am not very sure of the use cases for hiding the output in a paragraph.
Do you see a case where t
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1637
@Leemoonsoo
Thank you for your advice.
I have finished editing.
May I ask you for a review once again?
---
If your project is set up for it, you can reply to this email and have
Hi!
apologies for the extra wide distribution (this exhausts my once
a year ASF mail-to-all-bigdata-projects quota ;-)) but I wanted
to suggest that all of you should consider submitting talks
to FOSDEM 2017 HPC, Bigdata and Data Science DevRoom:
https://hpc-bigdata-fosdem17.github.io/
It was
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
@felizbear great!
From my experience, if you, as PR author, elaborate on the CI failure, in
case of any, it usually speeds merging things up.
---
If your project is set up for it, you can reply
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1663
@karup1990 sorry for misspelling It was **clear output**
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@agoodm thank you, looks great! There has been some changes in
`.travis.yaml`, could you please rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Thank you - it's a great effort, a bit long to review so it took a while
and have diverged from master.
@1ambda could you rebase and also make sure it does not affect automation
like https://
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1620
@wang28103 looks like PR to the wrong destination
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1603
@Leemoonsoo do you think it's worth re-basing on latest master?
Tried `mvn clean package -pl \!zeppelin-distribution` on this branch again,
got:
```
Results :
Tests in er
Github user felizbear closed the pull request at:
https://github.com/apache/zeppelin/pull/1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
GitHub user felizbear reopened a pull request:
https://github.com/apache/zeppelin/pull/1639
[ZEPPELIN-1667] add support for es6
### What is this PR for?
This PR adds support for the current ECMAScript standard
[es6](http://www.ecma-international.org/ecma-262/6.0/) via
[babel](h
Github user wang28103 commented on the issue:
https://github.com/apache/zeppelin/pull/1620
this is not a intended PR.
sorry for any inconvenience it brings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user wang28103 closed the pull request at:
https://github.com/apache/zeppelin/pull/1620
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1600
@aspen01 thank you for contribution!
Could you please double-check that all new files, as any other file in
Apache Zeppelin, have [ASF's Apache 2.0 license
header](http://www.apache.org/legal
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1662
@1ambda thank you for great effort! It's a bit hard to review as
re-formatting is mixed with pom.xml modifications.
How hard would be to have 2 separate PRs - one with improvements, and
anoth
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1639
CI is green now.
Looks great to me, merging to master if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1662
@bzz I couldn't consider the reviewer's point of view. I will split this!
Thanks again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Thank you @AhyoungRyu for great job and taking care in addressing the [user
experience
concerns](https://github.com/apache/zeppelin/pull/1339#issuecomment-259683752)!
---
If your project is se
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1538
Great job @mfelgamal !
The idea was to try to avoid building separate artefacts for Docker and use
official convenience binaries from Apache release.
Am I mimssing something, or wha
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts looks like CI is failing. Do you know the reason? If you try
open\close the PR, can it be reproduced?
---
If your project is set up for it, you can reply to this email and have your
re
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/1663
I left some comments inline and could you add test for this feature ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@bzz
Thank you for your feedback.
The problem with CI is irrelevant to my own.
I think this is probably related to this.
Https://github.com/apache/zeppelin/commit/4dd36bf
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1668
@bzz Thanks for review! I didn't know about `change_scala_version.sh` but
it is very important if it's affected
There are many ways to compare, but i choose simple and reproduceable way
so
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1339
Let me also review this great PR and then give some feedbacks ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1339
@bzz Just updated `upgrade.md` as your feedback.
@1ambda Sure. Thanks! Please do :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Thank you for double-checking and explanations. Looks like CI is failing
right now though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1662
Thanks!
Looks great to me, will merge to master as soon as CI is green, if there is
no further discussion.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1638
@1ambda ping. Would be great to merge it ASAP if it helps \w CI stability
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1638
@bzz Removed styling commit. Let's see the CI result. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1668
@bzz
Failed due to not the related test. I will amend commit and trigger CI again
```
Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 110.105 sec
- in org.apach
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Awesome, ð for tests and a great commit\history structure that allows
just to skip one and preserve all the work!
---
If your project is set up for it, you can reply to this email and have your
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Something is wrong. I will fix it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user agoodm commented on the issue:
https://github.com/apache/zeppelin/pull/1632
@bzz done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if t
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1663
Hi @karup1990, really nice and useful feature indeed.
While quickly looking through this, I have some minor feedbacks about UI :)
1. `Spark Job` and `Spark jobs` have different font
Github user meenakshisekar closed the pull request at:
https://github.com/apache/zeppelin/pull/1548
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feat
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1548
[ZEPPELIN-917] Apply new mechanism to LensInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-settin
Alexander Bezzubov created ZEPPELIN-1703:
Summary: More OpenPower support: skip PhantomJS installation if
tests are skipped
Key: ZEPPELIN-1703
URL: https://issues.apache.org/jira/browse/ZEPPELIN-1703
GitHub user bzz opened a pull request:
https://github.com/apache/zeppelin/pull/1673
ZEPPELIN-1703: frontend - skip PhantomJS on -DskipTests
### What is this PR for?
Skip PhatomJS installation on `mvn package -DskipTests`
### What type of PR is it?
Improvement
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1673
\cc @afsanjar @felizbaer for reivew
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1638
Great, CI is green now!
Merging to master, if there is no further discussion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1668
Looks great to me and CI is green now.
Merging to master, if there is no further discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1673
@bzz I think this is cool. This will reduce build time for profiles do not
test
If we worry about version, we could specify in `pretest` command like `npm
install karma-phantomjs-launcher@
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1548
@meenakshisekar Nice!
Will merge this if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
CI Green!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts Nice. Glad to see the green light at last!
Sorry for my late response. Let me take a look again and will ping you :)
---
If your project is set up for it, you can reply to th
Github user cloverhearts commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@AhyoungRyu
Thank you very much!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/1674
[ZEPPELIN-1695] Apply regular maven indent
### What is this PR for?
**First of all, this PR doesn't affect on runtime application behaivor and
existing build processes. Just styling all p
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1674
\cc @bzz for reviewing this issue. (related to
https://github.com/apache/zeppelin/pull/1662)
thanks!
---
If your project is set up for it, you can reply to this email and have your
reply
81 matches
Mail list logo
