Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1668
@bzz Thanks for review! I didn't know about `change_scala_version.sh` but
it is very important if it's affected
There are many ways to compare, but i choose simple and reproduceable way
so that other can to do again.
- run `./dev/change_scala_version.sh` in both branch `master` and `pr1668`
- create diff files
- compare the above files
As you can see, `change_scala_version.sh` is no relevant with this PR.
```
$ zeppelin-review git:(master) git rev-parse HEAD
abe03a866fc9ac2563c057d6edc00d3ec0a7d733
$ zeppelin-review git:(master) ./dev/change_scala_version.sh 2.11
./dev/../alluxio/pom.xml
./dev/../angular/pom.xml
./dev/../beam/pom.xml
./dev/../bigquery/pom.xml
./dev/../cassandra/pom.xml
./dev/../elasticsearch/pom.xml
./dev/../file/pom.xml
./dev/../flink/pom.xml
./dev/../geode/pom.xml
./dev/../hbase/pom.xml
./dev/../ignite/pom.xml
./dev/../jdbc/pom.xml
./dev/../kylin/pom.xml
./dev/../lens/pom.xml
./dev/../livy/pom.xml
./dev/../markdown/pom.xml
./dev/../pig/pom.xml
./dev/../pom.xml
./dev/../postgresql/pom.xml
./dev/../python/pom.xml
./dev/../r/pom.xml
./dev/../scalding/pom.xml
./dev/../scio/pom.xml
./dev/../shell/pom.xml
./dev/../spark/pom.xml
./dev/../spark-dependencies/pom.xml
./dev/../zeppelin-display/pom.xml
./dev/../zeppelin-distribution/pom.xml
./dev/../zeppelin-examples/pom.xml
./dev/../zeppelin-examples/zeppelin-example-clock/pom.xml
./dev/../zeppelin-examples/zeppelin-example-horizontalbar/pom.xml
./dev/../zeppelin-interpreter/pom.xml
./dev/../zeppelin-server/pom.xml
./dev/../zeppelin-web/pom.xml
./dev/../zeppelin-zengine/pom.xml
$ zeppelin-review git:(master) â git diff --no-color > ~/master
$ zeppelin-master git:(chore/centralize-maven-pom-versions) git rev-parse
HEAD
b724218c446f3f740238e528c86ee32864f46e92
$ zeppelin-master git:(chore/centralize-maven-pom-versions)
./dev/change_scala_version.sh 2.11
./dev/../alluxio/pom.xml
./dev/../angular/pom.xml
./dev/../beam/pom.xml
./dev/../bigquery/pom.xml
./dev/../cassandra/pom.xml
./dev/../elasticsearch/pom.xml
./dev/../file/pom.xml
./dev/../flink/pom.xml
./dev/../geode/pom.xml
./dev/../hbase/pom.xml
./dev/../ignite/pom.xml
./dev/../jdbc/pom.xml
./dev/../kylin/pom.xml
./dev/../lens/pom.xml
./dev/../livy/pom.xml
./dev/../markdown/pom.xml
./dev/../pig/pom.xml
./dev/../pom.xml
./dev/../postgresql/pom.xml
./dev/../python/pom.xml
./dev/../r/pom.xml
./dev/../scalding/pom.xml
./dev/../scio/pom.xml
./dev/../shell/pom.xml
./dev/../spark/pom.xml
./dev/../spark-dependencies/pom.xml
./dev/../zeppelin-display/pom.xml
./dev/../zeppelin-distribution/pom.xml
./dev/../zeppelin-examples/pom.xml
./dev/../zeppelin-examples/zeppelin-example-clock/pom.xml
./dev/../zeppelin-examples/zeppelin-example-horizontalbar/pom.xml
./dev/../zeppelin-interpreter/pom.xml
./dev/../zeppelin-server/pom.xml
./dev/../zeppelin-web/pom.xml
./dev/../zeppelin-zengine/pom.xml
$ zeppelin-master git:(chore/centralize-maven-pom-versions) â git diff
--no-color > ~/pr1668
$ ~ diff master pr1668
2c2
< index dc31594..c4ad855 100644
---
> index 02a7ab3..c821dbb 100644
5c5
< @@ -47,7 +47,7 @@
---
> @@ -52,7 +52,7 @@
14c14
< @@ -59,15 +59,15 @@
---
> @@ -64,15 +64,15 @@
33c33
< @@ -75,7 +75,7 @@
---
> @@ -80,7 +80,7 @@
43c43
< index e425f48..7e6cc2b 100644
---
> index 267eb0d..a3d0ab9 100644
56c56
< index 1885a1f..6ffd328 100644
---
> index 7ed559f..d835f91 100644
69c69
< index d70c488..95b5bf9 100644
---
> index 4e7ed2c..6be9e69 100644
82c82
< index 1e717f8..17af6bc 100644
---
> index 0fc8847..af7a926 100644
85c85
< @@ -121,27 +121,27 @@
---
> @@ -133,27 +133,27 @@
119c119
< @@ -181,27 +181,27 @@
---
> @@ -193,27 +193,27 @@
153c153
< @@ -217,27 +217,27 @@
---
> @@ -229,27 +229,27 @@
188c188
< index 2f7ac3c..491a0c9 100644
---
> index ccee507..fe4a502 100644
191,192c191
< @@ -83,7 +83,7 @@
<
---
> @@ -84,7 +84,7 @@
193a193
> <!-- language versions -->
201c201
< index 2dc2eef..88f09e3 100644
---
> index c4ac898..e275f6e 100644
214c214
< index 937d11a..aff1d77 100644
---
> index 83485b0..5af4ffa 100644
227c227
< index 27f5433..4cd3c7e 100644
---
> index 5d385ac..cfafbf8 100644
240c240
< index 04b6983..2eb5cab 100644
---
> index 0185bb7..9b98473 100644
253c253
< index 9e1549d..b0f52a7 100644
---
> index a8d2616..126cb85 100644
266c266
< index d33038e..1b95436 100644
---
> index 1127228..e30df11 100644
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
