[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/1663
  
    Hi @karup1990, really nice and useful feature indeed.
    While quickly looking through this, I have some minor feedbacks about UI :)
    
    1. `Spark Job` and `Spark jobs` have different font like below.
    ![screen shot 2016-11-24 at 3 07 53 
pm](https://cloud.githubusercontent.com/assets/10060731/20588398/09141e9a-b258-11e6-9fbd-6166acf6a6fa.png)
    ![screen shot 2016-11-24 at 3 08 04 
pm](https://cloud.githubusercontent.com/assets/10060731/20588399/0d1f77aa-b258-11e6-8ff6-2a051db682a4.png)
    
    2. And I think these block that you added in this PR should be below [this 
line](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph-control.html#L31).
    ```
      <span ng-show="paragraph.runtimeInfos.jobUrl.length == 1">
        <a href="{{paragraph.runtimeInfos.jobUrl[0]}}" target="_blank"><span 
class="fa fa-tasks"></span> Spark Job </a>
      </span>
      <span class="dropdown" ng-show="paragraph.runtimeInfos.jobUrl.length > 1">
      <span class="fa fa-tasks" style="cursor:pointer;color:#3071A9" 
tooltip-placement="top" tooltip="Run this paragraph (Shift+Enter)"
            data-toggle="dropdown"
            type="button">  Spark Jobs
      </span>
        <ul class="dropdown-menu" role="menu" style="width:200px;z-index:1002">
           <li ng-class="{'option-disabled': !noteOperationsAllowed()}" 
ng-repeat="url in paragraph.runtimeInfos.jobUrl">
             <a href="{{url}}" target="_blank"><span class="fa 
fa-external-link-square"></span> Jobs #{{$index}}</a>
           </li>
        </ul>
      </span>
    ```
       - current
    
![before](https://cloud.githubusercontent.com/assets/10060731/20588583/9cf929e2-b259-11e6-9220-b8504de66392.gif)
    
       - after
    
![after](https://cloud.githubusercontent.com/assets/10060731/20588584/9fcfdfe4-b259-11e6-96e3-b2b85642bdb2.gif)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---