Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1858
@astroshim still some missing in the $routeProvider.
Otherwise I just want to point out that the original goal of the cache
buster is to add a hash in the file name so that it is different
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1858
@astroshim Could you provide a way to reproduce the problem, or screenshot
of the issue?
If there is a cache issue with html files, I'm not sure this PR would solve
it. Considerin
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang still the same test failing but asking for different value
this time...
```
Failed tests:
SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang Sorry I just updated to Sierra and am having a few issues.
From the log it seems there is some broken front-end tests (probably due to
a rebase)
You should be able to run
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1510
@snaveenp Could you tell me your JIRA id?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1510
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
Current failure is really weird, can you try launching the CI again
(close/re-open PR)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1510
Tested, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1510
@snaveenp Thanks, let me do a quick test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
Also there is still the selenium test error:
```
Failed tests:
SparkParagraphIT.testSqlSpark:188 Paragraph from SparkParagraphIT of
testSqlSpark result:
Expected:
"age
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang Sorry that it takes so long, you will need to rebase
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
Not really, there is no issue with the feature, the test itself is a bit
weird because it transform to text whatever it find:
https://github.com/apache/zeppelin/blob
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang The button we introduced in this PR, is breaking another test.
Although the test looks funny, let's fix the expected result too
```
Failed
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang
Have to fix a test, need to change the expected result in that test from
`1,787` to `1787`
```
Failed tests:
SparkParagraphIT.testSqlSpark:188 Paragraph from
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1500
@Peilin-Yang Selenium failure should now be fixed on Master, can you rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Actually it's a bit hard for me to help since I can't rebase
for you (Don't have the rights on your branch), but I can see that it is a
pretty messy conflict you go
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1492
Refactor/handsontable service
Test PR to help rebase
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1461
Go for it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1441
@cloverhearts Just tested and checked the code.
Overall same feedbacks as @AhyoungRyu
Filtering system
The one you used seems a bit too complicated (also the filter should
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1461
@AhyoungRyu Rebasing from master should fix the CI issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1461
@AhyoungRyu Tested, LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1491
Fix version of cachebust
### What is this PR for?
A dependency update of grunt-cache-bust is breaking the build.
https://github.com/hollandben/grunt-cache-bust/issues/204
So
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1491
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1490
@Leemoonsoo That Jira issue is in Korean, could you update the PR
description so that there is more details on what the problem is and what is
the expected result of that test before and after
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1491
Merging this directly as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1491
Fix version of cachebust
### What is this PR for?
A dependency update of grunt-cache-bust is breaking the build.
So fixing the dependency version
### What type of PR is
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1363
@Peilin-Yang Yes, you will need to rebase first though
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/133
@doanduyhai Thanks, since it wasn't in the description, I didn't know
@Leemoonsoo Can I merge this?
---
If your project is set up for it, you can reply to this email and have
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1469
[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code
### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the
Good Practice
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/812
@springml If we still want to continue this PR, there might be a few things
to consider.
When running the whole paragraph, there is no specific paragraph running
order. Depending on the
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/777
@michrawson Could you split this PR in two?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/560
@Stefan9149 Do we still want to go forward with this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1478
CI failure is irrelevant.
Tested, Merging it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
@meenakshisekar I can't find you with this username
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
@meenakshisekar Can you tell me your JIRA username?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
Ci failure is irrelevant, Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
@meenakshisekar Could you fix the indent issue?
I want to merge #1469 but since its refactoring job, it would need to be
rebased after yours
---
If your project is set up for it, you can
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/544
@djKooks Not sure it would make a difference.
In the way it is implemented, each language already have its own .js file.
And inside, the translations are set as an object/json format
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1430
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1433
@astroshim CI failure is irrelevant
@Leemoonsoo any feedback?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1464
Well the problem here is that there is really nothing you can do, you are
not going to change your Notebook name, or somebody else notebook name because
both name are the same
---
If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/49
@cfmcgrady Is this PR still relevant?
Otherwise I will close it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/47
@cfmcgrady Is this PR still relevant?
Otherwise I will close it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1474
Want to merge this fast, since it is a Hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1474
Change path to tutorial images
### What is this PR for?
Fixing the image path of the tutorial made in #418
### What type of PR is it?
Hot Fix
### What is the
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
@meenakshisekar There is an indent error breaking the build, can you fix it?
Then, merging this one
---
If your project is set up for it, you can reply to this email and have your
reply
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1469
Merging if there is no discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1430
CI is green LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1464
@rajarajan-g How do you handle if another user with same notebook name
decides to gives you read ability on his notebook?
---
If your project is set up for it, you can reply to this email and
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1429
@r-kamath If you have trouble merging, tell me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1469
CI is green :)
Good to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/418
Awesome, Merging it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1469
[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code
### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the
Good Practice
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1469
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1469
Ready for review.
Re-triggering the CI
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1429
Except for my comment about the test, LGTM.
CI failure is irrelevant
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/418
@rawkintrevo Did the rebase go wrong somehow? Seems there is a lot of
commits that are not related to this PR
---
If your project is set up for it, you can reply to this email and have your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1445
Tested using
```
%sh echo -e "%table name\tval\nhello\thello\you\"good\nhello2\theelow,world"
```
LGTM
---
If your project is set up for it, you can repl
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1469
[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code
### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the
Good Practice
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/133
@doanduyhai Then can you create a Jira issue for it and maybe update the PR
description?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/884
@wind0727 Any plan on taking care of this PR?
I think it would need a new one, based on a special branch instead of your
master.
---
If your project is set up for it, you can reply to this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/560
@Stefan9149 Any plan on trying to finish this PR? Or should we just close
it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/418
@rawkintrevo Lets remove the `incubator` from URLs, rebase, then merge it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/409
@craigching Is this PR still needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/389
@babokim
Going around old PRs,
Is it still needed considering the efforts for user authentication, and
notebook acl restrictions?
---
If your project is set up for it, you can reply
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/338
@abajwa-hw
I'm going around old PRs, any plan on finishing this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/336
Going around old PRs.
As stated before, we had issues with version 1.8.1, and have no plan on
upgrading.
In case newer versions don't have issues we can create a Jira issue to
up
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/321
There is issue with version 1.8.1 and don't plan on updating it yet.
Also, this PR is a mix of box plot and donut.
Lets close it
---
If your project is set up for it, you can rep
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/320
@rolmovel If this PRs is still needed, can we try to rebase it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/318
@khalidhuseynov Is this still an issue with our current implementation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/299
@leonardofoderaro
I'm going around old PRs,
Any plan on finishing this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/291
@tzolov @bzz
Do we want to rebase and try to merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/273
@tzolov Should we close this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/264
@riverajo @felixcheung @Leemoonsoo
Any changes to be done here?
Is this documentation change still needed?
---
If your project is set up for it, you can reply to this email and have
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/252
@azeloo Any plan on finishing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/246
@Leemoonsoo Any plan on finishing this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/234
@guptarajat Hi, any plan on finishing this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/228
@akhiluanandh
I'm going around old PRs.
Any plan on continuing that one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/86
@bbromhead @jongyoul @Leemoonsoo any more feedback on changes needed on
this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/197
We don't usually add to old branch if there is no more releases.
It seems the PR branch doesn't exist anymore.
Closing this PR is there is no more discussions
---
If your proj
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/193
@tzolov
I'm going around old PRs,
What is the status of this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/139
@doanduyhai
I'm going around old PRs,
What should we do about that one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/133
@doanduyhai Do we have the still the need of that PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/152
@Madhuka Let's close this one since you opened another one
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/132
@nevillelyh
I'm going around old PRs, is there any news on this issue?
Or do you want to close it?
---
If your project is set up for it, you can reply to this email and have your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/125
@Leemoonsoo Do we want to keep this PR, or should we close it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/72
If there is no more discussions, I will close this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1463
@AhyoungRyu Nice catch, I also escaped those in Good Practice #3
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1463
:) Merging it then
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1463
[ZEPPELIN-1495] Add Good Practice #4
### What is this PR for?
This Good Practice Guide promotes the usage of `ng-bind` instead of the
classic `{{}}` syntax, to have a performance boost
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1408
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/262
@Madhuka Should we close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/576
@HeartSaVioR It's been quite some time, should we close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/704
@camilosampedro There is still no plan on upgrading nvd3 for now, can we
close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/819
@jersub Can we close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1176
@cloverhearts If I understand, the plan is to open a new PR for this
feature?
Can it be closed then?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1230
@rerngvit If any more arguments for this feature, I'd love to hear it,
otherwise we would better close it
---
If your project is set up for it, you can reply to this email and have your
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1324
@iasandcb Do you want to continue it later when you have some time, or just
close this PR?
Otherwise you can also create a JIRA issue, and somebody can pick up the
issue
---
If your
1 - 100 of 524 matches
Mail list logo
