GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1469
[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code
### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the
Good Practice Guide #1
(https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html)
### What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1496
### How should this be tested?
Run The webapp, and go around the page, things should work like usual.
But overall, just need to check that there is no type or parameter mismatch
during the refactoring process (controller to controller, params in $inject
etc...)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1469
----
commit 91d6e8d843760eea5953f3815b40e8757ecba02f
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-27T08:43:34Z
Add IIFE to app.controller.js
commit c5a3f541a51da23fbaed5abc68f4ca806cebe49b
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-27T08:48:36Z
Move use strict outside IFFE
commit 9b4c043b634e3770856416ec52e47edd6f03d0d4
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-27T08:59:03Z
Add congiguration.controller.js
commit ab47378358a66c7e41055aa36efb6dc2cd4720dd
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T05:36:38Z
Refactor for IIFE credential, home and interpreter controller
commit 309347e76d667f5cd370df61e3600b63828127b3
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:02:12Z
IIFE refactoring of job page
commit 50003726c2b68bc562365944d397403ea3346166
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:18:37Z
Finish refactoring of App
commit a33fb6347ce58c9472dbb588b1c0981e93d48da0
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:35:46Z
Refactor components service and factory
commit a58705d8a18e9e1444afbd1f9030d79ae0998a43
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:55:27Z
Refactor components directives
commit d3758bc5f41da94b12a0757b07df7ea4e4ae0e8a
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T08:56:28Z
refactor components controllers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
