GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1469
[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code
### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the
Good Practice Guide #1
(https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html)
### What type of PR is it?
Refactoring
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1496
### How should this be tested?
Run The webapp, and go around the page, things should work like usual.
But overall, just need to check that there is no type or parameter mismatch
during the refactoring process (controller to controller, params in $inject
etc...)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1469.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1469
----
commit 5080b8de464303cc812e2ed771b7a67c017b9c7f
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-27T08:43:34Z
Add IIFE to app.controller.js
commit 21a591eed164436189569a7ccc9a683b60ca65cc
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-27T08:48:36Z
Move use strict outside IFFE
commit be8f24c80652c1d9cbcee24bf31198518da9d016
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-27T08:59:03Z
Add congiguration.controller.js
commit 268477bd12bae7fbcd106869d4d39960f1699485
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T05:36:38Z
Refactor for IIFE credential, home and interpreter controller
commit 14dd6ccf026be31c1734ca53c9cea47c05fd07ef
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:02:12Z
IIFE refactoring of job page
commit e9f38fc69f05b8ece3c5c2bc48f1dd35214351d3
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:18:37Z
Finish refactoring of App
commit eb82887f8aa3ce47d53c816960a9bdaf52ede482
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:35:46Z
Refactor components service and factory
commit 76662ff1b6e4dc20e0383978a4deedb766e12af3
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T07:55:27Z
Refactor components directives
commit 9e8fec04b71b0436dc8be1836753ca878f1e4d0d
Author: Damien CORNEAU <cornead...@gmail.com>
Date: 2016-09-28T08:56:28Z
refactor components controllers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
