Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1694
@RoxanaTapia Could you file a Jira issue here
https://issues.apache.org/jira/projects/ZEPPELIN so that it can be tracked &
handled separately ? Once a patch is merged, can't be opened
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2660
Merge to gh-pages branch if there is no more discussions
---
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2660
LGTM
---
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Yeah second option is better for me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2394
Thanks for the great work @soralee! And also thanks for detailed review
@1ambda.
Tested and looks nice!
I really like the most of parts. Some minor suggestion is
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2381
Thank you for great work! Especially big +1 for adding this section
https://cloud.githubusercontent.com/assets/10060731/26764287/e5b90aa2-4918-11e7-908c-1fdfd4870037.png
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2371
Cool!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2346
`gh-pages` doesn't have CI check. So the red light is irrelevant with this
change.
Ready to review.
---
If your project is set up for it, you can reply to this email and have your
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2346
[gh-pages] Hide pagination btn if there is only 1 page
### What is this PR for?
Same work with #2345 but for `gh-pages`
### What type of PR is it?
Improvement
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2345
@1ambda If you don't mind, could you help me to review this? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2345
[MINOR] Hide pagination button if there is only 1 page in Helium menu
### What is this PR for?
It'll be better to hide the pagination button if there is only one page.
([`only-of
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2340
Merge into master if there are no more comments on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2340
Tested and it looks good. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Tested and it looks great! +1 for this change
---
If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
@1ambda Yeah right right I misapprehended actually. It was my bad.
Btw I wanted to test this locally but failed when I run `yarn install` and
got this below 404 error
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2265
Cool!
Then to reach to the menu, some users who have lots of paragraphs have to
spend much time to scroll up. Then how about sticky "go to top" like button at
bottom-right side
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda CI checks has been failed sadly. Can you check again?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
Oh.. Will merge into master right after CI turns into green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
Merge into master if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2255
Merge into master as a hotfix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2244
Merge into master and branch-0.7 if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda Yeah makes sense. Looks GOOD to me ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2236
Merge into master if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2252
@1ambda Great work! Quickly looked through the most of file changes and it
looks good. Zeppelin web is getting bigger, everyone will feel the necessity of
this kind of lint rule.
btw
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2236
@tae-jun Looks GOOD to merge :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2236
@tae-jun Thanks for the improvement.
>You can add any dependencies in package.json, but you must include two
dependencies: zeppelin-vis and zeppelin-tabledata.
Yeah I th
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2232
@felixcheung Thanks!
Merge into master if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2124
@soralee I just merged this PR into branch-0.7 but it's not closed
automatically. Could you close it in your side?
---
If your project is set up for it, you can reply to this email and
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/
@wary Thanks!
Merge into master and branch-0.7 if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2232
CI is green now.
@jongyoul Could you help me to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2232
[ZEPPELIN-2373] Remove -Pyarn build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Pyarn`
build profile to enable Yarn for embedded
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2220
Merge into master and branch-0.7 if there are no more comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2212
@1ambda Thanks.
CI failure is irrelevant with gh-pages change. Merge into gh-pages if there
are no more comments.
---
If your project is set up for it, you can reply to this email and
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2224
@1ambda I just merged this into branch-0.7 but it's not closed
automatically. Could you close in your side?
---
If your project is set up for it, you can reply to this email and have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2192
@Remilito yeah you're right. Normally if the PR is for bug fixing or minor
update, committers merge it both into master and branch-0.x. But since #2099
was merged into master only, you
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2225
@1ambda Yeah I also knew it when I was adding the pagination to Helium menu
for both zeppelin.apache.org and Zeppelin :)
Tested again and it works well. LGTM
---
If your project is set
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2225
@1ambda If we update angular-bootstrap version, the pagination in Helium
page won't work since they change the pagination lib name (`pagination` ->`ul
uib-pagination`)
So you might
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2224
LGTM
Merge into branch-0.7 if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2215
@Leemoonsoo Thanks!
Merge into master if there are no more comments
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2224
CI failure is irrelevant with this change. Looks good :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2098
Cool! LGTM. Looking forward to many usage of this advanced transformation
by Zeppelin-Helium fans :)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2098
@1ambda Looks great!
So sorry I forgot to mention that there is another place to be updated
regarding [this
change](https://github.com/apache/zeppelin/pull/2098#issuecomment-291390619
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2199
Merge into master and branch-0.7 if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2124
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/
Thanks! Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2220
@felixcheung Thanks!
Reading `ZEPPELIN_HOME` and providing full path would be better as you
said, but it says "usually found in..". So I think it's not that much har
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/
@wary Thanks for your contribution. Could you add
`zeppelin.jdbc.auth.kerberos.proxy.enable` info to [this
table](https://github.com/apache/zeppelin/blob/master/docs/interpreter/jdbc.md#more
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2215
Rebased on top of master after #2213 merged and removed the rest of
`-Psparkr` build profile in docs & sh files. Ready to review.
---
If your project is set up for it, you can reply to
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2220
[Minor] Fix wrong Python lib path in Matplotlib tutorial note
### What is this PR for?
There is a wrong information about Zeppelinâs matplotlib backend files.
It actually located under
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2212
@1ambda Can you help review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2098
@1ambda Thanks for letting me know. Just look through what you said,
generally looks good. Let me test again.
---
If your project is set up for it, you can reply to this email and have your
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2210
yeah I got same error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2213
Merge into master if there are no more comments!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2211
@felixcheung @Leemoonsoo Thanks.
Merge into master if there are no further comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2213
@jongyoul Yup, will open a PR for that soon.
@Leemoonsoo Thanks. Updated again :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2215
[ZEPPELIN-2341] Remove -Psparkr build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Psparkr`
to use `%r` with embedded local Spark
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2213
@felixcheung Thanks for pointing it out. Right it makes sense.
I changed all `py4j.version` in `spark/pom.xml` and
`spark-dependencies/pom.xml` to `spark.py4j.version
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2213
[ZEPPELIN-2298] Remove -Ppyspark build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Ppyspark`
to use `%pyspark` with embedded local
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Merge to master if no further comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2205
Thanks. I'm merging into master now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2213
[ZEPPELIN-2298] Remove -Ppyspark build profile
### What is this PR for?
Currently users who build Zeppelin from source need to include `-Ppyspark`
to use `%pyspark` with embedded local
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2199
CI is green now. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AhyoungRyu closed the pull request at:
https://github.com/apache/zeppelin/pull/2211
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user AhyoungRyu reopened a pull request:
https://github.com/apache/zeppelin/pull/2211
[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of
interpreter type pkg
### What is this PR for?
Currently "see more" is pl
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2212
[gh-pages] set max size for pagination btn & hide arrows when current page
is first/last
### What is this PR for?
As the number of Helium packages is increasing, more pagination but
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2204
Merge into master and branch-0.7 if there are no more comments on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2211
[ZEPPELIN-2339] Change 'see more' -> 'enable' next to the older ver of
interpreter type pkg
### What is this PR for?
Currently "see more" is pl
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2195
@meniluca Great initiative! Thanks for detailed explanation and it makes
sense to me as well. That would be helpful to any other reviewers.
But before you go further, need to setup travis
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Looks good to me :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2204
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2208
@felixcheung Thanks!
CI failure is irrelevant with `gh-pages` change. Merge into gh-pages as a
hotfix if there are no more comments on this.
---
If your project is set up for it, you
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2205
@1ambda Yup thanks for letting me know
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2207
@cloverhearts Great! Tested this patch and it works well as you described.
- Before
` as a subsection under "Run a para
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2204
Yeah I saw this as well. Let me take a look :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2135
Thanks for addressing my comments! I left some minor comments again about
"author name" in the source code and removing unnecessary `log.info`. Except
these two things, LGTM ð
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@felixcheung Thanks :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2189
@felixcheung Thanks! Merge into branch-0.7 if there are no further comments
on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda I updated the pagination as you said and this is the current
status. Will be appreciated if you can take a look again.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2202
[Minor][ZEPPELIN-2328] Separate Helium related docs from 'Contribution'
section
### What is this PR for?
Actually writing "Visualization", "Spell" or "A
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2199
Hi @markito Thanks for your contribution and taking care of Geode
interpreter.
- Zeppelin build system relies on travis. So please setup your travis
account and travis project for
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2098
@1ambda I feel so sorry for my late response. Tested this patch \w your
Helium package: zeppelin-ultimate-line-chart. Here are some thought and
question(?) in my head.
1. "
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2200
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda Thanks for the detailed explanation.
---
If your project is set
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@1ambda No worries :)
Then how about 1 page ? I mean if there is only 1 page, we can hide `<<` &
`>>`.
---
If your project is set up for it, you can reply to this ema
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2181
@1ambda I couldn't auto merge this PR into branch-0.7 since there are some
conflicts. If you don't mind, can you create separate PR for branch-0.7?
---
If your project is set up f
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2181
Thanks. Merging into master and branch-0.7 now :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2174
@felixcheung Let me check again for that part.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1 - 100 of 1030 matches
Mail list logo
