[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2098
  
    @1ambda I feel so sorry for my late response. Tested this patch \w your 
Helium package: zeppelin-ultimate-line-chart. Here are some thought and 
question(?) in my head. 
     
    1. "Save" & "Delete" button on top of the setting table
     - It'll be better there are some feedback after clicking these buttons 
like "Changes are successfully saved" or "Changes will be discarded". How about 
small `ngtoast` or bootstrap dialog? 
    
![small_btns](https://cloud.githubusercontent.com/assets/10060731/24440153/82552bcc-148d-11e7-96ee-3dd305917d21.gif)
    Probably ppl can click the trash can button by mistake. Then they'll lose 
the setting. To prevent this, we can provide some alert for this. 
    
     - I think we can hide "Save" & "Delete" button when the setting table is 
folded. A good example is in our interpreter setting page. As you know, users 
only can save/remove the setting when they click "edit" button. So how about 
activating those disket & trash btns only when the setting table is expanded? 
    
    2. no-group field 
     - What is difference between `no-group` and just letting `group` field as 
blank? Is there special reason for creating `no-group` field? (It's question 
actually :D)
    
     - `xAxis` and `yAxis` field size are different in `no-group` section.
    <img width="610" alt="screen shot 2017-03-29 at 2 25 50 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/24440240/0ae00fc0-148e-11e7-999b-554af8d39f72.png";>
    
    And again, this is really cool! 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---