[GitHub] zeppelin pull request #2213: [ZEPPELIN-2298] Remove -Ppyspark build profile

[AhyoungRyu]

GitHub user AhyoungRyu opened a pull request:

    https://github.com/apache/zeppelin/pull/2213

    [ZEPPELIN-2298] Remove -Ppyspark build profile

    ### What is this PR for?
    Currently users who build Zeppelin from source need to include `-Ppyspark` 
to use `%pyspark` with embedded local Spark. But it's quite inconvenient to 
write this build profile every time we build i think. So I removed `-Ppyspark` 
and make pyspark related libraries automatically downloaded when we build 
Zeppelin. 
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [ ] - remove the rest of `-Ppyspark` build profile in 
`dev/create_release.sh`, `dev/publish_release.sh`, and `docs/install/build.md` 
after getting feedback
    
    ### What is the Jira issue?
    [ZEPPELIN-2298](https://issues.apache.org/jira/browse/ZEPPELIN-2298)
    
    ### How should this be tested?
    1. Apply this patch
    2. Build source with below command
    ```
    mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine, 
zeppelin-server, zeppelin-display, spark, spark-dependencies'
    
    ```
    Aftr this step, there will be `pyspark` dir under 
`ZEPPELIN_HOME/interpreter/spark`. Before this PR, only `dep` dir and 
`zeppelin-spark_2.10-0.8.0-SNAPSHOT.jar` is generated without `-Ppyspark` build 
profile.
    
    4. Restart Zeppelin. To make sure, run any python code e.g. 
    ```
    %pyspark
    print("Hello "+z.input("name"))
    ``` 
    It should be run successfully without any error
    
    ### Screenshots (if appropriate)
     tl;dr Without `-Ppyspark` profile
     - Before
    <img width="856" alt="screen shot 2017-04-02 at 2 50 57 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/24584778/0e8ec6b0-17b4-11e7-9f0d-f2599fd7bd63.png";>
     
     - After
    <img width="893" alt="screen shot 2017-04-02 at 2 28 21 pm" 
src="https://cloud.githubusercontent.com/assets/10060731/24584779/10b7ed68-17b4-11e7-90d4-aa95eb9bba2d.png";>
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    I want to include `SparkR` by default(= remove `-PsparkR` build profile) 
like this as a next step. I want to ask how Zeppelin community think about this.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/AhyoungRyu/zeppelin 
ZEPPELIN-2298/includePysparkByDefault

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2213.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2213
    
----
commit 30aac819644b8a3109e9f39ab12f4778f2875614
Author: AhyoungRyu <fbdkdu...@hanmail.net>
Date:   2017-04-02T05:10:59Z

    Remove -Ppyspark build flag

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---