According to https://en.wikipedia.org/wiki/ISO/IEC_8859-1 you have nailed it.
Thanks,
Craig
> On May 18, 2017, at 2:04 PM, Sam Ruby wrote:
>
> On Thu, May 18, 2017 at 4:21 PM, Craig Russell wrote:
>> When translating extended latin characters, the upper case A accent "Á" is
>> incorrectly tr
On Thu, May 18, 2017 at 4:21 PM, Craig Russell wrote:
> When translating extended latin characters, the upper case A accent "Á" is
> incorrectly translated to "-" instead of "a" for the file name.
>
> Minor issue.
>
> I'll take a look at the code later but wanted to get this documented while
> I
When translating extended latin characters, the upper case A accent "Á" is
incorrectly translated to "-" instead of "a" for the file name.
Minor issue.
I'll take a look at the code later but wanted to get this documented while I'm
thinking of it.
Craig
Craig L Russell
c...@apache.org
Hint: both Message and Attachement classes have a method by that name. :-)
- Sam Ruby
On Wed, May 10, 2017 at 8:51 PM, Craig Russell wrote:
> Part of my confusion is this:
>
> in iclas.json.rb:
>
> # create/add file(s)
> if @signature.to_s.empty? or not @selected.end_with? '.pdf'
> messag
Part of my confusion is this:
in iclas.json.rb:
# create/add file(s)
if @signature.to_s.empty? or not @selected.end_with? '.pdf'
message.write_svn("#{dir}/iclas", @filename, @selected, @signature)
else
message.write_svn("#{dir}/iclas", @filename,
@selected => 'icla.pdf', @signature =
OK, I believe that there were two bugs here:
https://github.com/apache/whimsy/commit/786413d74a2515f91916225d929705b7b5c08811
Should deploy automatically within 30 minutes.
- Sam Ruby
On Wed, May 10, 2017 at 8:35 PM, Craig Russell wrote:
> The expected behavior:
>
> If the attached file ends
The expected behavior:
If the attached file ends in .PDF treat it as pdf. The code that displays the
file in the view panel does this correctly.
If the attached file ends in .PDF, write out the file as user-name.pdf not
user-name.PDF.
The content type analysis should also treat PDF as pdf.
So
I suspect that the bug is somewhere in icla.json.rb where the selected file
name ends with PDF not pdf.
# create/add file(s)
if @signature.to_s.empty? or not @selected.end_with? '.pdf'
message.write_svn("#{dir}/iclas", @filename, @selected, @signature)
else
message.write_s
What's the desired behavior?
The code that extracts the attachment uses the file name as is:
https://github.com/apache/whimsy/blob/master/www/secretary/workbench/models/attachment.rb#L69
The code that issues the commands does downcase the extension:
https://github.com/apache/whimsy/blob/master/
This happens when submitter capitalizes PDF. The file that is created
incorrectly ends in .PDF but the svn command ends in pdf.
• $ svn checkout --depth empty
https://svn.apache.org/repos/private/documents/iclas
/tmp/d20170510-4903-qckx05/iclas
Checked out revision 76572.
$ svn statu
On Thu, Jan 7, 2016 at 5:38 PM, Craig L Russell
wrote:
>
>> On Jan 7, 2016, at 6:08 AM, Sam Ruby wrote:
>>
>> I've pushed fixes to both. Thanks!
>
> Did you also look at č and š which are the other common (I know them;-) czech
> characters I see at times.
And then some:
https://github.com/apa
> On Jan 7, 2016, at 6:08 AM, Sam Ruby wrote:
>
> I've pushed fixes to both. Thanks!
Did you also look at č and š which are the other common (I know them;-) czech
characters I see at times.
>
> Unrelated, I'm wondering if it would make sense to the order of "Real
> Name" and "Public Name" in
I've pushed fixes to both. Thanks!
Unrelated, I'm wondering if it would make sense to the order of "Real
Name" and "Public Name" in the workbench form? At the moment, they
match the order that they appear in the ICLA, and I pre-fill in the
first using the name from the email, and then later use
Probably unrelated, but the same icla created a wrong entry for iclas.txt.
tl;dr the new tool puts a space in front of the stub name (Signed CLA;
robert-pozarickij instead of the proper Signed CLA;robert-pozarickij)
Craig
clr% svn up
Updating '.':
Ciclas.txt
Updated to revision 64621.
Confl
Robert Požarickij becomes robert-po-arickij for file name in icla handler.
I'd expect this to be robert-pozarickij.
Craig
Craig L Russell
Architect, Oracle
http://db.apache.org/jdo
408 276-5638 mailto:craig.russ...@oracle.com
P.S. A good JDO? O, Gasp!
15 matches
Mail list logo
