OK, I believe that there were two bugs here: https://github.com/apache/whimsy/commit/786413d74a2515f91916225d929705b7b5c08811
Should deploy automatically within 30 minutes. - Sam Ruby On Wed, May 10, 2017 at 8:35 PM, Craig Russell <craig.russ...@oracle.com> wrote: > The expected behavior: > > If the attached file ends in .PDF treat it as pdf. The code that displays the > file in the view panel does this correctly. > > If the attached file ends in .PDF, write out the file as user-name.pdf not > user-name.PDF. > > The content type analysis should also treat PDF as pdf. > > So attachment.rb should write a file with the pdf suffix not PDF. > > Craig > >> On May 10, 2017, at 4:51 PM, Sam Ruby <ru...@intertwingly.net> wrote: >> >> What's the desired behavior? >> >> The code that extracts the attachment uses the file name as is: >> >> https://github.com/apache/whimsy/blob/master/www/secretary/workbench/models/attachment.rb#L69 >> >> The code that issues the commands does downcase the extension: >> >> https://github.com/apache/whimsy/blob/master/www/secretary/workbench/views/actions/icla.json.rb#L14 >> >> Which one is right? >> >> - Sam Ruby >> >> On Wed, May 10, 2017 at 7:42 PM, Craig Russell <apache....@gmail.com> wrote: >>> This happens when submitter capitalizes PDF. The file that is created >>> incorrectly ends in .PDF but the svn command ends in pdf. >>> >>> • $ svn checkout --depth empty >>> https://svn.apache.org/repos/private/documents/iclas >>> /tmp/d20170510-4903-qckx05/iclas >>> >>> Checked out revision 76572. >>> >>> >>> $ svn status /tmp/d20170510-4903-qckx05/iclas >>> >>> A /tmp/d20170510-4903-qckx05/iclas/dmitry-pavlov.PDF >>> >>> >>> $ svn commit /tmp/d20170510-4903-qckx05/iclas/dmitry-pavlov.pdf -m 'ICLA >>> from Dmitry Pavlov' >>> >>> svn: E200009: Commit failed (details follow): >>> svn: E200009: '/tmp/d20170510-4903-qckx05/iclas/dmitry-pavlov.pdf' is not >>> under version control >>> >>> >>> Craig L Russell >>> Secretary, Apache Software Foundation >>> c...@apache.org http://db.apache.org/jdo >>> > > Craig L Russell > Architect > craig.russ...@oracle.com > P.S. A good JDO? O, Gasp! > > > > >
