On Thu, Jan 7, 2016 at 5:38 PM, Craig L Russell <craig.russ...@oracle.com> wrote: > >> On Jan 7, 2016, at 6:08 AM, Sam Ruby <ru...@intertwingly.net> wrote: >> >> I've pushed fixes to both. Thanks! > > Did you also look at č and š which are the other common (I know them;-) czech > characters I see at times.
And then some: https://github.com/apache/whimsy/blob/master/www/secmail/views/asciize.js.rb >> Unrelated, I'm wondering if it would make sense to the order of "Real >> Name" and "Public Name" in the workbench form? At the moment, they >> match the order that they appear in the ICLA, and I pre-fill in the >> first using the name from the email, and then later use the value in >> the first field to seed the value of the second. In testing, I'm >> noticing that the name in the email is more likely to match the public >> name, and the real name typically is longer (for example, with the >> addition of a middle name). > > Yes. The Public Name is taken from the email header and it's often the case > that I have to juggle the name from the email into the Real Name. In fact, I > often tab past the Real Name to get Public Name filled and then go back to > Real Name to manually enter the name from the ICLA. > > I think it will be confusing to have the order of Real Name and Public Name > switched in the tool because they don't show up that way on the form. > > But filling both Real Name and Public Name from the email name would help. > Save several keystrokes. Until you get one of those cases where somebody's secretary sends you a dozen ICLAs... > As long as we're here, if there is a comma in the email address it would be > nice to swap them. So, Smith, John would become John Smith in both form > fields. And Schmidt, John Jacob would become John Jacob Schmidt. ... unless the text after the comma is "Jr" or "Ph.D." ... fixed. >> Thoughts? > > It's hard to keep up with you. But that aside, it's coming together. :-) > Can you give me a pointer to how to add (Links) to the tool? Copy relevant portions of this: https://github.com/apache/whimsy/blob/master/www/secretary/workbench/worklist.cgi#L464 To a place like this: https://github.com/apache/whimsy/blob/master/www/secmail/views/parts.html.rb > Just found another problem. In 2016-01-07T19:51:54Z I dragged 2.jpg onto > 1.jpg and got 1.pdf. But 1.pdf is rotated left. Rotate right fixed it. And > then the magnifier + and - in the inline document area don't appear to work. > The magnifier works with other pdfs that come in the usual way. I'm not on my Mac at the moment, but it works on Ubuntu/Firefox. As you are aware, all I am doing is calling ImageMagick's convert followed by pdftk cat. > Craig - Sam Ruby
