[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-07-27 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887893058 "I'd like to understand when and where the decision was made that we should implement LDAP person." That's a question for Infra, but as far as I know, the ASF LDAP schema is

[GitHub] [whimsy] clr-apache commented on pull request #120: Family First support in secretary workbench

2021-07-27 Thread GitBox
clr-apache commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887884985 Hi Sebb, I am inclined to agree with you that the only reason we have LDAP sn is to satisfy a schema requirement that an LDAP "person" needs a cn and an sn. I'd li

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

2021-07-27 Thread GitBox
sebbASF commented on pull request #120: URL: https://github.com/apache/whimsy/pull/120#issuecomment-887426891 The test cases are in lib/spec/lib/person_spec.rb. However, I think this is all moot. I don't think there is a use-case for the sn and givenName fields. INFRA have a