I'd bet that the vast majority of the use of the http1.1 option was to
make sure the headers returned match the gold file. Perhaps autest
could know about headers and make case insensitive header name
matches?
(fwiw, the --http1.1 option was added in curl 7.33.0.)
On Wed, Jan 9, 2019 at 12:13 PM
I am inclined towards just skipping the tests if curl doesn't have
--http1.1 option. That would be the quickest workaround.
People who really want to run all the skipped tests can download it then.
On Wed, Jan 9, 2019 at 8:49 AM Walt Karas wrote:
> tcp_client.py doesn't support TLS. But, other
tcp_client.py doesn't support TLS. But, other than that major
deficiency, it's better for automated testing than curl. curl is
designed to work around problems in tricky ways in order to succeed in
copying the resource. It can sometimes mask problems that one is
hoping to find with automated reg
> On Jan 8, 2019, at 5:34 PM, Pushkar Pradhan wrote:
>
> Miles is right. Here's my output:
> [iwonttellyoumyusername@iwonttellyoumyhostname ~]$ cat /etc/redhat-release
> Red Hat Enterprise Linux Server release 7.5 (Maipo)
> [iwonttellyoumyusername@iwonttellyoumyhostname ~]$ curl --version
> cu
Miles is right. Here's my output:
[iwonttellyoumyusername@iwonttellyoumyhostname ~]$ cat /etc/redhat-release
Red Hat Enterprise Linux Server release 7.5 (Maipo)
[iwonttellyoumyusername@iwonttellyoumyhostname ~]$ curl --version
curl 7.29.0 (x86_64-redhat-linux-gnu) libcurl/7.29.0 NSS/3.28.4 zlib/1.2
On Tue, Jan 8, 2019 at 3:45 PM Leif Hedstrom wrote:
> > On Jan 8, 2019, at 4:06 PM, Pushkar Pradhan
> > wrote:
> >
> > Even RHEL7 sucks, they are also shipping with an old curl version that
> > doesn't support http1.1.
>
>
> I find that highly unlikely…
>
> [root@98291c1384a2 /]# cat /etc/redhat
> On Jan 8, 2019, at 4:06 PM, Pushkar Pradhan wrote:
>
> Even RHEL7 sucks, they are also shipping with an old curl version that
> doesn't support http1.1.
> The test was not being skipped, it tries to run the test.
> The quickest thing to do would be add a condition checking for http1.1?
Als
> On Jan 8, 2019, at 4:06 PM, Pushkar Pradhan wrote:
>
> Even RHEL7 sucks, they are also shipping with an old curl version that
> doesn't support http1.1.
I find that highly unlikely…
[root@98291c1384a2 /]# cat /etc/redhat-release
CentOS Linux release 7.6.1810 (Core)
[root@98291c1384a2 /]#
Even RHEL7 sucks, they are also shipping with an old curl version that
doesn't support http1.1.
The test was not being skipped, it tries to run the test.
The quickest thing to do would be add a condition checking for http1.1?
On Tue, Jan 8, 2019 at 2:32 PM Jason Kenny wrote:
> I do plan to add a
I do plan to add a switch to allow one to error on condition testing. This
should be easy to do. However I do report which test are skipped and why (
and if that reason is not good enough one can help fix the test as most if
not all these should be reason that can be provided with the condition
cal
> On Jan 8, 2019, at 2:27 PM, Alan Carroll
> wrote:
>
> Yes, we should include source of other tools only when there is no
> reasonable alternative and it's required to run ATS at all. We hope to
> remove YAMLCPP once a sufficiently recent version is in general
> distribution.
>
> I'm not su
Yes, we should include source of other tools only when there is no
reasonable alternative and it's required to run ATS at all. We hope to
remove YAMLCPP once a sufficiently recent version is in general
distribution.
I'm not sure not having the test disable is going to work in real life. It
means t
> On Jan 7, 2019, at 8:43 PM, Pushkar Pradhan wrote:
>
> Leif,
> I am fine with that. What do you think of my proposal of including a recent
> curl version in the repo?
I don’t think we should do that. :)
Getting an appropriate version of curl is not that big of a deal, certainly no
worse t
Leif,
I am fine with that. What do you think of my proposal of including a recent
curl version in the repo?
The other option is to fix the bootstrap.py to install it.
On RedHat the new curl is available in httpd24 but running that requires
prepending the curl command with scl enable
On my box
> On Jan 7, 2019, at 5:28 PM, Pushkar Pradhan wrote:
>
> Yes I saw that condition later. I think it could be done for http1.1 but is
> it a good idea to skip tests?
I’ve had this discussion before, and my personal preference would be that we
never do these types of checks, but rather, have t
Yes I saw that condition later. I think it could be done for http1.1 but is
it a good idea to skip tests?
On Mon, Jan 7, 2019 at 4:14 PM Walt Karas wrote:
> Many have this to skip if no http2 support but I don't know if it can
> be use to test support for http1.1 :
>
> # need Curl
> Test.SkipUnl
Many have this to skip if no http2 support but I don't know if it can
be use to test support for http1.1 :
# need Curl
Test.SkipUnless(
Condition.HasProgram("curl", "Curl need to be installed on system
for this test to work"),
Condition.HasCurlFeature('http2')
)
On Mon, Jan 7, 2019 at 4:5
I tried running the autests on the master branch and saw many many failures.
Most of them failed because my RHEL box doesn't have a recent curl that
supports http1.1 option.
The fix was obvious but I got no warning about this, I had to figure this
out.
Would it be reasonable to include and build t
18 matches
Mail list logo