I'd bet that the vast majority of the use of the http1.1 option was to make sure the headers returned match the gold file. Perhaps autest could know about headers and make case insensitive header name matches?
(fwiw, the --http1.1 option was added in curl 7.33.0.) On Wed, Jan 9, 2019 at 12:13 PM Pushkar Pradhan <pprad...@oath.com.invalid> wrote: > > I am inclined towards just skipping the tests if curl doesn't have > --http1.1 option. That would be the quickest workaround. > People who really want to run all the skipped tests can download it then. > > On Wed, Jan 9, 2019 at 8:49 AM Walt Karas <wka...@oath.com.invalid> wrote: > > > tcp_client.py doesn't support TLS. But, other than that major > > deficiency, it's better for automated testing than curl. curl is > > designed to work around problems in tricky ways in order to succeed in > > copying the resource. It can sometimes mask problems that one is > > hoping to find with automated regression testing. > > > > On Tue, Jan 8, 2019 at 11:15 PM Leif Hedstrom <zw...@apache.org> wrote: > > > > > > > > > > > > > On Jan 8, 2019, at 5:34 PM, Pushkar Pradhan <pprad...@oath.com.INVALID> > > wrote: > > > > > > > > Miles is right. Here's my output: > > > > [iwonttellyoumyusername@iwonttellyoumyhostname ~]$ cat > > /etc/redhat-release > > > > Red Hat Enterprise Linux Server release 7.5 (Maipo) > > > > [iwonttellyoumyusername@iwonttellyoumyhostname ~]$ curl --version > > > > curl 7.29.0 (x86_64-redhat-linux-gnu) libcurl/7.29.0 NSS/3.28.4 > > zlib/1.2.7 > > > > libidn/1.28 libssh2/1.4.3 > > > > > > > > > Ah, that makes a lot more sense :). > > > > > > I honestly think it’s fine to require a more recent version of curl (or, > > use some curl like interface in Python?). Retaining compatibility with all > > the versions of Linux that we support is important for ATS, but I don’t > > think that applies to running autest. As long as it’s well document what > > tool chain is required for autest, we should be fine IMO. > > > > > > Cheers, > > > > > > — Leif > > > > > > > > -- > pushkar
