Leif,
I am fine with that. What do you think of my proposal of including a recent
curl version in the repo?
The other option is to fix the bootstrap.py to install it.
On RedHat the new curl is available in httpd24 but running that requires
prepending the curl command with scl enable....
On my box it also skipped TLS related tests, I am sure there's another tool
I am missing.
On Mon, Jan 7, 2019 at 7:39 PM Leif Hedstrom <zw...@apache.org> wrote:
>
>
> > On Jan 7, 2019, at 5:28 PM, Pushkar Pradhan <pprad...@oath.com.INVALID>
> wrote:
> >
> > Yes I saw that condition later. I think it could be done for http1.1 but
> is
> > it a good idea to skip tests?
>
> I’ve had this discussion before, and my personal preference would be that
> we never do these types of checks, but rather, have the check fail, with a
> good (obvious!) error message explaining what actions needs to be taken.
>
> The danger with the current approach, which we’ve run into numerous times,
> is that it essentially silently skips tests.
>
> If I have a vote, i’d say get rid of all “feature” tests like this, and
> let them fail (again, with good errors). Then we can fix our CI and our dev
> tools accordingly.
>
> My $.01,
>
> — Leif
>
> >
> > On Mon, Jan 7, 2019 at 4:14 PM Walt Karas <wka...@oath.com.invalid>
> wrote:
> >
> >> Many have this to skip if no http2 support but I don't know if it can
> >> be use to test support for http1.1 :
> >>
> >> # need Curl
> >> Test.SkipUnless(
> >> Condition.HasProgram("curl", "Curl need to be installed on system
> >> for this test to work"),
> >> Condition.HasCurlFeature('http2')
> >> )
> >>
> >> On Mon, Jan 7, 2019 at 4:58 PM Pushkar Pradhan
> >> <pprad...@oath.com.invalid> wrote:
> >>>
> >>> I tried running the autests on the master branch and saw many many
> >> failures.
> >>> Most of them failed because my RHEL box doesn't have a recent curl that
> >>> supports http1.1 option.
> >>> The fix was obvious but I got no warning about this, I had to figure
> this
> >>> out.
> >>>
> >>> Would it be reasonable to include and build the latest curl sources?
> >>> Just like how we include yaml-cpp.
> >>> --
> >>> pushkar
> >>
> >
> >
> > --
> > pushkar
>
>
--
pushkar
