Re: Unit Test Framework

2017-05-25 Thread Jason Kenny
I still think catch will work better.. it is lighter and easier to make tests for no binaries needed On ‎Thursday‎, ‎May‎ ‎25‎, ‎2017‎ ‎02‎:‎23‎:‎02‎ ‎PM‎ ‎CDT, Leif Hedstrom wrote: > On May 24, 2017, at 10:17 PM, James Peach wrote: > > > > On 24 May 2017, at 15:00, Alan Carroll wrote:

Re: Unit Test Framework

2017-05-25 Thread Bryan Call
Add it to our tree or automate a clone. We will need to have the Makefiles build and test it. -Bryan > On May 25, 2017, at 12:22 PM, Leif Hedstrom wrote: > > >> On May 24, 2017, at 10:17 PM, James Peach wrote: >> >> >> >> On 24 May 2017, at 15:00, Alan Carroll wrote: >> >>> James; it's

Re: Unit Test Framework

2017-05-25 Thread Leif Hedstrom
> On May 24, 2017, at 10:17 PM, James Peach wrote: > > > > On 24 May 2017, at 15:00, Alan Carroll wrote: > >> James; it's precisely because those tests don't depend on anything else in >> traffic_server that it seems bogus to require building and running it to do >> the tests. If you're in

Re: Unit Test Framework

2017-05-25 Thread Jason Kenny
at 6:09 PM, Gancho Tenev wrote: > > One framework and justice for all (or to rule them all) :) > >> One framework :) > > I think most of us already agree that we should have: 1 unit test framework > and 1 integration test framework and have all the tests run as part of o

Re: Unit Test Framework

2017-05-25 Thread Jason Kenny
>>The tests drag in traffic_server because of the link-time dependencies >>of the systems they are testing, not because of the test framework. This is exactly right. I would go on by saying how I want to clean this mess upThe main point we have to understand is that the current build logic

Re: Unit Test Framework

2017-05-24 Thread James Peach
On 24 May 2017, at 15:00, Alan Carroll wrote: James; it's precisely because those tests don't depend on anything else in traffic_server that it seems bogus to require building and running it to do the tests. If you're in a tight edit/compile/test cycle it's nice to not have to drag in everyt

Re: Unit Test Framework

2017-05-24 Thread Alan Carroll
people don’t accidentally write tests for it. -Bryan > On May 23, 2017, at 6:09 PM, Gancho Tenev wrote: > > One framework and justice for all (or to rule them all) :) > >> One framework :) > > I think most of us already agree that we should have: 1 unit test framework

Re: Unit Test Framework

2017-05-24 Thread Bryan Call
or it. -Bryan > On May 23, 2017, at 6:09 PM, Gancho Tenev wrote: > > One framework and justice for all (or to rule them all) :) > >> One framework :) > > I think most of us already agree that we should have: 1 unit test framework > and 1 integration test framework and h

Re: Unit Test Framework

2017-05-24 Thread James Peach
much more heavy weight than a > good unit test framework should be. Real unit testing should load as little > additional code as possible. There are a number of examples of using TestBox and REGRESSION_TEST for unit tests that don't depend on traffic_server. Depending on wha

Re: Unit Test Framework

2017-05-24 Thread Alan Carroll
Even though I wrote TestBox I think we need to migrate away from it. It's big flaw is it is built to support regression tests which means using it involves bringing up the traffic_server process. That's much more heavy weight than a good unit test framework should be. Real unit test

Re: Unit Test Framework

2017-05-24 Thread Masakazu Kitajo
Thanks, Masakazu On Tue, May 23, 2017 at 6:09 PM, Gancho Tenev wrote: > One framework and justice for all (or to rule them all) :) > > > One framework :) > > I think most of us already agree that we should have: 1 unit test > framework and 1 integration test framework and have al

Re: Unit Test Framework

2017-05-23 Thread Gancho Tenev
One framework and justice for all (or to rule them all) :) > One framework :) I think most of us already agree that we should have: 1 unit test framework and 1 integration test framework and have all the tests run as part of our build / verification stage. How to get to that point is wher

Re: Unit Test Framework

2017-05-23 Thread Jason Kenny
I would suggest for unit testing. https://github.com/philsquared/Catch This has been nice to use. This does not require use to sync a bunch of binaries to get it to work. I think most the of the plugins will test better with AuTest. There will still be a need to unit test APIs in trafficserver or

Re: Unit Test Framework

2017-05-23 Thread Alan M. Carroll
For full up plugin testing we (Yahoo!) are using the AUTest framework. In fact there are already plugin based tests checked in to master (see tests/gold_tests/pluginTests/header_rewrite for an example). I think that is fine for testing the plugin in situ and we should adopt it as our preferred

Re: Unit Test Framework

2017-05-22 Thread James Peach
On 20 May 2017, at 20:12, gan...@apache.org wrote: Hi trafficserver-dev, (1) I was wondering if we have any preference for a C/C++ unit test framework in the ATS community. Background and thoughts: I needed a unit test framework quickly to do TDD in order to deliver the AWS auth v4 (PR

Re: Unit Test Framework

2017-05-22 Thread Masakazu Kitajo
d. Thanks, Masakazu On Sat, May 20, 2017 at 8:12 PM, wrote: > Hi trafficserver-dev, > > > (1) I was wondering if we have any preference for a C/C++ unit test > framework in the ATS community. > > Background and thoughts: > > I needed a unit test framework quickly to do

Re: Unit Test Framework

2017-05-20 Thread Shu Kit Chan
For 1), We have a long standing PR to add a unit test framework for C++ plugins. We also wrote tests for the webp transform plugin using that framework. We can revisit this and see if this is a good starting point. https://github.com/apache/trafficserver/pull/408 We still need a good unit test

Unit Test Framework

2017-05-20 Thread gancho
Hi trafficserver-dev, (1) I was wondering if we have any preference for a C/C++ unit test framework in the ATS community. Background and thoughts: I needed a unit test framework quickly to do TDD in order to deliver the AWS auth v4 (PR #1946). Google Test seemed easy to bootstrap, popular

Unit Test Framework

2017-05-20 Thread gttenev
Hi trafficserver-dev, (1) I was wondering if we have any preference for a C/C++ unit test framework in the ATS community. Background and thoughts: I needed a unit test framework quickly to do TDD in order to deliver the AWS auth v4 (PR #1946). Google Test seemed easy to bootstrap, popular