Add it to our tree or automate a clone. We will need to have the Makefiles build and test it.
-Bryan > On May 25, 2017, at 12:22 PM, Leif Hedstrom <zw...@apache.org> wrote: > > >> On May 24, 2017, at 10:17 PM, James Peach <jpe...@apache.org> wrote: >> >> >> >> On 24 May 2017, at 15:00, Alan Carroll wrote: >> >>> James; it's precisely because those tests don't depend on anything else in >>> traffic_server that it seems bogus to require building and running it to do >>> the tests. If you're in a tight edit/compile/test cycle it's nice to not >>> have to drag in everything else. >> >> I can’t tell whether we are talking past each other or agreeing with each >> other :) >> >> The tests drag in traffic_server because of the link-time dependencies of >> the systems they are testing, not because of the test framework. > > > > There seems to be a general consensus / acceptance around Google Test (gtest) > ? > > Fwiw, I did some quick prodding, and other than some very modern distros, > e.g. F25 and Ubuntu 16/17, gtest is generally not (easily) available to > install. Worse ( :-) ), is that HomeBrew will not let you install it either: > > munin (13:22) 258/0 $ brew install gtest > Error: No available formula with the name "gtest" > Installing gtest system-wide is not recommended; it should be vendored > in your projects that use it. > > > Should we consider bundling gtest with our source ? > > Cheers, > > — Leif >