Ok well in that case maybe this does make more sense to integrate as a
part of the plugindso code via its own APIs, such as the ones to
notify of a full remap reload pre/post. Instead have a new api in
there of a per-plugin config file that it can keep track of and notify
the plugin who registered
I don't think periodic reload of config for regex_revalidate is optional.
Pretty certain we used that functionality in the past (for purging tombstones
that get added on the fly).
Reloading just the config is not the same as reloading the remap DSO or
conflicts with the remap reload even.
The
regex reval first uses the tsmgmtupdate call in all cases, so it will
be triggered by a config reload and since it's a global plugin it can
do that, the periodic reload is optional. During the last summit
there was a lot of concern over remap.config reloading on its own
outside of config reload du
Hmm..I am not sure to understand the concern with reloading individual config
files outside of "config reload".
I think a reasonable approach is to use a background thread periodically
polling for config file changes and load it in isolation (an example is
regex_revalidate plugin).
https://gith
Currently there is no way for a plugin to just reload its config file
when it is running as a remap, unless you are running some sort of
timer or checking on every remap call. The mgmtupdate cannot be used
for remaps due to how it is designed. Using a timer you then start
reloading configs outside
IMO a config file change should just cause the config to be reloaded no the
entire remap or plugin DSO.
Thanks
John
On Tue, Jul 21, 2020 at 4:03 PM Sudheer Vinukonda <
sudheervinuko...@yahoo.com> wrote:
> I think it makes sense when "includes" are changed, but, I'm wondering if
> it makes sense
I think it makes sense when "includes" are changed, but, I'm wondering if it
makes sense to reload the remap file when a specific config file for a plugin
is changed.
Shouldn't a plugin config file change limit to reloading the plugin (or even
just the config file for that plugin) as opposed t
