Hmm..I am not sure to understand the concern with reloading individual config
files outside of "config reload".
I think a reasonable approach is to use a background thread periodically
polling for config file changes and load it in isolation (an example is
regex_revalidate plugin).
https://github.com/apache/trafficserver/blob/master/plugins/regex_revalidate/regex_revalidate.c
What are the concerns with that approach?
On Tuesday, July 21, 2020, 03:45:37 PM PDT, Evan Zelkowitz
<e...@apache.org> wrote:
Currently there is no way for a plugin to just reload its config file
when it is running as a remap, unless you are running some sort of
timer or checking on every remap call. The mgmtupdate cannot be used
for remaps due to how it is designed. Using a timer you then start
reloading configs outside of the specified config reload call which
many do not like (since we had the previous issue of the remap
reloading on its own when it was changed). I suggest reloading the
remap because that keeps this within a well designed workflow that we
already know wrt to reference counting and deletion/instantiation of
plugins and what data they will be loaded with
I suppose another option would be to add functionality to the
PluginDSO and have it do file monitoring as requested by plugins to
reload individual ones rather than just the blanket remap reload, but
currently anything dealing with config files like that is already
handled by the manager, this would be a large extension to the plugin
code
On Tue, Jul 21, 2020 at 4:24 PM John Rushford <jjrushf...@gmail.com> wrote:
>
> IMO a config file change should just cause the config to be reloaded no the
> entire remap or plugin DSO.
>
> Thanks
> John
>
> On Tue, Jul 21, 2020 at 4:03 PM Sudheer Vinukonda
> <sudheervinuko...@yahoo.com> wrote:
>>
>> I think it makes sense when "includes" are changed, but, I'm wondering if it
>> makes sense to reload the remap file when a specific config file for a
>> plugin is changed.
>>
>> Shouldn't a plugin config file change limit to reloading the plugin (or even
>> just the config file for that plugin) as opposed to reloading the entire
>> remap config?
>>
>> Thanks,
>>
>> Sudheer
>>
>>
>> On Tuesday, July 21, 2020, 02:24:53 PM PDT, Evan Zelkowitz <e...@apache.org>
>> wrote:
>>
>>
>> There is an issue surrounding remap reloading when includes and plugin
>> config files are used. These will not trigger a remap reload on their
>> own. I think at this point everyone uses their external management
>> tools to issue a touch to the remap file to trigger a reload to
>> happen, but it's a bit of a work-around.
>>
>> I'm proposing adding an API that will allow plugins to register their
>> config files to be monitored in the same way that remap and records
>> are currently monitored. When a traffic_ctl config reload is issued,
>> if one of these files has changed that can also trigger a remap
>> reload.
>>
>> I have a POC going currently where I can add an arbitrary file to
>> trigger the reload but got to the point of looking at the API so
>> figured I would send out a list message for any ideas/concerns/etc
>>
>> - Evan
>
>
>
> --
> John Rushford
> jjrushf...@gmail.com
