IMO a config file change should just cause the config to be reloaded no the entire remap or plugin DSO.
Thanks John On Tue, Jul 21, 2020 at 4:03 PM Sudheer Vinukonda < sudheervinuko...@yahoo.com> wrote: > I think it makes sense when "includes" are changed, but, I'm wondering if > it makes sense to reload the remap file when a specific config file for a > plugin is changed. > > Shouldn't a plugin config file change limit to reloading the plugin (or > even just the config file for that plugin) as opposed to reloading the > entire remap config? > > Thanks, > > Sudheer > > > On Tuesday, July 21, 2020, 02:24:53 PM PDT, Evan Zelkowitz <e...@apache.org> > wrote: > > > There is an issue surrounding remap reloading when includes and plugin > config files are used. These will not trigger a remap reload on their > own. I think at this point everyone uses their external management > tools to issue a touch to the remap file to trigger a reload to > happen, but it's a bit of a work-around. > > I'm proposing adding an API that will allow plugins to register their > config files to be monitored in the same way that remap and records > are currently monitored. When a traffic_ctl config reload is issued, > if one of these files has changed that can also trigger a remap > reload. > > I have a POC going currently where I can add an arbitrary file to > trigger the reload but got to the point of looking at the API so > figured I would send out a list message for any ideas/concerns/etc > > - Evan > -- John Rushford jjrushf...@gmail.com
