Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-15 Thread Leif Hedstrom
> On Jun 15, 2020, at 1:45 AM, Masakazu Kitajo wrote: > > Are we ok with anonymous commits like below now? I remember some of us > didn't like it before. > https://lists.apache.org/thread.html/930e933eaf6067f4ab70ec8ac3fd439d5d286d13461c1f8a402dfa87%40%3Cdev.trafficserver.apache.org%3E > > co

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-15 Thread Damian Meden
+1 On Mon, Jun 15, 2020 at 3:49 PM Walt Karas wrote: > +1 as long as it doesn't cause uncommented commits. > > On Mon, Jun 15, 2020 at 9:43 AM Steven R. Feltner > wrote: > > > +1 > > > > On 6/14/20, 11:32 AM, "Bryan Call" wrote: > > > > Notice: This email is from an external sender. > > >

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-15 Thread Walt Karas
+1 as long as it doesn't cause uncommented commits. On Mon, Jun 15, 2020 at 9:43 AM Steven R. Feltner wrote: > +1 > > On 6/14/20, 11:32 AM, "Bryan Call" wrote: > > Notice: This email is from an external sender. > > > > I would like to propose that we switch to "Squash and Merge" for >

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-15 Thread Steven R. Feltner
+1 On 6/14/20, 11:32 AM, "Bryan Call" wrote: Notice: This email is from an external sender. I would like to propose that we switch to "Squash and Merge" for GitHub as the only option for merging pull requests. This would mean we would remove the options “Rebase and Merge” and “Cre

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-15 Thread Masakazu Kitajo
Are we ok with anonymous commits like below now? I remember some of us didn't like it before. https://lists.apache.org/thread.html/930e933eaf6067f4ab70ec8ac3fd439d5d286d13461c1f8a402dfa87%40%3Cdev.trafficserver.apache.org%3E commit d7345f675012c04e4d7ec36b4eaf6fc825bdf7f8 Author: Leif Hedstrom

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-14 Thread Brian Neradt
+1 On Sun, Jun 14, 2020 at 4:00 PM Evan Zelkowitz wrote: > +1 > > On Sun, Jun 14, 2020 at 2:17 PM Alan Carroll > wrote: > > > > +1 > > > > On Sun, Jun 14, 2020 at 11:27 AM Leif Hedstrom wrote: > > > > > +1 > > > > > > > On Jun 14, 2020, at 09:32, Bryan Call wrote: > > > > > > > > I would lik

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-14 Thread Evan Zelkowitz
+1 On Sun, Jun 14, 2020 at 2:17 PM Alan Carroll wrote: > > +1 > > On Sun, Jun 14, 2020 at 11:27 AM Leif Hedstrom wrote: > > > +1 > > > > > On Jun 14, 2020, at 09:32, Bryan Call wrote: > > > > > > I would like to propose that we switch to "Squash and Merge" for GitHub > > as the only option for

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-14 Thread Alan Carroll
+1 On Sun, Jun 14, 2020 at 11:27 AM Leif Hedstrom wrote: > +1 > > > On Jun 14, 2020, at 09:32, Bryan Call wrote: > > > > I would like to propose that we switch to "Squash and Merge" for GitHub > as the only option for merging pull requests. This would mean we would > remove the options “Rebas

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-14 Thread Leif Hedstrom
+1 > On Jun 14, 2020, at 09:32, Bryan Call wrote: > > I would like to propose that we switch to "Squash and Merge" for GitHub as > the only option for merging pull requests. This would mean we would remove > the options “Rebase and Merge” and “Create a merge commit”. > > When a PR with mult

Re: [PROPOSAL] GitHub change to Squash and Merge

2020-06-14 Thread Sudheer Vinukonda
+1 > On Jun 14, 2020, at 8:32 AM, Bryan Call wrote: > > I would like to propose that we switch to "Squash and Merge" for GitHub as > the only option for merging pull requests. This would mean we would remove > the options “Rebase and Merge” and “Create a merge commit”. > > When a PR with mu