Are we ok with anonymous commits like below now? I remember some of us
didn't like it before.
https://lists.apache.org/thread.html/930e933eaf6067f4ab70ec8ac3fd439d5d286d13461c1f8a402dfa87%40%3Cdev.trafficserver.apache.org%3E

commit d7345f675012c04e4d7ec36b4eaf6fc825bdf7f8
Author:     Leif Hedstrom <zw...@apache.org>
AuthorDate: Mon Jun 1 13:19:59 2020 -0600
Commit:     GitHub <nore...@github.com>
CommitDate: Mon Jun 1 13:19:59 2020 -0600

I'm not 100% sure but it seems like Squash and Merge causes commits like
this.

Masakazu

On Mon, Jun 15, 2020 at 12:32 AM Bryan Call <bc...@apache.org> wrote:

> I would like to propose that we switch to "Squash and Merge" for GitHub as
> the only option for merging pull requests.  This would mean we would remove
> the options “Rebase and Merge” and “Create a merge commit”.
>
> When a PR with multiple commits gets merged into the tree without
> squashing, the release manager needs to track down all of the commits and
> cherry pick each one of them into the release branch in order.  This change
> would simplify the workflow for the release managers.
>
> Unfortunately GitHub defaults to the last used merge option instead of
> being to set a default for the project.  This is why it is better to remove
> the other two options.
>
> If you need to have multiple commits to go into the tree for a change,
> this would require that multiple PRs would have to be created.  This should
> be a rare event.
>
> -Bryan
>
>

Reply via email to