> On Jun 15, 2020, at 1:45 AM, Masakazu Kitajo <mas...@apache.org> wrote:
> 
> Are we ok with anonymous commits like below now? I remember some of us
> didn't like it before.
> https://lists.apache.org/thread.html/930e933eaf6067f4ab70ec8ac3fd439d5d286d13461c1f8a402dfa87%40%3Cdev.trafficserver.apache.org%3E
> 
> commit d7345f675012c04e4d7ec36b4eaf6fc825bdf7f8
> Author:     Leif Hedstrom <zw...@apache.org>
> AuthorDate: Mon Jun 1 13:19:59 2020 -0600
> Commit:     GitHub <nore...@github.com>
> CommitDate: Mon Jun 1 13:19:59 2020 -0600


Yeh, I don’t know that we have much of a choice here. What happens is that 
“GitHub” makes the commit, not the person pushing the “Squash and merge” 
button?  I think we would have to go to the Github PR to actually see who 
pressed the button. Not ideal, but until they make the merge button always 
default to “Squash” (and not previously used, which is just dumb), I think this 
is the best option.

— Leif

Reply via email to